From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B0ED72C18 for ; Fri, 28 Apr 2017 10:07:09 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 01:07:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="962079514" Received: from dpdktest46-2.sh.intel.com ([10.239.129.144]) by orsmga003.jf.intel.com with ESMTP; 28 Apr 2017 01:07:05 -0700 From: Yulong Pei To: dev@dpdk.org Cc: jingjing.wu@intel.com, thomas@monjalon.net Date: Fri, 28 Apr 2017 10:01:55 +0800 Message-Id: <1493344915-127542-1-git-send-email-yulong.pei@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH v4] app/testpmd: initialize port_numa and ring_numa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 08:07:10 -0000 Previous numa_support = 0 by default, it need to add --numa to testpmd command line to enable numa, so port_numa and ring_numa were initialized at function launch_args_parse(), now testpmd change numa_support = 1 as default, so port_numa and ring_numa also need to initialize by default, otherwise port->socket_id will be probed to wrong value. Fixes: 999b2ee0fe45 ("app/testpmd: enable NUMA support by default") Signed-off-by: Yulong Pei --- app/test-pmd/parameters.c | 6 +----- app/test-pmd/testpmd.c | 6 ++++++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 3f4d3a2..3296b3a 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -665,12 +665,8 @@ launch_args_parse(int argc, char** argv) parse_fwd_portmask(optarg); if (!strcmp(lgopts[opt_idx].name, "no-numa")) numa_support = 0; - if (!strcmp(lgopts[opt_idx].name, "numa")) { + if (!strcmp(lgopts[opt_idx].name, "numa")) numa_support = 1; - memset(port_numa,NUMA_NO_CONFIG,RTE_MAX_ETHPORTS); - memset(rxring_numa,NUMA_NO_CONFIG,RTE_MAX_ETHPORTS); - memset(txring_numa,NUMA_NO_CONFIG,RTE_MAX_ETHPORTS); - } if (!strcmp(lgopts[opt_idx].name, "mp-anon")) { mp_anon = 1; } diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 3a57348..606bfd1 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -543,6 +543,12 @@ init_config(void) fwd_lcores[lc_id]->cpuid_idx = lc_id; } + if (numa_support) { + memset(port_numa, NUMA_NO_CONFIG, RTE_MAX_ETHPORTS); + memset(rxring_numa, NUMA_NO_CONFIG, RTE_MAX_ETHPORTS); + memset(txring_numa, NUMA_NO_CONFIG, RTE_MAX_ETHPORTS); + } + /* * Create pools of mbuf. * If NUMA support is disabled, create a single pool of mbuf in -- 2.7.4