From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 723B344153; Tue, 4 Jun 2024 14:19:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E77B40E25; Tue, 4 Jun 2024 14:19:32 +0200 (CEST) Received: from fout8-smtp.messagingengine.com (fout8-smtp.messagingengine.com [103.168.172.151]) by mails.dpdk.org (Postfix) with ESMTP id 9C5B1402E3 for ; Tue, 4 Jun 2024 14:19:31 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 1147C138012C; Tue, 4 Jun 2024 08:19:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 04 Jun 2024 08:19:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1717503571; x=1717589971; bh=x+s6yoJP+QO78qY1yNMZjKV6lIBlYLjy7zcH90Le7d4=; b= lHZGpyr90kkKCHc7FbdIqj/uDrX4X75hH1xAtLztAeGWrWItcZSSJ1DcP7r1T4dN VGye6iMTXI2Q2LDhYCrzecLzdBYH2qlhUQ7CCnUM2HwTcRG3dc0weHSpQMoyW3qc uixwKGqJ+GtPJuPDNFpT8iN4iLfLTciA/DPcUPtSHgsguQlKILspY+RGEymzZYYN 7HtdTDj/T7ggKuXxJj1UsQ2q4JfskHp5lbxvR54I5j7FF/g/P2kfIrMJjFMyUNdK RQ0UutYhdCBLAI4IeoMSYFp1MaGfveM4HR36259ZAgPlxjJA5MGhUc/ysf0ybaNi FVGOKrzlgPVW9ZdcfeX1IQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1717503571; x= 1717589971; bh=x+s6yoJP+QO78qY1yNMZjKV6lIBlYLjy7zcH90Le7d4=; b=f 5YeVw5Lo9305wD/mYhk7zGo57BS9spKYDPwXtM0ju/6mY0gUn2yWDlkKUojI6cAk DEpCYa03PZN+B2L5j40vpg+IjYemOE0JCB9Hdgek1iz38RlvxrWJDbud0mi/sg4x 2QQR7KtPzk843QnHnrJyRsmjkAukg2T1q5WVGZlmZ8n8wmTVwN9GmLwSxUVvqTmS /TssOm6ZkugfcpoziKiWCi22wIdvdlzmmUbRZaLE4AN+iiHX5b7OreI0Yz9FFcAW 5Q+j3XOo1UxsEoB0jfKuA+hVeKn3NgJTT66p/Xbkq3SmHCZt8CuiuTtPLzAOP2IP ZL649WyGwi5tZ6utVndjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdelgedggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeek gfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Jun 2024 08:19:29 -0400 (EDT) From: Thomas Monjalon To: Rongwei Liu Cc: dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, suanmingm@nvidia.com, Dariusz Sosnowski Subject: Re: [PATCH v2 4/4] net/mlx5: implement VXLAN last reserved modification Date: Tue, 04 Jun 2024 14:19:28 +0200 Message-ID: <14937324.O6BkTfRZtg@thomas> In-Reply-To: <20240527024720.1099161-5-rongweil@nvidia.com> References: <20240527024720.1099161-1-rongweil@nvidia.com> <20240527024720.1099161-5-rongweil@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/05/2024 04:47, Rongwei Liu: > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -685,6 +685,11 @@ Limitations > - Second tunnel fields are not supported. > > - Encapsulation levels greater than ``2`` are not supported. > + - Modification of the VXLAN header is supported with below limitations: > + > + - Only in HW steering (``dv_flow_en=2``). > + - Support VNI and rsvd1 modifications for traffic with default VXLAN/VXLAN-GPE/VXLAN-GBP > + UDP destination port. Don't add at the end of bullet lists without trying to order. It is limitation for a specific protocol, it should go above with other protocols, between "Modification of VXLAN network" and GENEVE limitations. "rsvd1" should be replaced with "last reserved byte". What do you mean with "default VXLAN/VXLAN-GPE/VXLAN-GBP UDP destination port"? Is it port 4789 for VXLAN and VXLAN-GBP, and port 4790 for VXLAN-GPE? We need to be more specific probably.