From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 594812C18 for ; Fri, 5 May 2017 15:57:25 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9D7B180C21; Fri, 5 May 2017 13:57:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9D7B180C21 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jfreiman@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9D7B180C21 Received: from virtlab417.ml3.eng.bos.redhat.com (virtlab417.ml3.eng.bos.redhat.com [10.19.176.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5374882798; Fri, 5 May 2017 13:57:24 +0000 (UTC) From: Jens Freimann To: yuanhan.liu@linux.intel.com Cc: dev@dpdk.org Date: Fri, 5 May 2017 09:57:12 -0400 Message-Id: <1493992642-52756-2-git-send-email-jfreiman@redhat.com> In-Reply-To: <1493992642-52756-1-git-send-email-jfreiman@redhat.com> References: <1493992642-52756-1-git-send-email-jfreiman@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 05 May 2017 13:57:24 +0000 (UTC) Subject: [dpdk-dev] [RFC PATCH 01/11] net/virtio: vring init for 1.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2017 13:57:25 -0000 From: Yuanhan Liu Add and initialize descriptor data structures. Signed-off-by: Yuanhan Liu [rename desc_1_1 to vring_desc_1_1, refactor desc init code] Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio-1.1.h | 19 +++++++++++++++++++ drivers/net/virtio/virtio_ethdev.c | 22 ++++++++++++---------- drivers/net/virtio/virtio_pci.h | 7 +++++++ drivers/net/virtio/virtio_ring.h | 15 +++++++++++++-- drivers/net/virtio/virtqueue.h | 10 ++++++++++ 5 files changed, 61 insertions(+), 12 deletions(-) create mode 100644 drivers/net/virtio/virtio-1.1.h diff --git a/drivers/net/virtio/virtio-1.1.h b/drivers/net/virtio/virtio-1.1.h new file mode 100644 index 0000000..48cbb18 --- /dev/null +++ b/drivers/net/virtio/virtio-1.1.h @@ -0,0 +1,19 @@ +#ifndef __VIRTIO_1_1_H +#define __VIRTIO_1_1_H + +#define VRING_DESC_F_NEXT 1 +#define VRING_DESC_F_WRITE 2 +#define VRING_DESC_F_INDIRECT 4 + +#define BATCH_NOT_FIRST 0x0010 +#define BATCH_NOT_LAST 0x0020 +#define DESC_HW 0x0080 + +struct vring_desc_1_1 { + uint64_t addr; + uint32_t len; + uint16_t index; + uint16_t flags; +}; + +#endif /* __VIRTIO_1_1_H */ diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index b23f4c2..a5db503 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -320,19 +320,21 @@ struct rte_virtio_xstats_name_off { PMD_INIT_FUNC_TRACE(); - /* - * Reinitialise since virtio port might have been stopped and restarted - */ memset(ring_mem, 0, vq->vq_ring_size); - vring_init(vr, size, ring_mem, VIRTIO_PCI_VRING_ALIGN); - vq->vq_used_cons_idx = 0; - vq->vq_desc_head_idx = 0; - vq->vq_avail_idx = 0; - vq->vq_desc_tail_idx = (uint16_t)(vq->vq_nentries - 1); + vring_init(vq->hw, vr, size, ring_mem, VIRTIO_PCI_VRING_ALIGN); + vq->vq_free_cnt = vq->vq_nentries; memset(vq->vq_descx, 0, sizeof(struct vq_desc_extra) * vq->vq_nentries); + vq->vq_used_cons_idx = 0; + vq->vq_avail_idx = 0; + if (vtpci_version_1_1(vq->hw)) { + vring_desc_init_1_1(vr, size); + } else { + vq->vq_desc_head_idx = 0; + vq->vq_desc_tail_idx = (uint16_t)(vq->vq_nentries - 1); - vring_desc_init(vr->desc, size); + vring_desc_init(vr->desc, size); + } /* * Disable device(host) interrupting guest @@ -407,7 +409,7 @@ struct rte_virtio_xstats_name_off { /* * Reserve a memzone for vring elements */ - size = vring_size(vq_size, VIRTIO_PCI_VRING_ALIGN); + size = vring_size(hw, vq_size, VIRTIO_PCI_VRING_ALIGN); vq->vq_ring_size = RTE_ALIGN_CEIL(size, VIRTIO_PCI_VRING_ALIGN); PMD_INIT_LOG(DEBUG, "vring_size: %d, rounded_vring_size: %d", size, vq->vq_ring_size); diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h index 18caebd..ec74009 100644 --- a/drivers/net/virtio/virtio_pci.h +++ b/drivers/net/virtio/virtio_pci.h @@ -140,6 +140,7 @@ #define VIRTIO_F_VERSION_1 32 #define VIRTIO_F_IOMMU_PLATFORM 33 +#define VIRTIO_F_VERSION_1_1 34 /* * Some VirtIO feature bits (currently bits 28 through 31) are @@ -318,6 +319,12 @@ struct virtio_net_config { return (hw->guest_features & (1ULL << bit)) != 0; } +static inline int +vtpci_version_1_1(struct virtio_hw *hw) +{ + return vtpci_with_feature(hw, VIRTIO_F_VERSION_1_1); +} + /* * Function declaration from virtio_pci.c */ diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h index fcecc16..a991092 100644 --- a/drivers/net/virtio/virtio_ring.h +++ b/drivers/net/virtio/virtio_ring.h @@ -38,6 +38,8 @@ #include +#include "virtio-1.1.h" + /* This marks a buffer as continuing via the next field. */ #define VRING_DESC_F_NEXT 1 /* This marks a buffer as write-only (otherwise read-only). */ @@ -88,6 +90,7 @@ struct vring { struct vring_desc *desc; struct vring_avail *avail; struct vring_used *used; + struct vring_desc_1_1 *desc_1_1; }; /* The standard layout for the ring is a continuous chunk of memory which @@ -124,10 +127,13 @@ struct vring { #define vring_avail_event(vr) (*(uint16_t *)&(vr)->used->ring[(vr)->num]) static inline size_t -vring_size(unsigned int num, unsigned long align) +vring_size(struct virtio_hw *hw, unsigned int num, unsigned long align) { size_t size; + if (vtpci_version_1_1(hw)) + return num * sizeof(struct vring_desc_1_1); + size = num * sizeof(struct vring_desc); size += sizeof(struct vring_avail) + (num * sizeof(uint16_t)); size = RTE_ALIGN_CEIL(size, align); @@ -137,10 +143,15 @@ struct vring { } static inline void -vring_init(struct vring *vr, unsigned int num, uint8_t *p, +vring_init(struct virtio_hw *hw, struct vring *vr, unsigned int num, uint8_t *p, unsigned long align) { vr->num = num; + if (vtpci_version_1_1(hw)) { + vr->desc_1_1 = (struct vring_desc_1_1 *)p; + return; + } + vr->desc = (struct vring_desc *) p; vr->avail = (struct vring_avail *) (p + num * sizeof(struct vring_desc)); diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index 2e12086..91d2db7 100644 --- a/drivers/net/virtio/virtqueue.h +++ b/drivers/net/virtio/virtqueue.h @@ -266,6 +266,16 @@ struct virtio_tx_region { __attribute__((__aligned__(16))); }; +static inline void +vring_desc_init_1_1(struct vring *vr, int n) +{ + int i; + for (i = 0; i < n; i++) { + struct vring_desc_1_1 *desc = &vr->desc_1_1[i]; + desc->index = i; + } +} + /* Chain all the descriptors in the ring with an END */ static inline void vring_desc_init(struct vring_desc *dp, uint16_t n) -- 1.8.3.1