* [dpdk-dev] [DPDK] net/i40e: add return value checks
@ 2017-05-09 14:37 Herakliusz Lipiec
2017-05-11 1:04 ` Zhang, Helin
0 siblings, 1 reply; 3+ messages in thread
From: Herakliusz Lipiec @ 2017-05-09 14:37 UTC (permalink / raw)
To: helin.zhang, jingjing.wu; +Cc: dev
Coverity issue: 1379362
Coverity issue: 1379365
Fixes: 71d35259ff67 ("i40e: tear down flow director")
Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
---
drivers/net/i40e/i40e_fdir.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index 28cc554..b8cfa0f 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -300,8 +300,12 @@ i40e_fdir_teardown(struct i40e_pf *pf)
vsi = pf->fdir.fdir_vsi;
if (!vsi)
return;
- i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
- i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
+ int err = i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
+ if (err)
+ PMD_DRV_LOG(DEBUG, "Failed to do FDIR TX switch off");
+ err = i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
+ if (err)
+ PMD_DRV_LOG(DEBUG, "Failed to do FDIR RX switch off");
i40e_dev_rx_queue_release(pf->fdir.rxq);
pf->fdir.rxq = NULL;
i40e_dev_tx_queue_release(pf->fdir.txq);
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [DPDK] net/i40e: add return value checks
2017-05-09 14:37 [dpdk-dev] [DPDK] net/i40e: add return value checks Herakliusz Lipiec
@ 2017-05-11 1:04 ` Zhang, Helin
2017-05-12 12:05 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Helin @ 2017-05-11 1:04 UTC (permalink / raw)
To: Lipiec, Herakliusz, Wu, Jingjing; +Cc: dev
> -----Original Message-----
> From: Lipiec, Herakliusz
> Sent: Tuesday, May 9, 2017 10:38 PM
> To: Zhang, Helin; Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: [DPDK] net/i40e: add return value checks
>
> Coverity issue: 1379362
> Coverity issue: 1379365
> Fixes: 71d35259ff67 ("i40e: tear down flow director")
>
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_fdir.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index
> 28cc554..b8cfa0f 100644
> --- a/drivers/net/i40e/i40e_fdir.c
> +++ b/drivers/net/i40e/i40e_fdir.c
> @@ -300,8 +300,12 @@ i40e_fdir_teardown(struct i40e_pf *pf)
> vsi = pf->fdir.fdir_vsi;
> if (!vsi)
> return;
> - i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
> - i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
> + int err = i40e_switch_tx_queue(hw, vsi->base_queue, FALSE);
> + if (err)
> + PMD_DRV_LOG(DEBUG, "Failed to do FDIR TX switch off");
> + err = i40e_switch_rx_queue(hw, vsi->base_queue, FALSE);
> + if (err)
> + PMD_DRV_LOG(DEBUG, "Failed to do FDIR RX switch off");
> i40e_dev_rx_queue_release(pf->fdir.rxq);
> pf->fdir.rxq = NULL;
> i40e_dev_tx_queue_release(pf->fdir.txq);
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [DPDK] net/i40e: add return value checks
2017-05-11 1:04 ` Zhang, Helin
@ 2017-05-12 12:05 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-05-12 12:05 UTC (permalink / raw)
To: Zhang, Helin, Lipiec, Herakliusz, Wu, Jingjing; +Cc: dev
On 5/11/2017 2:04 AM, Zhang, Helin wrote:
>
>
>> -----Original Message-----
>> From: Lipiec, Herakliusz
>> Sent: Tuesday, May 9, 2017 10:38 PM
>> To: Zhang, Helin; Wu, Jingjing
>> Cc: dev@dpdk.org
>> Subject: [DPDK] net/i40e: add return value checks
>>
>> Coverity issue: 1379362
>> Coverity issue: 1379365
>> Fixes: 71d35259ff67 ("i40e: tear down flow director")
>>
>> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-12 12:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-09 14:37 [dpdk-dev] [DPDK] net/i40e: add return value checks Herakliusz Lipiec
2017-05-11 1:04 ` Zhang, Helin
2017-05-12 12:05 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).