From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Joongi Kim <joongi@an.kaist.ac.kr>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: Fix compilation on C++
Date: Mon, 17 Aug 2015 17:50:15 +0200 [thread overview]
Message-ID: <1494488.ouvK29kKhu@xps13> (raw)
In-Reply-To: <3151494.cFXF6huzQX@xps13>
2015-08-17 17:29, Thomas Monjalon:
> 2015-07-03 21:51, Joongi Kim:
> > * Forward declaration of enum in C++ requires explicit underlying
> > type definitions.
> >
> > * This fixes the issue at:
> > http://dpdk.org/ml/archives/dev/2015-April/017065.html
> >
> > Signed-off-by: Joongi Kim <joongi@an.kaist.ac.kr>
>
> Does the problem appear only with rte_hash_crc.h inclusion?
>
> The reported errors were:
>
> include/generic/rte_cpuflags.h:50:6:
> error: use of enum ‘rte_cpu_flag_t’ without previous declaration
> enum rte_cpu_flag_t;
>
> include/generic/rte_cpuflags.h:55:6:
> error: use of enum ‘cpu_register_t’ without previous declaration
> enum cpu_register_t;
>
> > lib/librte_eal/common/include/arch/x86/rte_cpuflags.h | 4 ++--
> > lib/librte_eal/common/include/generic/rte_cpuflags.h | 12 ++++++++++--
>
> Do we need to update lib/librte_eal/common/include/arch/ppc_64/rte_cpuflags.h
> and lib/librte_eal/common/include/arch/tile/rte_cpuflags.h as well?
>
> Thanks
Applied with same fixes for ppc and tile, thanks
next prev parent reply other threads:[~2015-08-17 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 12:51 [dpdk-dev] [PATCH 1/2] lib: Fix pointer arithmetic for C++ Joongi Kim
2015-07-03 12:51 ` [dpdk-dev] [PATCH 2/2] eal: Fix compilation on C++ Joongi Kim
2015-08-17 15:29 ` Thomas Monjalon
2015-08-17 15:50 ` Thomas Monjalon [this message]
2015-11-13 9:35 ` [dpdk-dev] [PATCH 1/2] Revert "eal: fix C++ app build" David Marchand
2015-11-13 9:35 ` [dpdk-dev] [PATCH 2/2] eal: move empty declarations to doc David Marchand
2015-11-23 15:19 ` Thomas Monjalon
2015-08-17 15:22 ` [dpdk-dev] [PATCH 1/2] lib: Fix pointer arithmetic for C++ Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494488.ouvK29kKhu@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=joongi@an.kaist.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).