From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 575E78DA9 for ; Mon, 17 Aug 2015 17:51:30 +0200 (CEST) Received: by wicja10 with SMTP id ja10so84735029wic.1 for ; Mon, 17 Aug 2015 08:51:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=tAYTMl6AOehq55Z29Y95Vx0OdghSOccQGh6ymByZiAE=; b=TQE7L73IYiA4/yowO4TTqCubZUCxbnBOo+dGQicnSHlg/HmIE9hVUqH34phhZbHRVy Rqt2tdKUWm3IdBRfPIVil7AkK9LuQhI9FJgEyJmQ1ys1keByoUIiLoQPQuSTqpxolc2N o+QmeVdpkYukKuPnNsw5xYOc0k+OYCMvAeRDlzsasnbGY3GOp/ZT8i0duSzzZpp8EurF 2P6EDXMtUCylTnkvrwrxxyTYaJAXGYpqMEMFLhcDuAzZR5kb8L4ZJzyXsmqlNyj9qfHo bniBHrB9cvW2R0RTJjKeiu0J9zcC/6TvM1nHOCJeaQ1QrChR85xpwUV6npN5qaWx+Jy5 akVw== X-Gm-Message-State: ALoCoQm1oxDB6kqNZKkX2RLRdnVI7tZZ1zXoGjbkF9KXcRx6JsFrbWc5aO3cGporfY49cqz5Slct X-Received: by 10.194.201.71 with SMTP id jy7mr3899657wjc.93.1439826689129; Mon, 17 Aug 2015 08:51:29 -0700 (PDT) Received: from xps13.localnet (183.16.90.92.rev.sfr.net. [92.90.16.183]) by smtp.gmail.com with ESMTPSA id pg5sm10610739wjb.21.2015.08.17.08.51.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Aug 2015 08:51:28 -0700 (PDT) From: Thomas Monjalon To: Joongi Kim Date: Mon, 17 Aug 2015 17:50:15 +0200 Message-ID: <1494488.ouvK29kKhu@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <3151494.cFXF6huzQX@xps13> References: <1435927863-3398-1-git-send-email-joongi@an.kaist.ac.kr> <1435927863-3398-2-git-send-email-joongi@an.kaist.ac.kr> <3151494.cFXF6huzQX@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] eal: Fix compilation on C++ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2015 15:51:30 -0000 2015-08-17 17:29, Thomas Monjalon: > 2015-07-03 21:51, Joongi Kim: > > * Forward declaration of enum in C++ requires explicit underlying > > type definitions. > >=20 > > * This fixes the issue at: > > http://dpdk.org/ml/archives/dev/2015-April/017065.html > >=20 > > Signed-off-by: Joongi Kim >=20 > Does the problem appear only with rte_hash_crc.h inclusion? >=20 > The reported errors were: >=20 > include/generic/rte_cpuflags.h:50:6: > error: use of enum =E2=80=98rte_cpu_flag_t=E2=80=99 without previous = declaration > enum rte_cpu_flag_t; >=20 > include/generic/rte_cpuflags.h:55:6: > error: use of enum =E2=80=98cpu_register_t=E2=80=99 without previous = declaration > enum cpu_register_t; >=20 > > lib/librte_eal/common/include/arch/x86/rte_cpuflags.h | 4 ++-- > > lib/librte_eal/common/include/generic/rte_cpuflags.h | 12 +++++++= +++-- >=20 > Do we need to update lib/librte_eal/common/include/arch/ppc_64/rte_cp= uflags.h > and lib/librte_eal/common/include/arch/tile/rte_cpuflags.h as well? >=20 > Thanks Applied with same fixes for ppc and tile, thanks