From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 94F081066 for <dev@dpdk.org>; Sun, 22 Apr 2018 22:09:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 845AA21452; Sun, 22 Apr 2018 16:09:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 22 Apr 2018 16:09:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=/zNapUMwTmc0qa+ubRr0xWPGkE js54Q516ZyaFqHaFQ=; b=doKFpyPAe4YFpsXaMH+8yreTP9oXA65TTVR/iS6yBV jMUntp8SW5UbvzZQW8cY1ZPOPeBBseaKtGj32yLviL4DnEQcPL8+/ehNI6EqE8jy AQAOmcuxtGs9/ToYPSQ5kp8bu91Dm9sMgZsfExH0La2PNbZvEpqpazp65uJlorYP w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/zNapU MwTmc0qa+ubRr0xWPGkEjs54Q516ZyaFqHaFQ=; b=lqYMCiSGK4VnENQWGNBq9u HsnP7JpktXXcsjsFWtI2GAfw8zNn34qluyGuD21qAJi9f1yd7Pa+iB35O6mbOQqY /o8lls8T7Ht9rZl0M1MsMV6SEPEGur3bAfizuZwIoL+FulMUgYTiSTpa3hgHDD2o RPVwi/7RJuutfACsLfCqY1pYqfX7RPXz8SkG7nDtjmXJLjhImhK3yjo6OkcU6+aA 4BHP2yDIs/6FyzNLz3pXoB7XNWj3MSojaS8UyR+4qyqztOKa6CVNmX1SAjhkvsp/ zzTu1L3e09rSMzIghXBYxcGHgaWczvw/7mov8BaeQwWA35wWoEtFORM9QWU4IbYQ == X-ME-Sender: <xms:3evcWlkt-cw6IR4BxGScQIST1DIbPG93FJgtuf-6S25YxiH-MYOrKg> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CFFE8E4076; Sun, 22 Apr 2018 16:09:00 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ravi Kumar <Ravi1.kumar@amd.com>, pablo.de.lara.guarch@intel.com Cc: dev@dpdk.org, hemant.agrawal@nxp.com Date: Sun, 22 Apr 2018 22:08:59 +0200 Message-ID: <14946114.ASIPbkMQcp@xps> In-Reply-To: <1521462233-13590-17-git-send-email-Ravi1.kumar@amd.com> References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com> <1521462233-13590-1-git-send-email-Ravi1.kumar@amd.com> <1521462233-13590-17-git-send-email-Ravi1.kumar@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sun, 22 Apr 2018 20:09:03 -0000 Hi, I am doing some late comments because I have a quick look when trying to pull next-crypto in master branch. Unfortunately, it doesn't met the basic quality criterias. 19/03/2018 13:23, Ravi Kumar: > Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com> > --- > config/common_base | 1 + > drivers/crypto/ccp/ccp_crypto.c | 282 ++++++++++++++++++++++++++++++++++- > drivers/crypto/ccp/ccp_crypto.h | 5 +- > drivers/crypto/ccp/ccp_pmd_ops.c | 23 +++ > drivers/crypto/ccp/ccp_pmd_private.h | 10 ++ > 5 files changed, 316 insertions(+), 5 deletions(-) [...] > +CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n Why introducing a compile-time option? Can it be a run-time option of the device? We must not add compile-time device option if not well justified. Talking about justification, there is 0 explanation in the commit messages. But there are some in next-crypto tree. Where do they come from?