From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0a-000f0801.pphosted.com [67.231.144.122]) by dpdk.org (Postfix) with ESMTP id AE01920F for ; Tue, 16 May 2017 23:25:40 +0200 (CEST) Received: from pps.filterd (m0000542.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v4GLNbC9004395 for ; Tue, 16 May 2017 14:25:39 -0700 Received: from hq1wp-exmb12.corp.brocade.com ([144.49.131.13]) by mx0a-000f0801.pphosted.com with ESMTP id 2afebhxpss-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 16 May 2017 14:25:39 -0700 Received: from HQ1WP-EXMB11.corp.brocade.com (10.70.20.185) by HQ1WP-EXMB12.corp.brocade.com (10.70.20.186) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 16 May 2017 14:25:37 -0700 Received: from HQ1WP-EXMB11.corp.brocade.com ([fe80::4534:b177:107a:bcd8]) by Hq1wp-exmb11.corp.brocade.com ([fe80::4534:b177:107a:bcd8%20]) with mapi id 15.00.1210.000; Tue, 16 May 2017 14:25:37 -0700 From: Tom Hall To: "dev@dpdk.org" Thread-Topic: Guidelines for stats_get ierrors in a media driver Thread-Index: AQHSzooxm5iETehjX0eyZs3Z1nsrDQ== Date: Tue, 16 May 2017 21:25:37 +0000 Message-ID: <1494969873552.80827@Brocade.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [172.16.180.50] MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-05-16_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705160163 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] Guidelines for stats_get ierrors in a media driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2017 21:25:41 -0000 I'm trying to make sense of the stats_get ierrors value. It doesn't appear = that there is any consistency between any of the net drivers for what this = value truly represents. For example, the ixgbe driver calculates the value = as stats->ierrors =3D hw_stats->crcerrs + hw_stats->mspdc + hw_stats->rlec + hw_stats->ruc + hw_stats->roc + hw_stats->illerrc + hw_stats->errbc + hw_stats->rfc + hw_stats->fccrc + hw_stats->fclast; While the vmxnet3 driver does the following RTE_BUILD_BUG_ON(RTE_ETHDEV_QUEUE_STAT_CNTRS < VMXNET3_MAX_RX_QUEUES); for = (i =3D 0; i < hw->num_rx_queues; i++) { struct UPT1_RxStats *rxStats =3D &h= w->rqd_start[i].stats; stats->q_ipackets[i] =3D rxStats->ucastPktsRxOK + rx= Stats->mcastPktsRxOK + rxStats->bcastPktsRxOK; stats->q_ibytes[i] =3D rxSta= ts->ucastBytesRxOK + rxStats->mcastBytesRxOK + rxStats->bcastBytesRxOK; sta= ts->ipackets +=3D stats->q_ipackets[i]; stats->ibytes +=3D stats->q_ibytes[= i]; stats->q_errors[i] =3D rxStats->pktsRxError; stats->ierrors +=3D rxStat= s->pktsRxError; stats->rx_nombuf +=3D rxStats->pktsRxOutOfBuf; } The bnx2x driver sets the value in this way stats->ierrors =3D HILO_U64(sc->eth_stats.error_bytes_received_hi, sc->eth_stats.error_bytes_received_lo); Can someone address this inconsistancY? What should stats->ierrors represen= t? Tom Hall Brocade Communications