From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2A9A947CE for ; Wed, 24 May 2017 08:35:24 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 May 2017 23:35:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,384,1491289200"; d="scan'208";a="265707169" Received: from zhangqi.sh.intel.com ([10.239.129.189]) by fmsmga004.fm.intel.com with ESMTP; 23 May 2017 23:35:22 -0700 From: Qi Zhang To: adrien.mazarguil@6wind.com Cc: dev@dpdk.org, Qi Zhang Date: Tue, 23 May 2017 19:28:54 -0400 Message-Id: <1495582134-13665-1-git-send-email-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] ethdev: add roughly match pattern X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2017 06:35:25 -0000 Add new meta pattern item RTE_FLOW_TYPE_ITEM_ROUGHLY. This is for device that support no-perfect match option. Usually a no-perfect match is fast but the cost is accuracy. i.e. Signature Match only match pattern's hash value, but it is possible two different patterns have the same hash value. Matching accuracy level can be configure by subfield threshold. Driver can divide the range of threshold and map to different accuracy levels that device support. Signed-off-by: Qi Zhang --- app/test-pmd/cmdline_flow.c | 24 ++++++++++++++ app/test-pmd/config.c | 1 + doc/guides/prog_guide/rte_flow.rst | 50 +++++++++++++++++++++++++++++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 ++ lib/librte_ether/rte_flow.h | 30 +++++++++++++++++ 5 files changed, 107 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 0fd69f9..18ffcff 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -107,6 +107,8 @@ enum index { ITEM_END, ITEM_VOID, ITEM_INVERT, + ITEM_ROUGHLY, + ITEM_ROUGHLY_THRESHOLD, ITEM_ANY, ITEM_ANY_NUM, ITEM_PF, @@ -426,6 +428,7 @@ static const enum index next_item[] = { ITEM_END, ITEM_VOID, ITEM_INVERT, + ITEM_ROUGHLY, ITEM_ANY, ITEM_PF, ITEM_VF, @@ -447,6 +450,12 @@ static const enum index next_item[] = { ZERO, }; +static const enum index item_roughly[] = { + ITEM_ROUGHLY_THRESHOLD, + ITEM_NEXT, + ZERO, +}; + static const enum index item_any[] = { ITEM_ANY_NUM, ITEM_NEXT, @@ -954,6 +963,21 @@ static const struct token token_list[] = { .next = NEXT(NEXT_ENTRY(ITEM_NEXT)), .call = parse_vc, }, + [ITEM_ROUGHLY] = { + .name = "roughly", + .help = "match the pattern roughly", + .priv = PRIV_ITEM(ROUGHLY, + sizeof(struct rte_flow_item_roughly)), + .next = NEXT(item_roughly), + .call = parse_vc, + }, + [ITEM_ROUGHLY_THRESHOLD] = { + .name = "threshold", + .help = "match accuracy threshold", + .next = NEXT(item_roughly, NEXT_ENTRY(UNSIGNED), item_param), + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_roughly, + threshold)), + }, [ITEM_ANY] = { .name = "any", .help = "match any protocol for the current layer", diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 4d873cd..5b0cd4d 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -954,6 +954,7 @@ static const struct { MK_FLOW_ITEM(END, 0), MK_FLOW_ITEM(VOID, 0), MK_FLOW_ITEM(INVERT, 0), + MK_FLOW_ITEM(ROUGHLY, sizeof(struct rte_flow_item_roughly)), MK_FLOW_ITEM(ANY, sizeof(struct rte_flow_item_any)), MK_FLOW_ITEM(PF, 0), MK_FLOW_ITEM(VF, sizeof(struct rte_flow_item_vf)), diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index b587ba9..4cc1876 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -491,6 +491,7 @@ Usage example, matching non-TCPv4 packets only: +-------+----------+ | Index | Item | + +=======+==========+ | 0 | INVERT | +-------+----------+ @@ -503,6 +504,55 @@ Usage example, matching non-TCPv4 packets only: | 4 | END | +-------+----------+ +Item: ``ROUGHLY`` +^^^^^^^^^^^^^^^^^ + +Roughly matching, not perfect match. + +This is for device that support no-perfect match option. +Usually a no-perfect match is fast but the cost is accuracy. +i.e. Signature Match only match pattern's hash value, but it is +possible two different patterns have the same hash value. + +Matching accuracy level can be configure by threshold. +Driver can divide the range of threshold and map to different +accuracy levels that device support. + +.. _table_rte_flow_item_roughly: + +.. table:: ROUGHLY + + +----------+---------------+--------------------------------------------------+ + | Field | Subfield | Value | + +==========+===========+======================================================+ + | ``spec`` | ``threshold`` | 0 as perfect match, 0xffffffff as roughest match | + +----------+---------------+--------------------------------------------------+ + | ``last`` | ``threshold`` | ignored | + +----------+-----------+------------------------------------------------------+ + | ``mask`` | ``threshold`` | ignored | + +----------+-----------+------------------------------------------------------+ + + +Usage example, roughly match a TCPv4 packets: + +.. _table_rte_flow_item_roughly_example: + +.. table:: Roughly matching + + +-------+----------+ + | Index | Item | + +=======+==========+ + | 0 | ROUGHLY | + +-------+----------+ + | 1 | Ethernet | + +-------+----------+ + | 2 | IPv4 | + +-------+----------+ + | 3 | TCP | + +-------+----------+ + | 4 | END | + +-------+----------+ + Item: ``PF`` ^^^^^^^^^^^^ diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 0e50c10..08a88f8 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -2513,6 +2513,8 @@ This section lists supported pattern items and their attributes, if any. - ``invert``: perform actions when pattern does not match. +- ``roughly``: pattern is matched roughly. + - ``any``: match any protocol for the current layer. - ``num {unsigned}``: number of layers covered. diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h index c47edbc..4921858 100644 --- a/lib/librte_ether/rte_flow.h +++ b/lib/librte_ether/rte_flow.h @@ -148,6 +148,18 @@ enum rte_flow_item_type { RTE_FLOW_ITEM_TYPE_INVERT, /** + * [META] + * + * Roughly matching, not perfect matching + * + * This is for device that support no-perfect matching option. + * Usually a no-perfect matching is fast but the cost is accuracy. + * + * See struct rte_flow_item_roughly + */ + RTE_FLOW_ITEM_TYPE_ROUGHLY, + + /** * Matches any protocol in place of the current layer, a single ANY * may also stand for several protocol layers. * @@ -300,6 +312,24 @@ enum rte_flow_item_type { }; /** + * RTE_FLOW_ITEM_TYPE_ROUGHLY + * + * Roughly matching, not perfect match. + * + * This is for device that support no-perfect match option. + * Usually a no-perfect match is fast but the cost is accuracy. + * i.e. Signature Match only match pattern's hash value, but it is + * possible two different patterns have the same hash value. + * + * Matching accuracy level can be configure by threshold. + * Driver can divide the range of threshold and map to different + * accuracy levels that device support. + */ +struct rte_flow_item_roughly { + uint32_t threshold; /**< accuracy threshold*/ +}; + +/** * RTE_FLOW_ITEM_TYPE_ANY * * Matches any protocol in place of the current layer, a single ANY may also -- 2.7.4