[dpdk-dev] [PATCH] cxgbe: fix compilation using icc

[dpdk-dev] [PATCH] cxgbe: fix compilation using icc

[Bruce Richardson]

When compiling the cxgbe driver with icc, multiple errors about using
enums as integers appear across a number of files, including in the base
code and in the DPDK-specific driver code.

.../drivers/net/cxgbe/cxgbe_main.c(386): error #188: enumerated type mixed
with another type
                        t4_get_port_type_description(pi->port_type));
                                                     ^
For the errors in the base driver code we use the CFLAGS_BASE_DRIVER 
approach used by other drivers to disable warnings.

For errors in the DPDK-specific code, typecasts are used to fix the
errors in the code itself.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/cxgbe/Makefile     | 17 +++++++++++++----
 drivers/net/cxgbe/cxgbe_main.c |  5 +++--
 drivers/net/cxgbe/sge.c        |  3 ++-
 3 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/drivers/net/cxgbe/Makefile b/drivers/net/cxgbe/Makefile
index ae12d75..0711976 100644
--- a/drivers/net/cxgbe/Makefile
+++ b/drivers/net/cxgbe/Makefile
@@ -49,7 +49,7 @@ ifeq ($(CC), icc)
 #
 # CFLAGS for icc
 #
-CFLAGS_BASE_DRIVER = -wd174 -wd593 -wd869 -wd981 -wd2259
+CFLAGS_BASE_DRIVER = -wd188
 else
 #
 # CFLAGS for gcc/clang
@@ -57,18 +57,27 @@ else
 ifeq ($(shell test $(CC) = gcc && test $(GCC_VERSION) -ge 44 && echo 1), 1)
 CFLAGS     += -Wno-deprecated
 endif
-CFLAGS_BASE_DRIVER = -Wno-unused-parameter -Wno-unused-value
-CFLAGS_BASE_DRIVER += -Wno-strict-aliasing -Wno-format-extra-args
+CFLAGS_BASE_DRIVER =
 
 endif
 
 #
+# Add extra flags for base driver files (also known as shared code)
+# to disable warnings in them
+#
+BASE_DRIVER_OBJS=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c)))
+$(foreach obj, $(BASE_DRIVER_OBJS), $(eval CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER)))
+
+VPATH += $(SRCDIR)/base
+
+
+#
 # all source are stored in SRCS-y
 #
 SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += cxgbe_ethdev.c
 SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += cxgbe_main.c
 SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += sge.c
-SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += base/t4_hw.c
+SRCS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += t4_hw.c
 
 # this lib depends upon:
 DEPDIRS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += lib/librte_eal lib/librte_ether
diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c
index dad0a98..b879820 100644
--- a/drivers/net/cxgbe/cxgbe_main.c
+++ b/drivers/net/cxgbe/cxgbe_main.c
@@ -383,7 +383,8 @@ static void print_port_info(struct adapter *adap)
 		if (bufp != buf)
 			--bufp;
 		sprintf(bufp, "BASE-%s",
-			t4_get_port_type_description(pi->port_type));
+			t4_get_port_type_description(
+					(enum fw_port_type)pi->port_type));
 
 		dev_info(adap,
 			 " " PCI_PRI_FMT " Chelsio rev %d %s %s\n",
@@ -629,7 +630,7 @@ static int adap_init0(struct adapter *adap)
 			dev_err(adap, "Failed to restart. Exit.\n");
 			goto bye;
 		}
-		state &= ~DEV_STATE_INIT;
+		state = (enum dev_state)((unsigned)state & ~DEV_STATE_INIT);
 	}
 
 	t4_get_fw_version(adap, &adap->params.fw_vers);
diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
index 4da6320..359296e 100644
--- a/drivers/net/cxgbe/sge.c
+++ b/drivers/net/cxgbe/sge.c
@@ -1670,7 +1670,8 @@ int t4_sge_alloc_rxq(struct adapter *adap, struct sge_rspq *iq, bool fwevtq,
 	if (fl) {
 		struct sge_eth_rxq *rxq = container_of(fl, struct sge_eth_rxq,
 						       fl);
-		enum chip_type chip = CHELSIO_CHIP_VERSION(adap->params.chip);
+		enum chip_type chip = (enum chip_type)CHELSIO_CHIP_VERSION(
+				adap->params.chip);
 
 		/*
 		 * Allocate the ring for the hardware free list (with space
-- 
2.4.3

Re: [dpdk-dev] [PATCH] cxgbe: fix compilation using icc

[Thomas Monjalon]

2015-07-01 16:11, Bruce Richardson:
> When compiling the cxgbe driver with icc, multiple errors about using
> enums as integers appear across a number of files, including in the base
> code and in the DPDK-specific driver code.
> 
> .../drivers/net/cxgbe/cxgbe_main.c(386): error #188: enumerated type mixed
> with another type
>                         t4_get_port_type_description(pi->port_type));
>                                                      ^
> For the errors in the base driver code we use the CFLAGS_BASE_DRIVER 
> approach used by other drivers to disable warnings.
> 
> For errors in the DPDK-specific code, typecasts are used to fix the
> errors in the code itself.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks