From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 0F15B2B83 for ; Sun, 18 Nov 2018 23:25:25 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A417521D45; Sun, 18 Nov 2018 17:25:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 18 Nov 2018 17:25:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=/wcl83GqXyCyjDlu0mZP3j1V+MQz18ItzmUM3bG/cSk=; b=ahCcrkOIq3Bb 7wR6UhLbgH8YvYFIME9jzpw9YrcBijkf1O9cB6L3mzA6qG4D//Js6GjE+i0VQt59 en3fFzQosN3+sNvMEWu3HdjMEiTgOjIUBRUrxBLpxhJsM87RuI0mojLZ3nNBywpX wo7BO//jirdPtH6NFxEDl/adUU6gUUM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/wcl83GqXyCyjDlu0mZP3j1V+MQz18ItzmUM3bG/c Sk=; b=X8egyUAzKKuOTp5K1fqW/iIq8WD5h67I+azhM+prcD1fhvPa/V191aPlE U1iQWo/+jw5JZEKFqffsOfQ19Imilfk6Sdk8kLF6zy2ZJeuF7WAuBt3Em1Mb4oPU cUYz06WZ/720PcdOjOck9MZh8h8NwIYA3/IgNiWg3r6QXSY4UJ/SqnP+gznzYTfC T2S305pbtCPvPtVFKIvGUAa7smtbTUHX4zvifkfgsnvYlZjiKnNIPklxrzlcGg7y bEXI6RGWfiEEZAoXcAzNBb9qTWeFn/k5RFv3UKi8TzJvMbSe3rekej2CwTEezws+ vF6SLwU8ZcrW29gIg+RpbIwNfWgIQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DF16F102DE; Sun, 18 Nov 2018 17:25:22 -0500 (EST) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, doucette@bu.edu Date: Sun, 18 Nov 2018 23:25:21 +0100 Message-ID: <14977941.BcdJQmDsnJ@xps> In-Reply-To: <20181102115045.GA31972@hmswarspite.think-freely.org> References: <20181101135410.15945-1-nhorman@tuxdriver.com> <3649242.bmXl2ZTEod@xps> <20181102115045.GA31972@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] check-symbol-change: fix regex to match on end of map file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2018 22:25:25 -0000 02/11/2018 12:50, Neil Horman: > On Thu, Nov 01, 2018 at 11:53:00PM +0100, Thomas Monjalon wrote: > > 01/11/2018 14:54, Neil Horman: > > > the regex to determine the end of the map file chunk in a patch seems to > > > be wrong, It was using perl regex syntax, which awk doesn't appear to > > > support (I'm still not sure how it was working previously). Regardless, > > > it wasn't triggering and as a result symbols were getting added to the > > > mapdb that shouldn't be there. > > > > > > Fix it by converting the regex to use traditional posix syntax, matching > > > only on the negation of the character class [^map] > > > > > > Tested and shown to be working on the ip_frag patch set provided by > > > doucette@bu.edu > > > > > > Signed-off-by: Neil Horman > > > CC: thomas@monjalon.net > > > CC: doucette@bu.edu > > > Reported-by: doucette@bu.edu > > > > You could use these lines: > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > > > Reported-by: Cody Doucette > > > I'm fine with the second line, and the first is fine I guess, but I'm not sure > there is an exact correlation > > > > --- a/devtools/check-symbol-change.sh > > > +++ b/devtools/check-symbol-change.sh > > > - /[-+] a\/.*\.^(map)/ {in_map=0} > > > + /[-+] a\/.*\.[^map]/ {in_map=0} > > > > Not sure this is what you intend: > > [^map] means any character except "m", "a" and "p". > > > Its not 100%, but its pretty close. The regex for exact matching on not a > specific string is pretty large and complex. Since we have no files that that > end in .m .a or .p, this should give us what we want for the forseeable future. > > > I don't know whether awk supports this syntax: (?!foo) > > > It unfortunately doesn't, thats perl syntax, and while grep I think supports it, > awk is more strictly posix compliant. I understand now. Applied, thanks