From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 6060BADCC for ; Wed, 8 Jun 2016 15:38:09 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id k184so16796087wme.1 for ; Wed, 08 Jun 2016 06:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=ns/6L6U9BdbA3NgF6fvzhtzsF6oqDpcdAx4OCzdmv+c=; b=U48F4V8vuemVAzlqMP4cZAkIeWv9Qz521JjQMGpvmO6XxcEfF6t3A8aK8Fx5XHtFLu Z8yeww9sfXXOdkX9O09KpXbTBW29iBcDveV+nC7cWCCkvrtm8J0eo9HhDy/5v/V9Ijrn 13sQmwhHiDj8WXwSQALaY/YK9yK8I0gEv1jhIFPSmHwAQ1BODB7BP6VBPtSfAsz0vC2Y 6I1DU+nhIOgNcCyigcLA3Gmy4iVxE/kIGhQeqY+kBwsc/QFACnzpKDhlgpJLZju+Lsn6 SwKtYeOLo3sqq+k9dYnUZxITRO2es5zSkowI3sbrKV5u8cGxu25dz5rcGMuZFo7uLTDa Yqnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ns/6L6U9BdbA3NgF6fvzhtzsF6oqDpcdAx4OCzdmv+c=; b=fLqQB//z5XDVu2wiqS/OtxgKYXmyVHpEzcZdaoo7XZ9rdRqvhd3Btmi0czeMi1rlUu VSEZqx3OA6bUO/+IxLqhEwqjA5kNXgO9q363nRZaZyrsmp9vg9NiH2RZb1G+kbK7c6RM ++LxMHVQ2GN+uImsmJtmYDy1YROq7qNk5U5oB5WOS2Ay4fz0E4fsQQzlqvalq5UIhwh1 ip0aRFyWGnmQY27V6XSxSWavobGudRNEjAjkxBMdm4W+97X5wB7PUV3IU13iD9exfNYq JMODC6Cq/ZfAA1VkUgN2gT9RY7O3VyrDxAezXroNtTYveTWS995TsgZ85gklhGKVOvAq ns1g== X-Gm-Message-State: ALyK8tI6arI3tutuW8O+lMSov2qx7jHy5AGWyAHgXW4vlLLBPWv5UTEOOTqNwRw2lyjDkfa9 X-Received: by 10.28.15.197 with SMTP id 188mr8356739wmp.75.1465393088910; Wed, 08 Jun 2016 06:38:08 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id z6sm1541975wjv.41.2016.06.08.06.38.07 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 08 Jun 2016 06:38:07 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Cc: "Wiles, Keith" , "Richardson, Bruce" , Christian Ehrhardt , Panu Matilainen , dev@dpdk.org, "Yigit, Ferruh" Date: Wed, 08 Jun 2016 15:38:07 +0200 Message-ID: <1498329.iFkZWAfHut@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <575810E6.2080701@6wind.com> References: <62da0f5f31b2ab9db2dcc16acd2f8425a575a26f.1465293714.git.pmatilai@redhat.com> <575810E6.2080701@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: generate internal library dependencies from DEPDIRS-y automatically X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 13:38:09 -0000 2016-06-08 14:34, Olivier Matz: > On 06/07/2016 04:40 PM, Wiles, Keith wrote: > > On 6/7/16, 9:19 AM, "dev on behalf of Thomas Monjalon" wrote: > > > >> 2016-06-07 15:07, Bruce Richardson: > >>> On Tue, Jun 07, 2016 at 03:00:45PM +0200, Thomas Monjalon wrote: > >>>> 2016-06-07 14:36, Christian Ehrhardt: > >>>>> But I still struggle to see how to fix the circular dependency between > >>>>> librte_eal and librte_mempool. > >>>> > >>>> Why is there a circular dependency? > >>>> Only because of logs using mempool? > >>>> > >>>>> Maybe now is a time to look at this part of the original threads again to > >>>>> eventually get apps less overlinked? > >>>>> => http://www.dpdk.org/ml/archives/dev/2016-May/039441.html > >>>>> My naive suggestions in generalized form can be found there (no answer yet): > >>>>> => > >>>>> http://stackoverflow.com/questions/37351699/how-to-create-both-so-files-for-two-circular-depending-libraries > >>>> > >>>> I would prefer removing the circular dependency. > >>>> Maybe we can rewrite the code to not use mempool or move it outside of EAL. > > Indeed, mempools are used in eal for history. Is this feature still > useful now that logs are sent to syslog? Maybe we could deprecate this > API, and remove mempool calls in a future release? +1 to deprecate log history > >>> Or else we can take the attitude that the mempools and the rings are just a core > >>> part of DPDK and move them and the EAL into a dpdk_core library at link time. > >>> Having the code separate in the git tree is good, but I'm not sure having > >>> the resulting object files being in separate .a/.so files is particularly useful. > >>> I can't see someone wanting to use one without the other. > >> > >> EAL could be used as an abstraction layer on top of systems and platforms. > >> And I think keeping things separated and layered help to maintain a design > >> easy to understand. > > I like the idea to have one lib per directory (for consistency). It > may also simplify the Makefiles. > I'm in favor of keeping mempool and ring separated from eal if we > can remove the circular dep. +1 to keep bijectivity in src/lib.