From: Chas Williams <3chas3@gmail.com>
To: Declan Doherty <declan.doherty@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bond: change link status check to no-wait
Date: Mon, 26 Jun 2017 16:53:45 -0400 [thread overview]
Message-ID: <1498510425.1841.0.camel@gmail.com> (raw)
In-Reply-To: <20170626151347.16680-1-declan.doherty@intel.com>
On Mon, 2017-06-26 at 16:13 +0100, Declan Doherty wrote:
> In the 802.3ad periodic callback function the link status of all slaves
> is checked using rte_eth_link_get function. Depending on the slave
> device this function can block for up to 9 seconds and therefore
> could cause issues with the LACP Daemon state machine and control
> patches handling. This patch changes to the no-wait version of
> the link get function.
>
> Fixes: 46fb4368 ("bond:add mode 4")
>
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
> drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index d2b7592..3a97336 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -758,7 +758,7 @@ bond_mode_8023ad_periodic_cb(void *arg)
> uint16_t key;
>
> slave_id = internals->active_slaves[i];
> - rte_eth_link_get(slave_id, &link_info);
> + rte_eth_link_get_nowait(slave_id, &link_info);
> rte_eth_macaddr_get(slave_id, &slave_addr);
>
> if (link_info.link_status != 0) {
It seems like this should be done in bandwidth_left() as well.
next prev parent reply other threads:[~2017-06-26 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 15:13 Declan Doherty
2017-06-26 20:53 ` Chas Williams [this message]
2017-06-28 9:13 ` Declan Doherty
2017-06-28 10:15 ` [dpdk-dev] [PATCH v2] " Declan Doherty
2017-06-29 11:34 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498510425.1841.0.camel@gmail.com \
--to=3chas3@gmail.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).