From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com [209.85.220.193]) by dpdk.org (Postfix) with ESMTP id 13991374 for ; Mon, 26 Jun 2017 22:53:48 +0200 (CEST) Received: by mail-qk0-f193.google.com with SMTP id p21so1665556qke.0 for ; Mon, 26 Jun 2017 13:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:date:in-reply-to:references:mime-version :content-transfer-encoding; bh=J0hklAmC4v9RsT8S/5OHOETPJBW8BpwqCM6UJisyfm0=; b=TnAMM0rMYl56wglSXtsAaqT5q8pZ1adRAYVH/rL58BuPMoV55HQclvU1RFMFs1B34x rfHYLzGCOkpiBJN692GNbRADAOr8cCVznXu1+nOWMWxU2N8mjblT6gX4YYMCdyi3sQAl pfdDLJ33mJAI/2slsmpyyjyTO+00sP/3+AigNQG35zYfUNO/CF8krLrRBNUTBsVF3jUY y90L/SWGiEOv0YyIcirnmYylEds95ybdkDfbqow//wF2jqlolmIX5wQHXY4XaCpY8g51 ubUdlxy6pjfoKJvepygEZxo0RUuldVtTuqqtsOmyAnX1URdCJOnaxuE6mczITDcEcNeb sVlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=J0hklAmC4v9RsT8S/5OHOETPJBW8BpwqCM6UJisyfm0=; b=aabQSpNXgX3K1FuTBW0O4n9tmhCQOoWjgZzlw4Uiqyu67o7pOee+HMf6zfBZpSIbzS 3tPJc4p3CFNl/tfKVEAKCG7FaIeMQelC1p6p0jUE2UB9dXQ0Dz+W7C+ipp3HVSBNizya /auTjPV1rIskIp/tq8HlZ4XJSg7hnQatxj4bBSDvuun051OG0BawDoqj8KVOaBqrYksD qBPbuVmK1XqTJ7xYdlfCH/gc+FdWeQSxfrQ6tqsCU1juwjjeVASHNZKc+6Ni+wghlDOz y1qMyudohvpf5E3+J6aE1Pza2e6hEWnnYfpFDkuJwFCErkQr88+yRCaOOgl9auHOQUfv 875g== X-Gm-Message-State: AKS2vOz0U09zGLWp4073bMMoZaSeoQJ27sOjwlOzcf7A89tIsV2iBNis bIN/gKqOH1L8ug== X-Received: by 10.55.203.208 with SMTP id u77mr2508116qkl.95.1498510427412; Mon, 26 Jun 2017 13:53:47 -0700 (PDT) Received: from monolith.home (pool-96-255-82-208.washdc.fios.verizon.net. [96.255.82.208]) by smtp.googlemail.com with ESMTPSA id z5sm878196qkz.53.2017.06.26.13.53.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jun 2017 13:53:46 -0700 (PDT) Message-ID: <1498510425.1841.0.camel@gmail.com> From: Chas Williams <3chas3@gmail.com> To: Declan Doherty , dev@dpdk.org Date: Mon, 26 Jun 2017 16:53:45 -0400 In-Reply-To: <20170626151347.16680-1-declan.doherty@intel.com> References: <20170626151347.16680-1-declan.doherty@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bond: change link status check to no-wait X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 20:53:48 -0000 On Mon, 2017-06-26 at 16:13 +0100, Declan Doherty wrote: > In the 802.3ad periodic callback function the link status of all slaves > is checked using rte_eth_link_get function. Depending on the slave > device this function can block for up to 9 seconds and therefore > could cause issues with the LACP Daemon state machine and control > patches handling. This patch changes to the no-wait version of > the link get function. > > Fixes: 46fb4368 ("bond:add mode 4") > > Signed-off-by: Declan Doherty > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c > index d2b7592..3a97336 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -758,7 +758,7 @@ bond_mode_8023ad_periodic_cb(void *arg) > uint16_t key; > > slave_id = internals->active_slaves[i]; > - rte_eth_link_get(slave_id, &link_info); > + rte_eth_link_get_nowait(slave_id, &link_info); > rte_eth_macaddr_get(slave_id, &slave_addr); > > if (link_info.link_status != 0) { It seems like this should be done in bandwidth_left() as well.