From: Rasesh Mody <rasesh.mody@cavium.com>
To: <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: Rasesh Mody <rasesh.mody@cavium.com>, <Dept-EngDPDKDev@cavium.com>
Subject: [dpdk-dev] [PATCH v2 4/8] net/qede: comments traces and format changes
Date: Sat, 1 Jul 2017 12:29:58 -0700 [thread overview]
Message-ID: <1498937402-25547-5-git-send-email-rasesh.mody@cavium.com> (raw)
In-Reply-To: <1498729889-21524-1-git-send-email-rasesh.mody@cavium.com>
Changes include
- comment modifications
- adds tracing during initialization
- adds/removes new lines
Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
drivers/net/qede/base/bcm_osal.c | 14 ++++++++------
drivers/net/qede/qede_ethdev.c | 11 +++++++++++
drivers/net/qede/qede_rxtx.c | 6 +++---
3 files changed, 22 insertions(+), 9 deletions(-)
diff --git a/drivers/net/qede/base/bcm_osal.c b/drivers/net/qede/base/bcm_osal.c
index 4dee4da..968fb76 100644
--- a/drivers/net/qede/base/bcm_osal.c
+++ b/drivers/net/qede/base/bcm_osal.c
@@ -146,9 +146,10 @@ void *osal_dma_alloc_coherent(struct ecore_dev *p_dev,
}
*phys = mz->phys_addr;
ecore_mz_mapping[ecore_mz_count++] = mz;
- DP_VERBOSE(p_dev, ECORE_MSG_PROBE,
- "size=%zu phys=0x%" PRIx64 " virt=%p on socket=%u\n",
- mz->len, mz->phys_addr, mz->addr, socket_id);
+ DP_VERBOSE(p_dev, ECORE_MSG_SP,
+ "Allocated dma memory size=%zu phys=0x%lx"
+ " virt=%p core=%d\n",
+ mz->len, (unsigned long)mz->phys_addr, mz->addr, core_id);
return mz->addr;
}
@@ -183,9 +184,10 @@ void *osal_dma_alloc_coherent_aligned(struct ecore_dev *p_dev,
}
*phys = mz->phys_addr;
ecore_mz_mapping[ecore_mz_count++] = mz;
- DP_VERBOSE(p_dev, ECORE_MSG_PROBE,
- "aligned memory size=%zu phys=0x%" PRIx64 " virt=%p core=%d\n",
- mz->len, mz->phys_addr, mz->addr, core_id);
+ DP_VERBOSE(p_dev, ECORE_MSG_SP,
+ "Allocated aligned dma memory size=%zu phys=0x%lx"
+ " virt=%p core=%d\n",
+ mz->len, (unsigned long)mz->phys_addr, mz->addr, core_id);
return mz->addr;
}
diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index fcc9bbb..8e18a17 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1121,8 +1121,10 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev)
/* Sanity checks and throw warnings */
if (rxmode->enable_scatter)
eth_dev->data->scattered_rx = 1;
+
if (!rxmode->hw_strip_crc)
DP_INFO(edev, "L2 CRC stripping is always enabled in hw\n");
+
if (!rxmode->hw_ip_checksum)
DP_INFO(edev, "IP/UDP/TCP checksum offload is always enabled "
"in hw\n");
@@ -2163,6 +2165,8 @@ static int qede_vxlan_tunn_config(struct rte_eth_dev *eth_dev,
uint16_t filter_type;
int rc, i;
+ PMD_INIT_FUNC_TRACE(edev);
+
filter_type = conf->filter_type | qdev->vxlan_filter_type;
/* First determine if the given filter classification is supported */
qede_get_ecore_tunn_params(filter_type, &type, &clss, str);
@@ -2605,6 +2609,13 @@ static int qede_eth_dev_init(struct rte_eth_dev *eth_dev)
static int qede_dev_common_uninit(struct rte_eth_dev *eth_dev)
{
+#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT
+ struct qede_dev *qdev = eth_dev->data->dev_private;
+ struct ecore_dev *edev = &qdev->edev;
+
+ PMD_INIT_FUNC_TRACE(edev);
+#endif
+
/* only uninitialize in the primary process */
if (rte_eal_process_type() != RTE_PROC_PRIMARY)
return 0;
diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
index 5c9a4dd..e48fd66 100644
--- a/drivers/net/qede/qede_rxtx.c
+++ b/drivers/net/qede/qede_rxtx.c
@@ -82,6 +82,7 @@ static inline int qede_alloc_rx_buffer(struct qede_rx_queue *rxq)
rxq->nb_rx_desc = nb_desc;
rxq->queue_id = queue_idx;
rxq->port_id = dev->data->port_id;
+
max_rx_pkt_len = (uint16_t)rxmode->max_rx_pkt_len;
qdev->mtu = max_rx_pkt_len;
@@ -94,6 +95,7 @@ static inline int qede_alloc_rx_buffer(struct qede_rx_queue *rxq)
dev->data->scattered_rx = 1;
}
}
+
if (dev->data->scattered_rx)
rxq->rx_buf_size = bufsz + QEDE_ETH_OVERHEAD;
else
@@ -704,7 +706,6 @@ void qede_dealloc_fp_resc(struct rte_eth_dev *eth_dev)
qede_free_tx_pkt(txq);
}
-
static int qede_drain_txq(struct qede_dev *qdev,
struct qede_tx_queue *txq, bool allow_drain)
{
@@ -740,7 +741,6 @@ static int qede_drain_txq(struct qede_dev *qdev,
return 0;
}
-
/* Stops a given TX queue in the HW */
static int qede_tx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id)
{
@@ -1083,7 +1083,7 @@ static inline uint32_t qede_rx_cqe_to_tunn_pkt_type(uint16_t flags)
pkt_len;
if (unlikely(!cur_size)) {
PMD_RX_LOG(ERR, rxq, "Length is 0 while %u BDs"
- " left for mapping jumbo", num_segs);
+ " left for mapping jumbo\n", num_segs);
qede_recycle_rx_bd_ring(rxq, qdev, num_segs);
return -EINVAL;
}
--
1.7.10.3
next prev parent reply other threads:[~2017-07-01 19:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 9:51 [dpdk-dev] [PATCH 0/9] net/qede: update PMD to 2.5.1.1 Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 1/9] net/qede: fix DMA memory leak Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 2/9] net/qede: add notifying HW errors Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 3/9] net/qede: limit ring size to 32k Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 4/9] net/qede: comments traces and format changes Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 5/9] net/qede: change debug verbosity of PMD messages Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 6/9] net/qede: set mdump flag Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 7/9] net/qede: add missing check for VNI Rasesh Mody
2017-06-29 9:51 ` [dpdk-dev] [PATCH 8/9] net/qede: use newer packet mbuf allocate API Rasesh Mody
2017-06-29 12:55 ` Ferruh Yigit
2017-07-01 19:34 ` Mody, Rasesh
2017-06-29 9:51 ` [dpdk-dev] [PATCH 9/9] net/qede: update PMD version to 2.5.1.1 Rasesh Mody
2017-06-29 12:16 ` [dpdk-dev] [PATCH 0/9] net/qede: update PMD " Ferruh Yigit
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 0/8] " Rasesh Mody
2017-07-05 10:01 ` Ferruh Yigit
2017-07-08 18:35 ` Mody, Rasesh
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 1/8] net/qede: fix DMA memory leak Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 2/8] net/qede: add notifying HW errors Rasesh Mody
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 3/8] net/qede: limit ring size to 32k Rasesh Mody
2017-07-01 19:29 ` Rasesh Mody [this message]
2017-07-01 19:29 ` [dpdk-dev] [PATCH v2 5/8] net/qede: change debug verbosity of PMD messages Rasesh Mody
2017-07-01 19:30 ` [dpdk-dev] [PATCH v2 6/8] net/qede: set mdump flag Rasesh Mody
2017-07-01 19:30 ` [dpdk-dev] [PATCH v2 7/8] net/qede: add missing check for VNI Rasesh Mody
2017-07-03 10:08 ` Ferruh Yigit
2017-07-01 19:30 ` [dpdk-dev] [PATCH v2 8/8] net/qede: update PMD version to 2.5.1.1 Rasesh Mody
2017-07-03 10:06 ` Ferruh Yigit
2017-07-05 9:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498937402-25547-5-git-send-email-rasesh.mody@cavium.com \
--to=rasesh.mody@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).