From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 3800230D for ; Wed, 2 Jul 2014 00:01:30 +0200 (CEST) Received: by mail-wi0-f170.google.com with SMTP id cc10so8134987wib.1 for ; Tue, 01 Jul 2014 15:01:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+CNSlxAauCtpiM04hbyPPJs2s/GiOA5QZSsrmZLC3k4=; b=KFV1ePa2eu7qEu/ueePBXuEccKiIzZ4bFyuMaiV1nqyzPeDpZMtq8BVuoQONJDScwG ys8HFjM98oYrM/DCSILUC3NTI+mmZ9Ocv8YYIG0UxahjyhMEVGayTir7ElgMr6XrsCao P5eNEsRiiAhjSgpFFh01WQJypbOsfHjzmfWjjn3YdWY5mFEtdGNBA4Sq47chFsh0dEoa hohrrIghm98ykLu2eKptVExxu4ICpUVoZAOSF0ctiXMuES3k810TGWTtZiRakV1I+YEI nygPpcHtRfykEnM0/1Ijh82FMFom/QT4/QUQ0Pv1h4ICeIEahQtVsq4oTJ6h0RAF0QEf v3gA== X-Gm-Message-State: ALoCoQkh2j8QqFMDKJGH+5bf4EQUrjYJNX4iTXPrYV3yjQTMapq69nJsOgdDYc/y0rLJbUC7huia X-Received: by 10.180.198.116 with SMTP id jb20mr101877wic.59.1404252110294; Tue, 01 Jul 2014 15:01:50 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by mx.google.com with ESMTPSA id o3sm47684814wiz.24.2014.07.01.15.01.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Jul 2014 15:01:49 -0700 (PDT) From: Thomas Monjalon To: "Doherty, Declan" Date: Wed, 02 Jul 2014 00:01:42 +0200 Message-ID: <1499740.ex9F3ntLKi@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <345C63BAECC1AD42A2EC8C63AFFC3ADC2730631F@IRSMSX101.ger.corp.intel.com> References: <1403864324-12022-1-git-send-email-declan.doherty@intel.com> <13010138.0NjEKNQfRt@xps13> <345C63BAECC1AD42A2EC8C63AFFC3ADC2730631F@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v11 0/5] link bonding library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2014 22:01:30 -0000 2014-06-30 09:28, Doherty, Declan: > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > Hi Declan, > > > > 2014-06-29 18:49, Declan Doherty: > > > This patchset contains the name change fix in the link bonding library > > > makefile. I have also put a change into the unit test application > > > makefile > > > so that the link bonding tests are not built if the library is also not > > > being built. It doesn't make sense to split the bonding libraries APIs > > > into > > > a seperate library, as they are directly coupled to with the bonding > > > library implmentation > > > > You fixed optional building but there is still an issue when building > > shared library. > > As you don't want to split the library to separate the PMD plugin from the > > specific API, I suggest to not consider it as a plugin (unlike other > > PMDs). > > > > I've sent some patches about these 2 topics. > > If you agree, I'll apply them, merged with your serie. > > I'm happy for you to apply the makefile changes you have suggested and not > consider the bonding PMD as a plugin, I think this makes the most sense > considering it is a purely software library. Applied with Robert's changes for version 1.7.0. Thanks for all these revisions (v11 is currently the best score :) -- Thomas