[dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data

[dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data

[Arek Kusztal]

Fix AES-GMAC length of the data copied to the hardware to avoid
copying more data than necessary.

Fixes: 2fa64f840d65 ("crypto/qat: add GMAC capability")

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/crypto/qat/qat_crypto.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/qat/qat_crypto.c b/drivers/crypto/qat/qat_crypto.c
index 7e04f21..6764553 100644
--- a/drivers/crypto/qat/qat_crypto.c
+++ b/drivers/crypto/qat/qat_crypto.c
@@ -1363,10 +1363,10 @@ qat_write_hw_desc_entry(struct rte_crypto_op *op, uint8_t *out_msg,
 		if (!do_aead) {
 			qat_req->comn_mid.dst_length =
 				qat_req->comn_mid.src_length =
-					rte_pktmbuf_data_len(op->sym->m_src);
+					op->sym->auth.data.length;
 			auth_param->u1.aad_adr = 0;
 			auth_param->auth_len = op->sym->auth.data.length;
-			auth_param->auth_off = op->sym->auth.data.offset;
+			auth_param->auth_off = 0;
 			auth_param->u2.aad_sz = 0;
 		}
 	}
-- 
2.1.0

[dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions

[Arek Kusztal]

This commit removes unused ablkcipher struct and functions

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/crypto/qat/qat_adf/qat_algs.h | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/crypto/qat/qat_adf/qat_algs.h b/drivers/crypto/qat/qat_adf/qat_algs.h
index ad4b8ba..4c0a09b 100644
--- a/drivers/crypto/qat/qat_adf/qat_algs.h
+++ b/drivers/crypto/qat/qat_adf/qat_algs.h
@@ -139,14 +139,6 @@ struct qat_session {
 	rte_spinlock_t lock;	/* protects this struct */
 };
 
-struct qat_alg_ablkcipher_cd {
-	struct icp_qat_hw_cipher_algo_blk *cd;
-	phys_addr_t cd_paddr;
-	struct icp_qat_fw_la_bulk_req fw_req;
-	struct qat_crypto_instance *inst;
-	rte_spinlock_t lock;	/* protects this struct */
-};
-
 int qat_get_inter_state_size(enum icp_qat_hw_auth_algo qat_hash_alg);
 
 int qat_alg_aead_session_create_content_desc_cipher(struct qat_session *cd,
@@ -163,14 +155,6 @@ int qat_alg_aead_session_create_content_desc_auth(struct qat_session *cdesc,
 void qat_alg_init_common_hdr(struct icp_qat_fw_comn_req_hdr *header,
 					enum qat_crypto_proto_flag proto_flags);
 
-void qat_alg_ablkcipher_init_enc(struct qat_alg_ablkcipher_cd *cd,
-					int alg, const uint8_t *key,
-					unsigned int keylen);
-
-void qat_alg_ablkcipher_init_dec(struct qat_alg_ablkcipher_cd *cd,
-					int alg, const uint8_t *key,
-					unsigned int keylen);
-
 int qat_alg_validate_aes_key(int key_len, enum icp_qat_hw_cipher_algo *alg);
 int qat_alg_validate_aes_docsisbpi_key(int key_len,
 					enum icp_qat_hw_cipher_algo *alg);
-- 
2.1.0

Re: [dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions

[Trahe, Fiona]

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Tuesday, July 11, 2017 2:36 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Griffin, John <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Singh, Abhinav
> <abhinav.singh@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] crypto/qat: remove unused ablkcipher struct and functions
> 
> This commit removes unused ablkcipher struct and functions
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH] crypto/qat: remove unused ablkcipher struct and functions

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Trahe, Fiona
> Sent: Tuesday, July 11, 2017 2:45 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Singh,
> Abhinav <abhinav.singh@intel.com>
> Subject: RE: [PATCH] crypto/qat: remove unused ablkcipher struct and
> functions
> 
> 
> 
> > -----Original Message-----
> > From: Kusztal, ArkadiuszX
> > Sent: Tuesday, July 11, 2017 2:36 PM
> > To: dev@dpdk.org
> > Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Griffin, John
> > <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> > Singh, Abhinav <abhinav.singh@intel.com>; Kusztal, ArkadiuszX
> > <arkadiuszx.kusztal@intel.com>
> > Subject: [PATCH] crypto/qat: remove unused ablkcipher struct and
> > functions
> >
> > This commit removes unused ablkcipher struct and functions
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo

Re: [dpdk-dev] [PATCH] crypto/qat: fix AES-GMAC length of data

[Trahe, Fiona]

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Tuesday, July 11, 2017 2:36 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Griffin, John <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Singh, Abhinav
> <abhinav.singh@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] crypto/qat: fix AES-GMAC length of data
> 
> Fix AES-GMAC length of the data copied to the hardware to avoid
> copying more data than necessary.
> 
> Fixes: 2fa64f840d65 ("crypto/qat: add GMAC capability")
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>