From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0050.outbound.protection.outlook.com [104.47.34.50]) by dpdk.org (Postfix) with ESMTP id 04A7E1B70B for ; Tue, 17 Oct 2017 07:46:19 +0200 (CEST) Received: from CY4PR03CA0105.namprd03.prod.outlook.com (10.171.242.174) by MWHPR03MB2702.namprd03.prod.outlook.com (10.168.207.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 17 Oct 2017 05:46:18 +0000 Received: from BN1AFFO11FD028.protection.gbl (2a01:111:f400:7c10::120) by CY4PR03CA0105.outlook.office365.com (2603:10b6:910:4d::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.77.21 via Frontend Transport; Tue, 17 Oct 2017 05:46:18 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD028.mail.protection.outlook.com (10.58.52.88) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Tue, 17 Oct 2017 05:46:17 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9H5kExF032702; Mon, 16 Oct 2017 22:46:15 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= CC: References: <49446c2cba12cd5da276bfde8479aa97dcf0f653.1507796100.git.gaetan.rivet@6wind.com> <39e734ea-531c-6335-f1d5-22c75fe38f9e@nxp.com> <4f3a6e5e-65ea-4cef-1146-3b91943ec5c7@nxp.com> <20171016134216.GD3408@bidouze.vm.6wind.com> From: Shreyansh Jain Message-ID: <149a30e6-9377-2c2f-9df6-ac32f5f024d0@nxp.com> Date: Tue, 17 Oct 2017 11:28:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171016134216.GD3408@bidouze.vm.6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131526927779016643; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(346002)(376002)(2980300002)(1109001)(1110001)(339900001)(199003)(377454003)(24454002)(52314003)(189002)(229853002)(106466001)(47776003)(105606002)(305945005)(189998001)(97736004)(6916009)(2950100002)(8676002)(81166006)(81156014)(36756003)(2870700001)(76176999)(8936002)(2906002)(33646002)(6666003)(50986999)(54356999)(356003)(6246003)(53936002)(65826007)(561944003)(498600001)(50466002)(5660300001)(58126008)(316002)(64126003)(68736007)(65806001)(69596002)(65956001)(93886005)(104016004)(31686004)(4326008)(85426001)(77096006)(23676002)(86362001)(83506001)(31696002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2702; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD028; 1:vpYPFj75H47SU5SI6FHgGlJ418aTftFia8zYQLDr9FKCkra7SnolsckwD+ezblxnGGvTsriMjh8qagowunqfdeKbzaNF453inxxISleQoD8uOaUmBUQcRQ76588GDpuG X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10c02640-1051-4c8c-afc3-08d515226321 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:MWHPR03MB2702; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 3:77P3/ffk6wparsQJWl+oLHUpYd5iF2KiWAqNvXk07Ei6Lbz5B6uk+lX3M1PU3Obt6+LqJ7yEwVi14/B231aPSoX0ppxspXJe3mYBVT0/OBuqi3MflMQL7wKHLbHdg019kIkUwRS6bW5n2OyQm1HXYnvQHQ/2k4qcLRFNRlxHeZnpAj5/qfZJ5/QGCojHkVGFy7hRe23t41WkXNsucYyHxFxlX0eHPLoLC99/SGwowI1x57Nu4Gdnl+YKBcT3Cwi623fg0FgHl2RfBg+trmYpqcTsNU5XXrGM/Xffz7CESDVKJ/JSq+VSWP6jAkFsPN56KI9I/WxRAUv4B1iR4DZecA==; 25:+chHZ4yZipZWBeZAuxnHHRYtXP4J4uIJABq6DIuypA2b4oCcl1JeQBqwnT3cjcGigjNqtdNIuTfNn4TeCQtsziwEJ/bJZJy27gh0qSG70nvNFxM7n56fag1eeqJo+GmxEvPTz+Pyr3RG9IHojBs9G4ex9/YQvZ9ZsA6R2SXYr2dCBB4IxcUm1mdkwP4vBhTERFYI3hEjFyouOhww2OsSfIeLO5egzzx1wgl9SuIWP8mjeqw1nHnBi23cYP5zp0jvntMWOAiUEKLteEsiwX5rYiiiV44iv6H6p4PhwtI8cldC5lhfCFamlgqMnXNh6CH9SYVSCCv4TN9R/gjrcOX/DA==; 31:tumlBQ0wiWVwEOO2sdgfBwSCwBWeIhwEeeyCUymwf8EaLHOjNRYlgSeuqrG/Ic3bUflobx6dIbFiMrCvYvTFT6c8G6lQOcJYukcimSxQQlbOCYsSOqW5M1s/c+8Ss6gwE3iKYCxO4RvawvY4Ogpc5ZeAyWr3DTbgWrpAxBVoZXv2j5D5iLW7XomOHcuWCmJU2ytaV0JVGB97/lBGJRufDyFYl+O56SAqJlUMNTr7iBY= X-MS-TrafficTypeDiagnostic: MWHPR03MB2702: X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123563025)(20161123561025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123559100)(20161123556025)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR03MB2702; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR03MB2702; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 4:j3xFo+E/uN7XWXsjDbzysoXJwjqJFldOcVU+Rgl5IKHfiCQpSCY9gYT6BkAKJxj54VzTVKc4Z7jk29oP9/S8E2GSa2WAwrK/aH/HwDyXWss+ghpa7uJZOZp4P21/O30HEOBCTzqEHiwS8LLRX30ehok73jHoDI4njYP/EhjUwDdpnRFA/XmwmQM7tUiYQCtvTQ4D7eFSKMB6x/7gEhgcmZq5Cppgqlg7BZePDy+z0fMN3Int5GnQfU3S+zeJVzXV X-Forefront-PRVS: 04631F8F77 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjAzTUIyNzAyOzIzOi9uR1l3bWlhZUMrY2dscWJqRkZHRm9UZmtv?= =?utf-8?B?UlVUbEpBZnczQlY2blBkZ0RvNFlxclVKWGx0NGhISGNoWVVoSS9VU3hRMFRS?= =?utf-8?B?L053L21aUTNaYmNhaFlMTXg5eXE5MGxNRnRaSGNSTnpZWlZTaDZJcGNRV2I2?= =?utf-8?B?Q1F0NXRpNFBtRmNReVFxUW9KZ2N3YTJieEZFckF1K2x4NEhVWUJzR2JqbmRS?= =?utf-8?B?enpDVXYyWFRIOVdDeWx6S05DR0VxbXdZNUk1cUl0ZnRoK0dST0RQWHp4Y1g4?= =?utf-8?B?NVFndFdtN3ZnNXBxQVZzbEpGVy84cHVpbm00SGF6a2w2Tjg5NWpyV1JZdHhm?= =?utf-8?B?cWhlM08rdmJjOFVWMUpkNTg0OVNsMXFKRzJjZ0VzaXlpRytTZHQvblROaUpR?= =?utf-8?B?MkhReWpHNWw5dzB6RjBkaUNJdFA2UkQ0RkluMk9Pd0J0blExVmZVM2UvcTAw?= =?utf-8?B?OTlnaFhZSVJlVDdOOHNNMmp5TEJVdWtXb0lsRFdrdmV0cmlVQ2ozdlYzR1hk?= =?utf-8?B?WjQra28yTUs3MEJpWHhYS3dFaTEzUTNZend4aThJTGIyNGQxS0lVRTRxWmlo?= =?utf-8?B?Tm9EVVBhUXhISjF3Z2VsRGFFMlFLRGxFdTVTTGtoR3FLUXRRb3F0cjMzdTZL?= =?utf-8?B?YTg2Qy9mMVRWM3h3VjY2aHlJSnZkWGpnSENPZFd2WVdxc29Vbzg1WG9iMzVa?= =?utf-8?B?RU1OWDk3VXpQTUpLNUNXdmx6TWhaMFBtMFBVWUpxckxLRGQyOUtjSHpGYkF3?= =?utf-8?B?Nllpb2V5NERoYWh5Tlc4RWIvTk1ybXE3SzFqazR6ZDVtM21pZFJPNzhlcGRT?= =?utf-8?B?VlVDL3VOd3ZzbnQraytUeVh5SWlUdENVVnFGYy9TbFp3d0VHelNqdjNVUVBM?= =?utf-8?B?YjA5b25wYW9FNmlXaENQUWtML0gvWk4ranZJNVVkZksvYzRLckt2NzZOMGQv?= =?utf-8?B?OC9ERVV6dnBMajU2U1VvV0piREZINW5hS3VTTFVMUUhTblI5azExa2JVeTU5?= =?utf-8?B?TjV3K2NQTDNpQmVnZ0d6dyt2MEdzUnVHZGgxanRDMHlTeG9nblA5d2NrdUpu?= =?utf-8?B?eWtTTTJpa2FVeGR4Y21adnFwZnRCRXkxYm0yeUhDUDBnTFNiR0hleERRMzBD?= =?utf-8?B?b1daeEZQT1RabUtycG5xSDNINXV5amJab0NWdWl2bmFWL1FORkhtVjRLbXdL?= =?utf-8?B?UWJxYTlXOTB3b0RGRE5rbUFwVzZpcnkvcURuYTJ4L09pMGY1T3FiYWdNWnlm?= =?utf-8?B?R2lUb2NzNUtKRHl2QlBIeFkyODNLYWl4ZU1vQmQxeXU0RXo2K3cvN25SYThE?= =?utf-8?B?VE96cjgxM210ZmJyN2NPQmpsMWMvVWFJUlRmTjlhamZBRkZSMklXZE9kc3Fx?= =?utf-8?B?c3FMaXV3OXovMDRIYXo2MUZnZU9IcVRqVkdBa0xJa2dSQzI4cjlQdjB3bDZ1?= =?utf-8?B?S3U5R1A2aE9Cc2pJdUV2ck93Vm5CSWl4alM5d2xsVjRDNXR3TkJsUzJPQkpw?= =?utf-8?B?SVovUTBwc3RlYWFnSk0rVXBHbXNjM0h4OFJhRGhMdC9Pd1RZdTRXVURjNDV0?= =?utf-8?B?MzhxMDVZdkZhWC9yV1ZDNHQ0Q1VFYmNvTWNxQ1ppenNSdUMrYk1DdS9jempw?= =?utf-8?B?ZVF6Q0FnUTdiUTVUTGxLYVEvLzNueDRJczBRWVBEdnlTbGZJV082Y0swVnVw?= =?utf-8?B?V09MOHNvZU1jbHlkdkw0U2d0dmtWNVB0d0xrcjdkSG5hRGQ3NXIxWTFhMG1S?= =?utf-8?B?WDRIRnF2OUpoNC9DRlB5TnlXVisvUTg1MlVmMWZUaWRpbkErN0ZFZ1dwNjY2?= =?utf-8?B?MTlaWWV3ZzdmVkpib1MvbE82VUpLQzlyV2QybS83V0x1bWc2cWNMVHZBdnBm?= =?utf-8?B?aFJPc2NkWEZsajNFUnZDeFMyUncrc3VxQklFTnJvRjFpOXUrWWFNaC80eXUv?= =?utf-8?B?MUNCMEVlTEJnPT0=?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 6:2BX13GWmMSDRRTxEh7ymRHVj5wob9srqDXt3Wtf1bYsjjyBX+Zodq6Vda3GTxYuNQ+/zlUZku7Ff4dwjyne7WdDHRdVpD4Bzmt/fBB4W2U354IQW75i9BmP56YGAVGUrlt05GsNnajzhqpRyszFBQvNQ5N/1uUsGKcgj4jaM7kT+MuBbrhvZeGsjmQKsPTeIlvh0G9vieBh7rmT+8ZprPbur+fYfuD37IMSCqcGSx6jZcnaaqQVbBggPhgdQzf0pLUAzyEGCR1vFWjHQxK8SrgrwIxo4lG5zwYRlE+S0KGr1TPVXz87FXY/DwkjzXB7HU5a22pMa3PJBSufFiDpwrw==; 5:f07XD+5LvkJ44VILlDJhKjTNvjV45z/OQ2F2YQuaQEQ4ivDp2hLjlC3wtpoIrls6CYiM6HrqMhIeTwZ6nejj9FtrQ6pDY2ELfzdUtYaa66eOuVr3s1CopTOu6dwItvTL5yLAyGZ/uOzrEccaAg+ySA==; 24:haFuOlabILR+Tb+H63g4NI4tZDeQ+Mwk8W7uo6NT3WAgJgqcGVjqFC/ATREHxYrinysqmiTzKdNYvtLKQlgcqbRoMYZz1Lwi+jYfipm7w8Y=; 7:HbO/xcXWsKhX7CkVNzPgvkWCpihSMzl3UCFm6Zj68c5bhUy/21dpkiJyFlOjpI36+ZcuJvv+eHoAnVuwbXbvIjCLRQucMKVTKEFRC3DHwB2TtUnxe4SQIvLX3ztwyj7w0Uh/6kcwQsQPFu1dgfZXBO04T4u7ZA3BZuWlO5hPdB0Kicmg98kO5ydwWQT5K9Hv4kW8bpTjGkYxyejgAXAeVDV1GpYcUJGirI7Do7AgEbo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2017 05:46:17.6208 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2702 Subject: Re: [dpdk-dev] [PATCH v2 11/18] devargs: simplify implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 05:46:20 -0000 Hello Gaetan, On Monday 16 October 2017 07:12 PM, Gaëtan Rivet wrote: > On Mon, Oct 16, 2017 at 05:12:37PM +0530, Shreyansh Jain wrote: >> Hello Gaetan, >> >> Please ignore this email (reason inline) >> > > Hello Shreyansh, > > Thanks for reading this patchset, and sorry about the confusion (the > previous cover-letter only listed the PCI bus move, the bus control was > only added in this version). That's OK. I mixed up the cover-letters anyway. Probably the complete series needs a rebase as some patches have changes exactly same locations in EAL where this patch impacts (at least for PCI movement patches, I found patches had fuzz factor) > > I'd be very happy to see these series integrated for this release or the > next, and as such your opinion would matter a great deal. I do understand the importance of this patch series - but I have not been able to devote enough time to this lately. Even now, I am not sure if I would be able to completely review all within 17.11 timeframe as it is quite big. (And I have some personal time-off coming up soon!) > > However, I have found important issues that I am still working on with > the PCI bus move. I am trying to fix this in time, but I'm not sure yet > to succeed soon enough. I understand. It is a complex series - specially the build break in PCI movement on per patch basis - that would be difficult to solve. Probably that requires adding dummy functions/variables to allow compilation and then moving them out. It is indeed tough choice. > > It would block the rest. I could still redo both series without the PCI > bus move but the bus control scheme is necessary for the devargs > cleanup. Probably it is best to postpone for 18.02. It indeed is difficult to let a proposal fall through a planned release - but this work is really critical as it impacts a lot of people (PCI, Buses, args etc). Just my personal opinion. > > I don't know if this bus control scheme is interesting enough though. > I need additional opinions about it. I haven't started reading the Bus control yet - I am still focusing on PCI movement and then I had planned the devargs. But, I will start looking into this as well. I would try to add whatever opinion I can. > > Anyway, thanks, > Always welcome! But, that's what the community is for. :D - Shreyansh