Re: [PATCH v2 0/3] testpmd support pause/resume specify lcore's fwd

[fengchengwen <fengchengwen@huawei.com>]

On 11/6/2025 2:59 AM, Stephen Hemminger wrote:
> On Wed, 5 Nov 2025 17:47:45 +0800
> Chengwen Feng <fengchengwen@huawei.com> wrote:
> 
>> This patch support pause/resume specify lcore's forwarding for testpmd,
>> and also include two bugfix which found when test DCB function.
>>
>> Chengwen Feng (3):
>>   app/testpmd: fix invalid txp when setup DCB forward
>>   app/testpmd: fix wrong Rx queues when setup DCB forward
>>   app/testpmd: support pause/resume specify lcore
>>
>>  app/test-pmd/cmdline.c                      | 126 ++++++++++++++++++++
>>  app/test-pmd/config.c                       |   9 +-
>>  app/test-pmd/testpmd.c                      |   5 +
>>  app/test-pmd/testpmd.h                      |   2 +-
>>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  14 +++
>>  5 files changed, 149 insertions(+), 7 deletions(-)
>>
> 
> Please split bug fix from enhancements.

done

> 
> The whole scheme looks like an optimization for power usage in testpmd.
> Since testpmd is solely focused on performance, I don't think you have
> provided enough justification to add the new feature.

I know your worry, especial in this cycles.

> 
> With DCB if there are TC's that could receive packets, it is better
> not to never poll those queues. 
> 
> That said, longer term it would make sense to bring of the power
> saving logic that is in examples into testpmd.

I will try to another way to meet the usage of specify TC.

Thanks