DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Cc: Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix formatting in testpmd user guide
Date: Tue, 9 Mar 2021 12:52:34 +0000	[thread overview]
Message-ID: <14c80ab0-217e-95b0-7997-2c4297f9ad1a@intel.com> (raw)
In-Reply-To: <20210308223434.48768-1-ajit.khaparde@broadcom.com>

On 3/8/2021 10:34 PM, Ajit Khaparde wrote:
> Fix formatting in testpmd user guide for hairpin operation.
> 
> Fixes: 01817b10d27c ("app/testpmd: change hairpin queues setup")
> Cc:stable@dpdk.org
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Cc: Bing Zhao <bingz@nvidia.com>
> Cc: Ori Kam <orika@nvidia.com>
> ---
>   doc/guides/testpmd_app_ug/run_app.rst | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
> index 3035118cdc..8ec2300ee5 100644
> --- a/doc/guides/testpmd_app_ug/run_app.rst
> +++ b/doc/guides/testpmd_app_ug/run_app.rst
> @@ -531,11 +531,13 @@ The command line options are:
>   
>   *   ``--hairpin-mode=0xXX``
>   
> -    Set the hairpin port mode with bitmask, only valid when hairpin queues number is set.
> -    bit 4 - explicit Tx flow rule
> -    bit 1 - two hairpin ports paired
> -    bit 0 - two hairpin ports loop
> -    The default value is 0. Hairpin will use single port mode and implicit Tx flow mode.
> +    Set the hairpin port mode with bitmask, only valid when hairpin queues number is set::
> +
> +	bit 4 - explicit Tx flow rule
> +	bit 1 - two hairpin ports paired
> +	bit 0 - two hairpin ports loop
> +	The default value is 0.
> +	Hairpin will use single port mode and implicit Tx flow mode.
>   

Not sure if the last line intended to be part of the list, what do you think 
only keep bit descriptions in the box but left the last sentences as regular 
paragraph.
Ori please correct me if I am wrong with the original intention.

  reply	other threads:[~2021-03-09 12:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 22:34 Ajit Khaparde
2021-03-09 12:52 ` Ferruh Yigit [this message]
2021-03-09 22:00   ` Ajit Khaparde
2021-03-26 10:00     ` Ferruh Yigit
2021-04-13 16:18       ` Ferruh Yigit
2021-04-23 16:29 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2021-04-25  1:53   ` Li, Xiaoyun
2021-04-27 12:03     ` Ferruh Yigit
2021-04-25  6:12   ` Bing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14c80ab0-217e-95b0-7997-2c4297f9ad1a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=orika@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).