From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06456454AC; Wed, 19 Jun 2024 17:57:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABC8942D6A; Wed, 19 Jun 2024 17:57:04 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 19813402D3 for ; Wed, 19 Jun 2024 17:51:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718812280; x=1750348280; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=S5uF6Nq539RW2nIlW9SE2DSNXXOE1FKsJhUxLAMPS8A=; b=OASjBufG19aD/8b9+W6ggobqvdVvH41bkn/p5M66iH2ORmIglE1WjBoS RRwlIeJVX0gCbhxpvRYQjvA/7VCl+1dBQag+9AHIKBFuqRafB6YkakunC eIrk2jHQbfVkaSnHOF35J00xs6sNefTupT4k4b3DM4LFbBwkphMX3a0LJ j4N/zogHHpv9/hI4M4qL4Al01QaaL5LhRtEOsbSaTN5YswscUPXn7l1eZ hR+pYQpODjzvT5ewZCC3vNij5UHT6Q4zJ0qbqOtQcQmWyIQa+IHAl/h7W nornT/zwdsjuJqodRjWwjvG/jGJwZSgc/opYmR8UQJXYj3GFrpOlwrhqB g==; X-CSE-ConnectionGUID: X4polbubTzmbHq8QIJvgFg== X-CSE-MsgGUID: 82OrK38FSMqynxNMrSAuLg== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="15901031" X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="15901031" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 08:51:19 -0700 X-CSE-ConnectionGUID: yEOtgdC+TXa6fSNmvTWdcA== X-CSE-MsgGUID: JyLsJVsfQ2C/itgt1/j4OQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,250,1712646000"; d="scan'208";a="42063401" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Jun 2024 08:51:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Jun 2024 08:51:15 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 19 Jun 2024 08:51:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Wed, 19 Jun 2024 08:51:14 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 19 Jun 2024 08:51:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GVw2my/7cuH+NS3ne0xffH0YFcevIBJFd+6SzQZknz7sOg0qVxhdwJQNMp5aSytq+2BvC/glpgE1K8iuPibJnyKn+xfdLcAqu+NX1zhqSGCJQw97ukPrDC5Akz68YOEKDD4OYrdHkFnSZSoKQovY2vMPNyrVPnoPrfmKQAnZX2Y7qFSRahmaQJ3RsuM1pALeWwQr23/FKDMKMJy0hPUQ1ra4VksUkv+ZtgKtSE/KkcH6F8DJ2uPYjNl4wh6zWKuaUPg9BpMLlJ9DofAjTj7md6S9nZprTCoNEJlDDdTKirzjzH1wD7VR+3rpiqrJIKTLhlMWNC6yFER+NSZmlp/dDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4LTPbPz5p25TOt59l9zzh8oMBFUzIoil2iR967xHOmU=; b=l98scV3oSyyGPitDCuAQNc17o0y3NvcB5zOuf+flRZDEOCZMl/e4gp4vGeno8vR4sAKnRXw4EOBXLwzH3c9uTJumFWSCcQlRcl8gDvgvh7QT2rgjuAyHcElbhOuV07Ea8TBZ9nJ1QPj75HrPt4pM3BnqqRtydeDzt0xZUQ7upyUUnzIMAuH8VESJDhMTc4rcvPlFFXBBvk+gY2DTIdtgXOq41NFGEYU0UAs9gLG6MB9VozK8QwwzeOnQgMzUvBtQ6Yf+EVDxTmD+1zCibJE+PIJ+78wc0MKPmd5wnTNsKRFLx/yluokmO5BMvO2g9cLsgP+bJCiUrFXtBP6gTqy8kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) by PH0PR11MB7471.namprd11.prod.outlook.com (2603:10b6:510:28a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Wed, 19 Jun 2024 15:51:11 +0000 Received: from MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::15b2:ee05:2ae7:cfd6]) by MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::15b2:ee05:2ae7:cfd6%6]) with mapi id 15.20.7698.017; Wed, 19 Jun 2024 15:51:11 +0000 Message-ID: <14dec1e1-c373-44d9-bdbd-cee2cee74640@intel.com> Date: Wed, 19 Jun 2024 17:51:05 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 019/148] net/ice/base: bring back ability to use 128 as size of PF type RSS LUT To: Anatoly Burakov , Ian Stokes CC: , References: <20240430154014.1026-1-ian.stokes@intel.com> Content-Language: en-US From: Przemek Kitszel In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1P195CA0055.EURP195.PROD.OUTLOOK.COM (2603:10a6:802:5a::44) To MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8102:EE_|PH0PR11MB7471:EE_ X-MS-Office365-Filtering-Correlation-Id: 21950afe-50e5-4b2f-1a7a-08dc9077a413 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dFpWWTBvMU90dDJLVlpBS0tNYlVrejNyRktlcUU5dllZRGw0Zy9VN1k3SjJm?= =?utf-8?B?TW43UzYxYVFpOTNWWTRBNnFRZzBrRiswNzJUODIwR0J4akh1bGVraTE1Wktm?= =?utf-8?B?RFM0OEVFOXplNDlnUUhmcnRPaVpBKzJtZkVra0VSWEV1bGtQMkI1RGZ0eGU3?= =?utf-8?B?NXR6TWNLcmFHZGdDaWQ3Tm9MbHdhcXRJZ0U1bkhuQTVTdFZNdThDUkJSMFQ1?= =?utf-8?B?cHBVSktiSjNUcUdRQ1FRMjlrTjA1TUhDWTJBOTZtU3ZlV1VlWTArZ2JrTytB?= =?utf-8?B?ZCszNHdmNlJLT21NVzdVLzFMMHdaK2hwVDZtZGQ4d3poUUFxbUhDUVhnZlJB?= =?utf-8?B?WkNxbDZNbVNuSjd2UW9nQU1xdGI4TER1d3lTcHVXNXBsUHdBcDVtZTRwcy9u?= =?utf-8?B?d0VyQmg2dWVWMENkbU96blhvaTUxcHNBNWltaTNCKzh2NUpGb09jOS94a1lM?= =?utf-8?B?cElOMjFudG1Yc3B5eEpzdUlqVU5TMVhFNWM1c1AvVmRrbGJPSitZQXZtUCtP?= =?utf-8?B?dDdaRkVTN3NRSEphYUJibms3NlptNS9lWWZjY25pM1ZlZkFpNm5VaE40aENI?= =?utf-8?B?VDd5L0pLSUhoQXVSaUVJa1hKWlkvWGdoSzRLL3VnYTJldUx3MGVTdkYyaEJ6?= =?utf-8?B?cXBFN2lsQlZ3RFNYTTlqWGxKaUdMWGp0ak9CSHljY0ZiNStvdmtvRlBtd000?= =?utf-8?B?L1Evd0p4V0V0Y1BFVENCRy9pU0EzVm55QmU1anJ2WGNVdlpOeEgrMnFqR3Rk?= =?utf-8?B?WjB6RitnU2tGNnd0am4remJ0TGpCZ1djNm0xMzZPZUpZWGpNVDRoSkNRVTc0?= =?utf-8?B?RDlUeWlkZkZFOVNsTVQ4SnJqZ280S0NUVDlwZitheHAyc1dqSFlkOGc5Sml2?= =?utf-8?B?RW0vMFNQYmM3dFNIVHA0SGpnUHlRUE9VdndMVkdiUThlRGxXK01rYWZ3aE1P?= =?utf-8?B?ZFl0eXJicmxHWGNVZmh3by9KbUt3RmJFL1BCT1hBRG03NjhSUzY5Y3QvaFVw?= =?utf-8?B?L3hFallvcVZ6aWpoU0FFaDl5eGNjR0ZwSXR0TjJsdFpXa3BjamVqNVhjTzdJ?= =?utf-8?B?UmY4cG1rbWk5aUlLNWVhT2ZydDh0QjJTZ1lZMU9US2NjV1BnWHZTZFZqdGJQ?= =?utf-8?B?eXNYY3Nwb2JteEROTUpDanB4dnhPRlg0V0wvRENpVFVYVExIREFnQVkvZHNZ?= =?utf-8?B?dGJ1WWR3VkxsbDlKOWlVRUkyWjg5SHhaQ0dRQUJ3amtuYmJQdDFWeWplbFJ4?= =?utf-8?B?UW1vSS91MVpjbGlBMXY5VUJHRGVKVkEzclJmWDl2TjRsYzVNVkxPb3ZOUk9s?= =?utf-8?B?clM0WnBwTjFHRlp1eStQT3NTR1VOeEEzQ3VoUTdiMVRLR01iMEhvb2ZHcVhh?= =?utf-8?B?RTUzaWdMMG1GS3RmMkQ5Wm1YQU4yNWF0MC9TYXR5UXJtTkNpcWlEbnVrYnRO?= =?utf-8?B?a1YvdFd6SWQ0MTRibGlqWXY5azJXS05uelloYi80dXhydGpmWDhnUnNMckZz?= =?utf-8?B?Yk5PLzRHL3IwUWZPaVNJTDNPY0o4cjQwSmdZajdEU0VzTlFYR0hPR3U4SWlX?= =?utf-8?B?dEZSbWIwQ25Yc1NqRVNUdjJ6S3FvZE5Wei94SWFBR2dmcDRlb1JVTHlvUGgy?= =?utf-8?B?VElSQzhUeTMrSitiTUhiZUJxRlMreW9oaVhqc0hqN2tWRnFrWEJuZ3FyUzlh?= =?utf-8?B?M1F2RFVNbjR2L21KUXlWcWh3RmJGYllZSEZkNVk5KzgyUHBuS2xSbzJLV1E1?= =?utf-8?Q?prQJ+f3E2CIql/mg/MEhhXr7+tVxcf4uV2e8acU?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN6PR11MB8102.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDJxWnh6ckNWS2ZtbytQYWFwbTFXUitFY1BaQ20vejlpU0VES2RLcmV1SFNK?= =?utf-8?B?NmwydFNsVTR2L2w0eGI1c0ludG03VzBVMFhrQ1lQbGVlaGwvdWl0VngvSmk1?= =?utf-8?B?T2YyWUxUa2xYb2ZDc1o5cDJBMngvSTVuOG5OOEEvcE9FbWRhNXhFZHJnYVlR?= =?utf-8?B?K1JEUGp1emdBT1c0ZXlZbTBISnFkZnhxeWg0Q1p5Qk5oY1RJVkRYMGNGeHkz?= =?utf-8?B?UWxEU2hZcWk2aGdRV0xKc0ZkM3lKRllBN0laQTdBbVo5ZllGOVNTMzc3ejNW?= =?utf-8?B?K2ZWVG5TQnJCb2taWlVmMTA1OGxETHArZ2xDSUI4K1RocTN3Si9vVng0YThn?= =?utf-8?B?RXZkMkF5WlU0SCtsZDhHRWJBaG9CZmVEbGxEWDBMVGQ1MzFNY2NxOUdwOXJP?= =?utf-8?B?eFNsK1VwVnBTK1hsVDdpMEhMSCt4bnRGM241cmI5NHdGd1dlQVF2ellHTWJw?= =?utf-8?B?VzRYNXZVNXl3SzNmeDVYRkdUQW1LQ042WHZEb21lOHJJaFFhWjV3aFVRUnVB?= =?utf-8?B?VXJ2M1dVZUtreUwwQ1ZIRXhyd2djRWlobVdxQktNL3BKZVVHMzhrQmsycVdj?= =?utf-8?B?OWxaS2o1UjVOU3NIUXBqZ1JFcWRNNkdlbk9aM0VSRDBJdDVXc1BDbVJ3MWZL?= =?utf-8?B?VjBrOXZob2RnS2h0RkJLUnppUTFHSG5oSHVHZncyOXZhMFJ3VmlaL3Rac3NF?= =?utf-8?B?L0Q3aldaNkQ4SERHdXB4MGluZERHaFhTZjdtQ1lKYUpnRkYxTDdGK2o4VmFy?= =?utf-8?B?Qmhheno2S0tGQmZJSEJ6Z1R2aXF2YXBlM1JJOWJ3bnlaejFVaUc0eThkbUdE?= =?utf-8?B?QlAybWFjY2hOU0F3R28vaGZtbDhIV0RLRTBmUlF0T0Z5VExvREhGeDN6TnNz?= =?utf-8?B?MGJGSnhJT0I0M3dwVjRPR0crL01aWVlHY2hFNTA1YkhoZ0JBV1RRVFgyRzBZ?= =?utf-8?B?STJIc3VOWXpuTHh0blh2QlYrOTdZSjdqSElXTmVqUDBqdlJoTHRZVkVlcEsx?= =?utf-8?B?TUtycUNkd0J5U2FKVnNIQnNLT3lFcE9tbFRpS1JZVE1BL3ZacGlyVUJPcHNV?= =?utf-8?B?VlFLeXYrM1pyVEV5RFBBWXU5eUNhMllDUndGMEJ5aXhySHJWdGJSSllzUm1u?= =?utf-8?B?OUdXYis3czhjcE1NMmdCamJDWE5RNnp2YVJXVzhrYTNwMm11NWJjV1JBYlVM?= =?utf-8?B?cVlBSlNSRGlhMnNWdnV2SG90L0U0RWJBK1ZiNDVBREw1aWt5enVvL1RoTzFW?= =?utf-8?B?REFSQzRYbGZxR0hGWlRxSzRjRGYyM0xVRVRmdFpwVHd5TmQzdHF0c3oyQVV5?= =?utf-8?B?ZFRvMjk2SmNialF2NTlVSnF3Z052Q3Vhd29sOGt2OTBYR1cxc2R5V3ZBWFFS?= =?utf-8?B?RWYrejVxNHNaUHJqYkhPUXZMRHRYRTkrZkw3dkFUTmhYcWFhc1NVQ0o4QjRC?= =?utf-8?B?T1piYnozYzBJWDlDQlJMb3lZMGprVXNqUmM0NEFjQlBZTUVjQ2VDSmVGd1Zw?= =?utf-8?B?VE1keGxJQTViVW5RaHlzYkJkSk1IMUFRdys2MDV2RzNoaCt5NnZncERkZExP?= =?utf-8?B?cGNxaXdqUEgyYThzRmlER2pTVXJPOW5XV0UwSTZNcUpYdVk1VXc0VS8rMTFF?= =?utf-8?B?c3lmSkh2THBDWmppUHNoUW52RU51bnByZkxuQVRtZmx1VDZwT05YM3d6a2hR?= =?utf-8?B?K3VIakV6OHVlTW5WeG0vS1hBZzdpWjM5RWJvRU56M2VIeUlYNFBQWGNHc1hm?= =?utf-8?B?ZGErckw5UmNzL1UzTUVQckY4dHFVZHphMks0LzBzWjhyMkY5MGNCbi9WYmRN?= =?utf-8?B?SXBJdnpLN0M5VHpnSTh5K1M0UUFUMTJsZWNkdlBCU0JWQnV6RUhrcVVnYVBW?= =?utf-8?B?VWJ0cWpJZ2VERkRrWXd6Y09mOXBOTzBkM2F0b2ErMHRGaEp1ZWhSaDRTUHh4?= =?utf-8?B?NXJtRVphVC9rU2ZaTEJibjRVYWlYVnUxbUFwSytWVThrbC9SanhsVGJmVnYx?= =?utf-8?B?aXE1ejJhYmxEZE5jMi9HaFd4QzBuZXRYb3NyaXJBUGJ2TzRDQjhXR3JsRUs4?= =?utf-8?B?dTRXOVVIbGpuY3FoTzh5dWpWZXNQMmxCT2FFRnNqYWE4WFZBK2NVM3hzVWNL?= =?utf-8?B?MXI2K3hEdUduSXFOdDQ0MmZsZkpmTDMrSkZuZndwTkRWWjNBNkhBU0lVd1pv?= =?utf-8?B?d0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 21950afe-50e5-4b2f-1a7a-08dc9077a413 X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2024 15:51:10.9953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Euhft59tLxq7QUdCv0rKymcULburRHT+Mi/lLLATcVewzV/eE3PGOmFHnTIVYyKB/LBi+tI1Ekxwz11HzXuEoOgNfMiFnk9Q49DXFX9rWrk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7471 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Wed, 19 Jun 2024 17:57:02 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/12/24 17:00, Anatoly Burakov wrote: > From: Ian Stokes > > Allow PF RSS LUT to be sized 128. > > Recent refactor simplified code and made it impossible. > > Also clean up unused defines. > > Signed-off-by: Przemek Kitszel > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_adminq_cmd.h | 12 +++--------- > drivers/net/ice/base/ice_common.c | 10 +++++++--- > drivers/net/ice/ice_ethdev.c | 12 ++++++------ > 3 files changed, 16 insertions(+), 18 deletions(-) > > diff --git a/drivers/net/ice/base/ice_adminq_cmd.h b/drivers/net/ice/base/ice_adminq_cmd.h > index 3549fc28f1..ab3dfd8685 100644 > --- a/drivers/net/ice/base/ice_adminq_cmd.h > +++ b/drivers/net/ice/base/ice_adminq_cmd.h > @@ -2230,11 +2230,13 @@ enum ice_lut_type { > ICE_LUT_VSI = 0, > ICE_LUT_PF = 1, > ICE_LUT_GLOBAL = 2, > - ICE_LUT_TYPE_MASK = 3 > + ICE_LUT_TYPE_MASK = 3, > + ICE_LUT_PF_SMALL = 5, /* yields ICE_LUT_PF when &= ICE_LUT_TYPE_MASK */ > }; > > enum ice_lut_size { > ICE_LUT_VSI_SIZE = 64, > + ICE_LUT_PF_SMALL_SIZE = 128, This size is disallowed for both "upstream kernel ice" and "OOT ice", I added it only for Windows, so please disallow it. > ICE_LUT_GLOBAL_SIZE = 512, > ICE_LUT_PF_SIZE = 2048, > }; > @@ -2249,19 +2251,11 @@ struct ice_aqc_get_set_rss_lut { > #define ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_M \ > (ICE_LUT_TYPE_MASK << ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_S) > > -#define ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_VSI 0 > -#define ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_PF 1 > -#define ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_GLOBAL 2 > - > #define ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_S 2 > #define ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_M \ > (ICE_LUT_TYPE_MASK << ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_S) > > -#define ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_128 128 > -#define ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_128_FLAG 0 > -#define ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_512 512 > #define ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_512_FLAG 1 > -#define ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_2K 2048 > #define ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_2K_FLAG 2 > > #define ICE_AQC_GSET_RSS_LUT_GLOBAL_IDX_S 4 > diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c > index f88ced7a5d..34a4b74956 100644 > --- a/drivers/net/ice/base/ice_common.c > +++ b/drivers/net/ice/base/ice_common.c > @@ -4143,6 +4143,8 @@ static u16 ice_lut_type_to_size(u16 lut_type) > return ICE_LUT_GLOBAL_SIZE; > case ICE_LUT_PF: > return ICE_LUT_PF_SIZE; > + case ICE_LUT_PF_SMALL: > + return ICE_LUT_PF_SMALL_SIZE; removing this two lines would do what I want (but then you have to replace the title, as 128 will be disallowed) > default: > return 0; > } > @@ -4174,6 +4176,8 @@ int ice_lut_size_to_type(int lut_size) > return ICE_LUT_GLOBAL; > case ICE_LUT_PF_SIZE: > return ICE_LUT_PF; > + case ICE_LUT_PF_SMALL_SIZE: > + return ICE_LUT_PF_SMALL; > default: > return -1; > } > @@ -4201,10 +4205,10 @@ __ice_aq_get_set_rss_lut(struct ice_hw *hw, struct ice_aq_get_set_rss_lut_params > > vsi_handle = params->vsi_handle; > lut = params->lut; > - lut_type = params->lut_type; > - lut_size = ice_lut_type_to_size(lut_type); > + lut_size = ice_lut_type_to_size(params->lut_type); > + lut_type = params->lut_type & ICE_LUT_TYPE_MASK; > cmd_resp = &desc.params.get_set_rss_lut; > - if (lut_type == ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_GLOBAL) > + if (lut_type == ICE_LUT_GLOBAL) > glob_lut_idx = params->global_lut_id; > > if (!lut || !lut_size || !ice_is_vsi_valid(hw, vsi_handle)) > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 87385d2649..56adc3a3d9 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -3468,7 +3468,7 @@ static int ice_init_rss(struct ice_pf *pf) > > lut_params.vsi_handle = vsi->idx; > lut_params.lut_size = vsi->rss_lut_size; > - lut_params.lut_type = ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_PF; > + lut_params.lut_type = ICE_LUT_PF; > lut_params.lut = vsi->rss_lut; > lut_params.global_lut_id = 0; > ret = ice_aq_set_rss_lut(hw, &lut_params); > @@ -4928,7 +4928,7 @@ ice_get_rss_lut(struct ice_vsi *vsi, uint8_t *lut, uint16_t lut_size) > if (pf->flags & ICE_FLAG_RSS_AQ_CAPABLE) { > lut_params.vsi_handle = vsi->idx; > lut_params.lut_size = lut_size; > - lut_params.lut_type = ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_PF; > + lut_params.lut_type = ICE_LUT_PF; > lut_params.lut = lut; > lut_params.global_lut_id = 0; > ret = ice_aq_get_rss_lut(hw, &lut_params); > @@ -4964,7 +4964,7 @@ ice_set_rss_lut(struct ice_vsi *vsi, uint8_t *lut, uint16_t lut_size) > if (pf->flags & ICE_FLAG_RSS_AQ_CAPABLE) { > lut_params.vsi_handle = vsi->idx; > lut_params.lut_size = lut_size; > - lut_params.lut_type = ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_PF; > + lut_params.lut_type = ICE_LUT_PF; > lut_params.lut = lut; > lut_params.global_lut_id = 0; > ret = ice_aq_set_rss_lut(hw, &lut_params); > @@ -4996,9 +4996,9 @@ ice_rss_reta_update(struct rte_eth_dev *dev, > uint8_t *lut; > int ret; > > - if (reta_size != ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_128 && > - reta_size != ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_512 && > - reta_size != ICE_AQC_GSET_RSS_LUT_TABLE_SIZE_2K) { > + if (reta_size != ICE_LUT_PF_SMALL_SIZE && perhaps this one too, but only if you agree > + reta_size != ICE_LUT_GLOBAL_SIZE && > + reta_size != ICE_LUT_PF_SIZE) { > PMD_DRV_LOG(ERR, > "The size of hash lookup table configured (%d)" > "doesn't match the number hardware can "