DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Björn Töpel" <bjorn.topel@intel.com>
Cc: dev@dpdk.org, qian.q.xu@intel.com, lei.a.yao@intel.com,
	jingjing.wu@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf
Date: Wed, 09 Nov 2016 10:28:50 +0100	[thread overview]
Message-ID: <1500406.Wuc0qeu8Dv@xps13> (raw)
In-Reply-To: <20161109082341.19825-1-bjorn.topel@intel.com>

2016-11-09 09:23, Björn Töpel:
> Commit 1bbcc5d21129 ("i40evf: report error for unsupported CRC
> stripping config") broke l3fwd, since it was forcing that CRC was
> kept. Now, if i40evf is running, CRC stripping will be enabled.
[...]
> +		rte_eth_dev_info_get(portid, &dev_info);
> +		if (dev_info.driver_name &&
> +		    strcmp(dev_info.driver_name, "net_i40e_vf") == 0) {
> +			/* i40evf require that CRC stripping is enabled. */
> +			port_conf.rxmode.hw_strip_crc = 1;
> +		} else {
> +			port_conf.rxmode.hw_strip_crc = 0;
> +		}

Thanks for raising the issue.
It is completely defeating the generic ethdev API.
We must not have different behaviours depending of the driver.
Why it cannot be fixed in the driver?

  parent reply	other threads:[~2016-11-09  9:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09  8:23 Björn Töpel
2016-11-09  8:37 ` Yao, Lei A
2016-11-09  9:28 ` Thomas Monjalon [this message]
2016-11-09  9:39   ` Björn Töpel
2016-11-09  9:46 ` Ananyev, Konstantin
2016-11-09 10:05   ` Björn Töpel
2016-11-09 10:22     ` Thomas Monjalon
2016-11-09 11:08     ` Ananyev, Konstantin
2016-11-09 11:27       ` Björn Töpel
2016-11-09 12:13         ` Ananyev, Konstantin
2016-11-09 13:01         ` Zhang, Helin
2016-11-09 13:09           ` Björn Töpel
2016-11-10  5:49             ` Yao, Lei A
2016-11-10  6:17               ` Björn Töpel
2016-11-10  7:55                 ` Thomas Monjalon
2016-11-10  7:59                   ` Björn Töpel
2016-11-10 13:50 Mori, Naoyuki
2016-11-10 14:32 ` Thomas Monjalon
2016-11-10 14:43   ` Mori, Naoyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500406.Wuc0qeu8Dv@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bjorn.topel@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=lei.a.yao@intel.com \
    --cc=qian.q.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).