From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 272B83772
 for <dev@dpdk.org>; Wed,  9 Nov 2016 10:28:52 +0100 (CET)
Received: by mail-wm0-f52.google.com with SMTP id t79so288308165wmt.0
 for <dev@dpdk.org>; Wed, 09 Nov 2016 01:28:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=J+g78+siZLxMmph+UgSe4/QH1LTfSC+v1FeNJtFsS7U=;
 b=xD8iIDvy6zuWe3gTVcX8cNVwgFW77561vwC/UDadGlPLzq+Sg4hcFXmUhim5e2+o00
 1PSy9XZQNff21crHbaojqy9/QUiv7i6bCvtYJGdeIOkkhfRgRDYRT1ZhAR68fUzPXXEk
 fJJfJgTwXNYZx7kopF1DnWM08ZpNqMJNa60aSo45xRQQG/cxtQQjjJOHDZadiAWNae2t
 cfaVxO1hjh5VdQASiOmFhkmBnhSdDQH6MZyCJHNn4CqvhEKZmGOlbIMRutHHlhr5njzC
 4quVUp8NRZo5p0GOyGdxYpnsFy8LuSx6DO0Qzun8xh1VlcDM+h7wAAqlKv4tM4WUZKW0
 liZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=J+g78+siZLxMmph+UgSe4/QH1LTfSC+v1FeNJtFsS7U=;
 b=eq4mHo+Ec+t3oif1MdE7bi7xdsOhyvrTar4Y3/9WARhmiUVHTJFT9aU5idZeHwbM/4
 TwpD0+fGNV5aonMdESC0bLuyuCN1wKyJdKxicucntts5rm0LTqtEKlgMa3xS7nqoyxDa
 b/BonXgY3FmvncVYkvF6TKzUKyi2vJ2o7HjOumcVVuinDSes8wI8VxvOaTSXBNq4Cw6y
 yHuwvQXlYz1VQB+js/oC6DTNkvsX/A47fgyPhMsmdpTcoEPXDLH29fXar+wZ5Ap59NsX
 ALsPmj9w/AvqHNuLzKTdqwAZ6nxJw8V2qFDmqt7h96ToBoESlbKI947QQq3SI/8GTj/q
 zKhQ==
X-Gm-Message-State: ABUngvdh2MAWmIT3qcdnS91bT1faWLBtMwHRV7O4GZ81cMPSk22dfv2t/kfrIrg33PZah+kK
X-Received: by 10.28.131.72 with SMTP id f69mr16362873wmd.33.1478683731886;
 Wed, 09 Nov 2016 01:28:51 -0800 (PST)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id wh3sm41833580wjb.49.2016.11.09.01.28.51
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 09 Nov 2016 01:28:51 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn.topel@intel.com>
Cc: dev@dpdk.org, qian.q.xu@intel.com, lei.a.yao@intel.com,
 jingjing.wu@intel.com
Date: Wed, 09 Nov 2016 10:28:50 +0100
Message-ID: <1500406.Wuc0qeu8Dv@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20161109082341.19825-1-bjorn.topel@intel.com>
References: <20161109082341.19825-1-bjorn.topel@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for
	i40evf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Nov 2016 09:28:52 -0000

2016-11-09 09:23, Bj=F6rn T=F6pel:
> Commit 1bbcc5d21129 ("i40evf: report error for unsupported CRC
> stripping config") broke l3fwd, since it was forcing that CRC was
> kept. Now, if i40evf is running, CRC stripping will be enabled.
[...]
> +=09=09rte_eth_dev_info_get(portid, &dev_info);
> +=09=09if (dev_info.driver_name &&
> +=09=09    strcmp(dev_info.driver_name, "net_i40e_vf") =3D=3D 0) {
> +=09=09=09/* i40evf require that CRC stripping is enabled. */
> +=09=09=09port_conf.rxmode.hw_strip_crc =3D 1;
> +=09=09} else {
> +=09=09=09port_conf.rxmode.hw_strip_crc =3D 0;
> +=09=09}

Thanks for raising the issue.
It is completely defeating the generic ethdev API.
We must not have different behaviours depending of the driver.
Why it cannot be fixed in the driver?