From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe
Date: Thu, 30 Jun 2016 09:41:57 +0200 [thread overview]
Message-ID: <1501713.7uhgKcRiBR@xps13> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090348C059@shsmsx102.ccr.corp.intel.com>
2016-06-30 01:40, Lu, Wenzhuo:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2016-06-23 01:04, Lu, Wenzhuo:
> > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > > 2016-05-06 05:33, Wenzhuo Lu:
> > > > > > +int
> > > > > > +rte_eth_dev_mq_mode_set(uint8_t port_id,
> > > > > > + enum rte_eth_rx_mq_mode rx_mq_mode,
> > > > > > + enum rte_eth_tx_mq_mode tx_mq_mode);
> > > > >
> > > > > I've really tried to think about it and I think it is more or less a hack.
> > > > > First, it is not explained in the doc when we should use
> > > > > rte_eth_dev_mq_mode_set() instead of a simple call to
> > > rte_eth_dev_configure().
> > > > > Second, I don't understand why having a function which configures
> > > > > the "multiqueue modes" without configuring properly RSS/VMDq/DCB.
> > > > > Last, it is said that rte_eth_dev_configure() "must be invoked
> > > > > first before any other function in the Ethernet API".
> After checking the code, Honestly I'm confused. I don't find this description.
It's in the description of rte_eth_dev_configure():
http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.h#n1904
> And on the contrary, I find rte_eth_dev_info_get is always called before
> rte_eth_dev_configure. I believe it's the problem.
> As rte_eth_dev_configure is not run, rte_eth_dev_info_get cannot get the right info.
> That why I have to add a API to set the mq_mode before rte_eth_dev_info_get.
> Does that mean all the related examples are wrong? Any opinion? Thanks.
My opinion is that this area needs a good cleanup and easy API :)
next prev parent reply other threads:[~2016-06-30 7:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 8:24 [dpdk-dev] [PATCH] lib: " Wenzhuo Lu
2016-04-11 9:52 ` Thomas Monjalon
2016-04-12 0:39 ` Lu, Wenzhuo
2016-05-04 21:47 ` [dpdk-dev] [PATCH v2] " Wenzhuo Lu
2016-05-05 21:33 ` [dpdk-dev] [PATCH v3] ethdev: " Wenzhuo Lu
2016-06-17 11:21 ` De Lara Guarch, Pablo
2016-06-22 17:01 ` Thomas Monjalon
2016-06-23 1:04 ` Lu, Wenzhuo
2016-06-23 12:21 ` Thomas Monjalon
2016-06-24 0:45 ` Lu, Wenzhuo
2016-06-30 1:40 ` Lu, Wenzhuo
2016-06-30 7:41 ` Thomas Monjalon [this message]
2016-06-30 8:23 ` Lu, Wenzhuo
2016-06-30 8:47 ` Lu, Wenzhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501713.7uhgKcRiBR@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).