From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 0F0D32C0B for ; Thu, 30 Jun 2016 09:42:03 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id a66so105253054wme.0 for ; Thu, 30 Jun 2016 00:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=PxvNLwW3gCFUsUckOsiSRqE9Vmpu+HMjWIRlT0Sss+E=; b=IZExN3bD/XgOtCfQO2MYX0dXlypwS/zQGHqNNJClb0JQuOBdKb2naO1eHUD6oDwt93 l+xvURQt4DBvnXaKM6YCh+VzZn2fMxhiTz0Yq7rRSptiT/UPjHx4d+b0ZVNcoWIL8wHc oMa4g8z0Vi0gVyDZJoYOta8UqukR96KPxE+M/Kk+95fzwRDEvjuT+nECzSRBAmB9WHEm +IuvYcQ7z7JVOjIwFOJszZxaoFEh0/NEtyIq0cvbpczyJMNewNEaWXVDIU62wzams0FJ 71H+OpEU/UGRpFtqHiLQLIWl9LW3/suBAIkfndoSvuvGOU1PbKwTFeVwU5UhzX45oYRz TAAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=PxvNLwW3gCFUsUckOsiSRqE9Vmpu+HMjWIRlT0Sss+E=; b=CPtzx24uZz4UJbmfQ6nLPR1COcwTAbcoAHqlch96+0hW+diu/60GZNFROGube9w8W7 g+ckXhNnKd/tiCLp+Y9bjkyeeTpy5yLW70Jed7EYlCluvt99ks8jdk4jDQzohnOj9nHf qgW5atnxEzy8jtSUwOWbvFbtqHh0eFKIziJueY9ZT8fuLWbYYqSVgFPCB8xa4jKv9no8 gRLRL5FPdKYZ0Xp0SvurEOvA5idHOOU/jBBlmx3OlXRQXJk5UOucxGN0mzcm4WwOqnfl 1kGgSCT9iYk7ctznEfLT46r52xKSNUDdUP5+9cQvfN+spwzd0t/hks8YYQjW44kHoaCi B/xQ== X-Gm-Message-State: ALyK8tJ4V7xQufQuKewg8DKv4N7tbI0SGFoeNTcYZ2NKch+W2V1SnOP+U2BqRrzq1ezlGy2T X-Received: by 10.194.115.199 with SMTP id jq7mr12184714wjb.162.1467272522805; Thu, 30 Jun 2016 00:42:02 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id l1sm7437164wjy.17.2016.06.30.00.42.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2016 00:42:01 -0700 (PDT) From: Thomas Monjalon To: "Lu, Wenzhuo" Cc: dev@dpdk.org Date: Thu, 30 Jun 2016 09:41:57 +0200 Message-ID: <1501713.7uhgKcRiBR@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090348C059@shsmsx102.ccr.corp.intel.com> References: <1460363050-27962-1-git-send-email-wenzhuo.lu@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090348A2BD@shsmsx102.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090348C059@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ethdev: fix DCB config issue on ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 07:42:03 -0000 2016-06-30 01:40, Lu, Wenzhuo: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2016-06-23 01:04, Lu, Wenzhuo: > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > 2016-05-06 05:33, Wenzhuo Lu: > > > > > > +int > > > > > > +rte_eth_dev_mq_mode_set(uint8_t port_id, > > > > > > + enum rte_eth_rx_mq_mode rx_mq_mode, > > > > > > + enum rte_eth_tx_mq_mode tx_mq_mode); > > > > > > > > > > I've really tried to think about it and I think it is more or less a hack. > > > > > First, it is not explained in the doc when we should use > > > > > rte_eth_dev_mq_mode_set() instead of a simple call to > > > rte_eth_dev_configure(). > > > > > Second, I don't understand why having a function which configures > > > > > the "multiqueue modes" without configuring properly RSS/VMDq/DCB. > > > > > Last, it is said that rte_eth_dev_configure() "must be invoked > > > > > first before any other function in the Ethernet API". > After checking the code, Honestly I'm confused. I don't find this description. It's in the description of rte_eth_dev_configure(): http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.h#n1904 > And on the contrary, I find rte_eth_dev_info_get is always called before > rte_eth_dev_configure. I believe it's the problem. > As rte_eth_dev_configure is not run, rte_eth_dev_info_get cannot get the right info. > That why I have to add a API to set the mq_mode before rte_eth_dev_info_get. > Does that mean all the related examples are wrong? Any opinion? Thanks. My opinion is that this area needs a good cleanup and easy API :)