* [dpdk-dev] [PATCH] timer: remove unnecessary timer add call
@ 2016-07-17 17:35 Hiroyuki Mikita
2016-07-22 22:06 ` Sanford, Robert
0 siblings, 1 reply; 4+ messages in thread
From: Hiroyuki Mikita @ 2016-07-17 17:35 UTC (permalink / raw)
To: rsanford; +Cc: dev
When timer_set_running_state() fails in rte_timer_manage(),
the failed timer is put back on pending-list.
In this case, another core tries to reset or stop the timer.
It does not need to be on pending-list
Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
---
lib/librte_timer/rte_timer.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 3dcdab5..94878d3 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -562,10 +562,9 @@ void rte_timer_manage(void)
pprev = &tim->sl_next[0];
} else {
/* another core is trying to re-config this one,
- * remove it from local expired list and put it
- * back on the priv_timer[] skip list */
+ * remove it from local expired list
+ */
*pprev = next_tim;
- timer_add(tim, lcore_id, 1);
}
}
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] timer: remove unnecessary timer add call
2016-07-17 17:35 [dpdk-dev] [PATCH] timer: remove unnecessary timer add call Hiroyuki Mikita
@ 2016-07-22 22:06 ` Sanford, Robert
2016-07-25 15:15 ` Hiroyuki Mikita
0 siblings, 1 reply; 4+ messages in thread
From: Sanford, Robert @ 2016-07-22 22:06 UTC (permalink / raw)
To: Hiroyuki Mikita, dev, Thomas Monjalon
On 7/17/16 1:35 PM, "Hiroyuki Mikita" <h.mikita89@gmail.com> wrote:
>When timer_set_running_state() fails in rte_timer_manage(),
>the failed timer is put back on pending-list.
>In this case, another core tries to reset or stop the timer.
>It does not need to be on pending-list
>
>Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
>---
> lib/librte_timer/rte_timer.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
>index 3dcdab5..94878d3 100644
>--- a/lib/librte_timer/rte_timer.c
>+++ b/lib/librte_timer/rte_timer.c
>@@ -562,10 +562,9 @@ void rte_timer_manage(void)
> pprev = &tim->sl_next[0];
> } else {
> /* another core is trying to re-config this one,
>- * remove it from local expired list and put it
>- * back on the priv_timer[] skip list */
>+ * remove it from local expired list
>+ */
> *pprev = next_tim;
>- timer_add(tim, lcore_id, 1);
> }
> }
>
>--
>2.7.4
>
Acked-by: Robert Sanford <rsanford@akamai.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] timer: remove unnecessary timer add call
2016-07-22 22:06 ` Sanford, Robert
@ 2016-07-25 15:15 ` Hiroyuki Mikita
2016-07-25 15:50 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Hiroyuki Mikita @ 2016-07-25 15:15 UTC (permalink / raw)
To: Sanford, Robert; +Cc: dev, Thomas Monjalon
Fixes: a4b7a5a45cf5 ("timer: fix race condition")
2016-07-23 7:06 GMT+09:00 Sanford, Robert <rsanford@akamai.com>:
>
>
> On 7/17/16 1:35 PM, "Hiroyuki Mikita" <h.mikita89@gmail.com> wrote:
>
>>When timer_set_running_state() fails in rte_timer_manage(),
>>the failed timer is put back on pending-list.
>>In this case, another core tries to reset or stop the timer.
>>It does not need to be on pending-list
>>
>>Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
>>---
>> lib/librte_timer/rte_timer.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>>diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
>>index 3dcdab5..94878d3 100644
>>--- a/lib/librte_timer/rte_timer.c
>>+++ b/lib/librte_timer/rte_timer.c
>>@@ -562,10 +562,9 @@ void rte_timer_manage(void)
>> pprev = &tim->sl_next[0];
>> } else {
>> /* another core is trying to re-config this one,
>>- * remove it from local expired list and put it
>>- * back on the priv_timer[] skip list */
>>+ * remove it from local expired list
>>+ */
>> *pprev = next_tim;
>>- timer_add(tim, lcore_id, 1);
>> }
>> }
>>
>>--
>>2.7.4
>>
>
> Acked-by: Robert Sanford <rsanford@akamai.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] timer: remove unnecessary timer add call
2016-07-25 15:15 ` Hiroyuki Mikita
@ 2016-07-25 15:50 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2016-07-25 15:50 UTC (permalink / raw)
To: Hiroyuki Mikita; +Cc: Sanford, Robert, dev
2016-07-26 00:15, Hiroyuki Mikita:
> Fixes: a4b7a5a45cf5 ("timer: fix race condition")
> >
> >>When timer_set_running_state() fails in rte_timer_manage(),
> >>the failed timer is put back on pending-list.
> >>In this case, another core tries to reset or stop the timer.
> >>It does not need to be on pending-list
> >>
> >>Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
> >
> > Acked-by: Robert Sanford <rsanford@akamai.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-25 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-17 17:35 [dpdk-dev] [PATCH] timer: remove unnecessary timer add call Hiroyuki Mikita
2016-07-22 22:06 ` Sanford, Robert
2016-07-25 15:15 ` Hiroyuki Mikita
2016-07-25 15:50 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).