* [dpdk-dev] [PATCH] buildtools: filter out symbols for ICC
@ 2019-07-02 12:13 David Marchand
2019-07-02 12:59 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2019-07-02 12:13 UTC (permalink / raw)
To: dev; +Cc: thomas, ferruh.yigit, nhorman
For some reason, ICC creates additional global symbols with a . which
triggers an error in the check that validates that symbols in the
experimental section are properly published in the map file of the
library. Filter them out.
Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols")
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
buildtools/check-experimental-syms.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
index 653756e..0f6c62d 100755
--- a/buildtools/check-experimental-syms.sh
+++ b/buildtools/check-experimental-syms.sh
@@ -36,8 +36,9 @@ do
fi
done
+# Filter out symbols suffixed with a . for icc
for SYM in `objdump -t $OBJFILE |awk '{
- if ($2 != "l" && $4 == ".text.experimental") {
+ if ($2 != "l" && $4 == ".text.experimental" && !($NF ~ /\.$/)) {
print $NF
}
}'`
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] buildtools: filter out symbols for ICC
2019-07-02 12:13 [dpdk-dev] [PATCH] buildtools: filter out symbols for ICC David Marchand
@ 2019-07-02 12:59 ` Ferruh Yigit
2019-07-02 14:07 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2019-07-02 12:59 UTC (permalink / raw)
To: David Marchand, dev; +Cc: thomas, nhorman
On 7/2/2019 1:13 PM, David Marchand wrote:
> For some reason, ICC creates additional global symbols with a . which
> triggers an error in the check that validates that symbols in the
> experimental section are properly published in the map file of the
> library. Filter them out.
>
> Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] buildtools: filter out symbols for ICC
2019-07-02 12:59 ` Ferruh Yigit
@ 2019-07-02 14:07 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-07-02 14:07 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Ferruh Yigit, nhorman
02/07/2019 14:59, Ferruh Yigit:
> On 7/2/2019 1:13 PM, David Marchand wrote:
> > For some reason, ICC creates additional global symbols with a . which
> > triggers an error in the check that validates that symbols in the
> > experimental section are properly published in the map file of the
> > library. Filter them out.
> >
> > Fixes: 3290ac14eb94 ("buildtools: detect discrepancies for experimental symbols")
> >
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-02 14:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-02 12:13 [dpdk-dev] [PATCH] buildtools: filter out symbols for ICC David Marchand
2019-07-02 12:59 ` Ferruh Yigit
2019-07-02 14:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).