From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
Vipin Varghese <vipin.varghese@amd.com>,
David Marchand <david.marchand@redhat.com>
Cc: stable@dpdk.org, kevin.laatz@intel.com,
bruce.richardson@intel.com, dev@dpdk.org, Ferruh.Yigit@amd.com,
stable@dpdk.org
Subject: Re: [PATCH] dma/skeleton: fix pthread set affinity
Date: Tue, 17 Oct 2023 10:59:08 +0200 [thread overview]
Message-ID: <15024174.JCcGWNJJiE@thomas> (raw)
In-Reply-To: <CAJFAV8wbA6P6RxpUAjxz68WoXkTGkdur7npbacaGA4nVOSzyoQ@mail.gmail.com>
15/08/2023 14:21, David Marchand:
> On Mon, Aug 14, 2023 at 6:24 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > On Sat, Aug 12, 2023 at 07:27:38AM +0530, Vipin Varghese wrote:
> > > In skeleton dma driver, the user can pin the dma thread to desired
> > > cpu core. The previous commit changed the api from set-affinity to
> > > get-affinity leading to thread to be pinned to first available lcore.
> > >
> > > Bugzilla ID: 1270
> > > Fixes: 7fdf30d8b259 ("eal/windows: remove most pthread lifetime shim functions")
>
> This Fixes: looks wrong.
>
> I would blame (and blame the bad reviewers):
> Fixes: f241553b43ee ("dma/skeleton: drop some pthread API calls")
>
> Can you double check?
I agree with the root cause pointed by David.
Applied, thanks.
prev parent reply other threads:[~2023-10-17 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 1:57 Vipin Varghese
2023-08-14 16:24 ` Tyler Retzlaff
2023-08-15 12:21 ` David Marchand
2023-10-17 8:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15024174.JCcGWNJJiE@thomas \
--to=thomas@monjalon.net \
--cc=Ferruh.Yigit@amd.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=vipin.varghese@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).