From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15EA44318A; Tue, 17 Oct 2023 10:59:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4A87427E1; Tue, 17 Oct 2023 10:59:13 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id CFE1940269; Tue, 17 Oct 2023 10:59:12 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2BCE13200AA6; Tue, 17 Oct 2023 04:59:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 17 Oct 2023 04:59:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1697533150; x=1697619550; bh=8QIBIZERGLGZZqo9C77HJgMJzhyU9ZjC6XK d4Hg4OZI=; b=U8u4KbTTqVbOBtk6I8CeYoQZOJ6GJ4Yx+WGNByT2hJlTxPPMpic Zp8KJidecVs4RF7GMawKX10U3bLxI523qQKOjpZ/9OxYzTaDj93aGcG0NfEx9PmU ZZY2fpZUO3J6vJ8lh0kJsAk6FVEUCDHogTC79CeVQQMRBi3URleK8Q5dTHRO9/CJ E6igpD4qwgDga2hFxWSH2dy1EgYZCcxfAwetOtC+cOF4gndQ6EOuMCwuRv92Ydu1 sxB5tUI6JgPSwEYe+m6atdeFZe9rO6v24HqyhqfdIJ/B6Ig+HIr3h3mAXgQPViGw 0GvQg7h5RijbOBApUskS/kqvRRYN5ZPnbKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697533150; x=1697619550; bh=8QIBIZERGLGZZqo9C77HJgMJzhyU9ZjC6XK d4Hg4OZI=; b=TEIF2M16R6Vvaq0PUlcjlNckc87HqeCP7R7mwhH87HQsp/lBP8x IyYn7PNPnAxNDaalEKypTrG1FDjLcr0FrXUPlGm0ZScjZCVpsRMjl8GpxUfblRUG 20H99iQwFaAIpzu1bpUcIhviQ6TAuc6ACndwHHAkidzRyFYqa0vRRDf0iyiakEhU 7KwDHetjTF1gv6nkGVIu0IWhmqFDyhwgtTnygFhggc1ydThuaU62NiFcuhGAp26U PJvgjTcPR808WisV5E9bHMtt9Kny2ong3oFdcomKzJvjMZY/1N7zK7arIknFpQui J6KHAJEwQBnJWb24ElBDzsHcFXYev5KXhMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjedvgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Oct 2023 04:59:09 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff , Vipin Varghese , David Marchand Cc: stable@dpdk.org, kevin.laatz@intel.com, bruce.richardson@intel.com, dev@dpdk.org, Ferruh.Yigit@amd.com, stable@dpdk.org Subject: Re: [PATCH] dma/skeleton: fix pthread set affinity Date: Tue, 17 Oct 2023 10:59:08 +0200 Message-ID: <15024174.JCcGWNJJiE@thomas> In-Reply-To: References: <20230812015738.1024-1-vipin.varghese@amd.com> <20230814162431.GA12422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/08/2023 14:21, David Marchand: > On Mon, Aug 14, 2023 at 6:24=E2=80=AFPM Tyler Retzlaff > wrote: > > > > On Sat, Aug 12, 2023 at 07:27:38AM +0530, Vipin Varghese wrote: > > > In skeleton dma driver, the user can pin the dma thread to desired > > > cpu core. The previous commit changed the api from set-affinity to > > > get-affinity leading to thread to be pinned to first available lcore. > > > > > > Bugzilla ID: 1270 > > > Fixes: 7fdf30d8b259 ("eal/windows: remove most pthread lifetime shim = functions") >=20 > This Fixes: looks wrong. >=20 > I would blame (and blame the bad reviewers): > Fixes: f241553b43ee ("dma/skeleton: drop some pthread API calls") >=20 > Can you double check? I agree with the root cause pointed by David. Applied, thanks.