From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 3E2675699 for ; Fri, 11 Aug 2017 14:43:07 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id r77so6381379wmd.2 for ; Fri, 11 Aug 2017 05:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:mime-version; bh=A5sx5y5avlESLE5ATj8i/GGX1+JNTw8dDziWaTcBthI=; b=g+DPlbE5p26kdK3MGDWNaFFrxyAcQkxCzs7/G0Z8Bt+D7xnHZBPjG7WA8KOEf/D7RU U8lGc2ZCMO3/pD/okFORvQqmghFscTpEPOI04+ddg3s4cT/C80k0dt5ruUgTuVHTLvzq E931tvt2QFd9blyeocEY49MqGJHS7dk2CTREh2Q1377hYlR6t9RgpbAJ+2u85Ep2U+Qx a3u2Pe3b10Dpb3Tw068wgKHEcX1QXlxfGuMoEzme229oEbOx7sjcyaWN6faV+l4jvhMY dMfkbDjQFyXhbN/RI+WBSXPOAY9+0EQrShuHEiVIlX2lpRC8zZabmluRNJx/FPJ2bM88 G6bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=A5sx5y5avlESLE5ATj8i/GGX1+JNTw8dDziWaTcBthI=; b=Qzgknw7nhj3aSCQ/j2HG8d4icWb84CRgy24DOuxu71nR2MCKXfMRUVchai1LiF+ZHo PpiZ9xTmKXLvhjwi3LRUVcLt02DkWf63Enf+/k7ITLvDrom3PcJHQVrhswLMdgcI8ocK EcGGihpssx/QyBgsuVf1m0onq9Yjft+q7+jZLsun4w+uWeqTB/kKzUofHF+TuLYaZqvT UDIuIKs1dGZ6ryvXq4oR75rMVXCIe8BFn9Bw3cWWXfNMDTBV25QwsNIcFmwyZkhn7z8C le261mBfVT7wvrrCyqqM2gaVJ9g+3vjCltmODK7nR84BuYfwAYdJCBRIFMXD1uUzDlts fpUA== X-Gm-Message-State: AHYfb5gOe/jYzQe2P+Mk0/x4f9oIOzx7/gg9nyVM/us/SxN9crQ/daef iEPCF19mqg8ajw== X-Received: by 10.28.95.69 with SMTP id t66mr11968385wmb.74.1502455386965; Fri, 11 Aug 2017 05:43:06 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id n22sm979718wra.30.2017.08.11.05.43.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Aug 2017 05:43:06 -0700 (PDT) Message-ID: <1502455385.31114.2.camel@gmail.com> From: Luca Boccassi To: Bruce Richardson , Stephen Hemminger Cc: dev@dpdk.org Date: Fri, 11 Aug 2017 13:43:05 +0100 In-Reply-To: <20170628160409.GA7876@bricha3-MOBL3.ger.corp.intel.com> References: <20170623184153.24488-1-lboccass@brocade.com> <20170628135702.18150-1-lboccass@brocade.com> <20170628085733.10153207@xeon-e3> <20170628160409.GA7876@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 0/6] Reproducible build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Aug 2017 12:43:07 -0000 On Wed, 2017-06-28 at 17:04 +0100, Bruce Richardson wrote: > On Wed, Jun 28, 2017 at 08:57:33AM -0700, Stephen Hemminger wrote: > > On Wed, 28 Jun 2017 14:56:56 +0100 > > wrote: > >=20 > > > From: Luca Boccassi > > >=20 > > > In the past couple of years a concerted effort among almost all > > > Linux > > > distros has been striving toward achieving reproducible builds. > > > [1] > > > This involves changes to the toolchain, new tools and CI systems. > > > [2] > > >=20 > > > v1 fixed the documentation, examples and linker script > > > generation. > > > v2 fixes all problems, which were caused by unstable order of > > > headers > > > inclusion, source files listing and object file listing when > > > passing > > > them to the compiler. > > > DPDK's build, at least with the default configuration, is fully > > > reproducible with this patch series as tested by the Reproducible > > > Builds developers experimental toolchain. [3] > > >=20 > > > v3 restores the first patch, which was eaten by git send-email. > > >=20 > > > v4 drops the patch that reorders rebuilds, and adds a patch to > > > make > > > the inclusion of headers deterministic with regards to GCC > > > embedding > > > the full file path when expading __FILE__ and when writing the > > > directory listing in the DWARF objects. > > > It also drops the first 2 patches which have already been merged. > > >=20 > > > [1] https://reproducible-builds.org/ > > > [2] https://reproducible-builds.org/tools/ > > > [3] https://wiki.debian.org/ReproducibleBuilds/ExperimentalToolch > > > ain#Us > >=20 > > Looks good. > >=20 > > Looking ahead, how does this work with the proposed new build > > system? > > Is there an automated way to check new submissions so that new > > features > > don't undo this. > >=20 > >=20 > > Acked-by: Stephen Hemminger >=20 > http://mesonbuild.com/Reproducible-builds.html >=20 > I'd hope if we switch build system, this shouldn't be a problem. It's > definitely something to watch out for. >=20 > /Bruce The one issue to look for, with the current build system, is the CFLAGS include path order (the last patch) in the makefiles under lib/ The pattern seems to be always the same, would it be possible & acceptable to add a check in checkpatch? bad: CFLAGS +=3D -I$(SRCDIR) good: CFLAGS :=3D -I$(SRCDIR) $(CFLAGS) --=20 Kind regards, Luca Boccassi