From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 11/16] nfp: allocate eth_dev from pf probe function
Date: Thu, 24 Aug 2017 17:20:17 +0100 [thread overview]
Message-ID: <1503591622-16232-12-git-send-email-alejandro.lucero@netronome.com> (raw)
In-Reply-To: <1503591622-16232-1-git-send-email-alejandro.lucero@netronome.com>
NFP can support several physical ports per PF device. Depending on
firmware info, one or more eth_dev objects will need to be created.
This patch adds the call to create just one eth_dev by now with future
commits supporting the multiport option. Once the eth_dev has been
created, probe function invokes pmd initialization with the new eth_dev.
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 50 +++++++++++++++++++++++++++++++++++++++--------
1 file changed, 42 insertions(+), 8 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 7c23b7a..6005e41 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2677,13 +2677,16 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq)
static int nfp_pf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
struct rte_pci_device *dev)
{
+ struct rte_eth_dev *eth_dev;
+ struct nfp_net_hw *hw;
nfpu_desc_t *nfpu_desc;
nspu_desc_t *nspu_desc;
uint64_t offset_symbol;
int major, minor;
+ int ret = -ENODEV;
if (!dev)
- return -ENODEV;
+ return ret;
nfpu_desc = rte_malloc("nfp nfpu", sizeof(nfpu_desc_t), 0);
if (!nfpu_desc)
@@ -2697,29 +2700,60 @@ static int nfp_pf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
nspu_desc = nfpu_desc->nspu;
-
/* Check NSP ABI version */
if (nfp_nsp_get_abi_version(nspu_desc, &major, &minor) < 0) {
RTE_LOG(INFO, PMD, "NFP NSP not present\n");
- goto no_abi;
+ goto error;
}
PMD_INIT_LOG(INFO, "nspu ABI version: %d.%d\n", major, minor);
if (minor < 20) {
RTE_LOG(INFO, PMD, "NFP NSP ABI version too old. Required 0.20 or higher\n");
- goto no_abi;
+ goto error;
}
- nfp_nsp_fw_setup(nspu_desc, "nfd_cfg_pf0_num_ports", &offset_symbol);
+ ret = nfp_nsp_fw_setup(nspu_desc, "nfd_cfg_pf0_num_ports",
+ &offset_symbol);
+ if (ret)
+ goto error;
- /* No port is created yet */
+ eth_dev = rte_eth_dev_allocate(dev->device.name);
+ if (!eth_dev) {
+ ret = -ENODEV;
+ goto error;
+ }
-no_abi:
+ eth_dev->data->dev_private = rte_zmalloc("nfp_pf_port",
+ sizeof(struct nfp_net_adapter),
+ RTE_CACHE_LINE_SIZE);
+ if (!eth_dev->data->dev_private) {
+ rte_eth_dev_release_port(eth_dev);
+ ret = -ENODEV;
+ goto error;
+ }
+
+ hw = (struct nfp_net_hw *)(eth_dev->data->dev_private);
+ hw->nspu_desc = nspu_desc;
+ hw->nfpu_desc = nfpu_desc;
+ hw->is_pf = 1;
+
+ eth_dev->device = &dev->device;
+ rte_eth_copy_pci_info(eth_dev, dev);
+
+ ret = nfp_net_init(eth_dev);
+
+ if (!ret)
+ return 0;
+
+ /* something went wrong */
+ rte_eth_dev_release_port(eth_dev);
+
+error:
nfpu_close(nfpu_desc);
nfpu_error:
rte_free(nfpu_desc);
- return -ENODEV;
+ return ret;
}
static const struct rte_pci_id pci_id_nfp_pf_net_map[] = {
--
1.9.1
next prev parent reply other threads:[~2017-08-24 16:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 16:20 [dpdk-dev] [PATCH 00/16] nfp: add pf support Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 01/16] nfp: add nsp user space interface Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 02/16] nfp: add specific pf probe function Alejandro Lucero
2017-08-28 16:42 ` Ferruh Yigit
2017-08-31 9:23 ` Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 03/16] nfp: add support for new pci id Alejandro Lucero
2017-08-28 16:43 ` Ferruh Yigit
2017-08-31 9:08 ` Alejandro Lucero
2017-08-31 9:13 ` Ferruh Yigit
2017-08-31 9:24 ` Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 04/16] nfp: add nsp support for commands Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 05/16] nfp: add nsp fw upload command Alejandro Lucero
2017-08-28 16:42 ` Ferruh Yigit
2017-08-31 9:04 ` Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 06/16] nfp: add nsp symbol resolution command Alejandro Lucero
2017-08-28 16:42 ` Ferruh Yigit
2017-08-31 9:35 ` Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 07/16] nfp: add fw upload logic Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 08/16] nfp: add support for vnic config bar mapping Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 09/16] nfp: add support for vNIC rx/tx bar mappings Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 10/16] nfp: support pf devices inside pmd initialization Alejandro Lucero
2017-08-24 16:20 ` Alejandro Lucero [this message]
2017-08-24 16:20 ` [dpdk-dev] [PATCH 12/16] nfp: support pf multiport Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 13/16] nfp: add nsp support for hw link configuration Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 14/16] nfp: add support for hw port " Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 15/16] nfp: read pf port mac addr using nsp Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 16/16] doc: update nfp with pf support information Alejandro Lucero
2017-08-28 16:42 ` [dpdk-dev] [PATCH 00/16] nfp: add pf support Ferruh Yigit
2017-08-31 9:00 ` Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503591622-16232-12-git-send-email-alejandro.lucero@netronome.com \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).