From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9AC4A7D1C for ; Fri, 25 Aug 2017 22:25:59 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Aug 2017 13:25:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,426,1498546800"; d="scan'208";a="304486250" Received: from wcpqa1.an.intel.com ([10.123.72.207]) by fmsmga004.fm.intel.com with ESMTP; 25 Aug 2017 13:25:58 -0700 From: Gabriel Carrillo To: rsanford@akamai.com Cc: dev@dpdk.org Date: Fri, 25 Aug 2017 15:26:23 -0500 Message-Id: <1503692783-16148-1-git-send-email-erik.g.carrillo@intel.com> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1503499644-29432-1-git-send-email-erik.g.carrillo@intel.com> References: <1503499644-29432-1-git-send-email-erik.g.carrillo@intel.com> Subject: [dpdk-dev] [PATCH v2 0/3] *** timer library enhancements *** X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 20:26:01 -0000 In the current implementation of the DPDK timer library, timers can be created and set to be handled by a target lcore by adding it to a skiplist that corresponds to that lcore. However, if an application enables multiple lcores, and each of these lcores repeatedly attempts to install timers on the same target lcore, overall application throughput will be reduced as all lcores contend to acquire the lock guarding the single skiplist of pending timers. This patchset addresses this scenario by adding an array of skiplists to each lcore's priv_timer struct, such that when lcore i installs a timer on lcore k, the timer will be added to the ith skiplist for lcore k. If lcore j installs a timer on lcore k simultaneously, lcores i and j can both proceed since they will be acquiring different locks for different lists. When lcore k processes its pending timers, it will traverse each skiplist in its array and acquire a skiplist's lock while a run list is broken out; meanwhile, all other lists can continue to be modified. Then, all run lists for lcore k are collected and traversed together so timers are executed in their relative order. Gabriel Carrillo (3): timer: add per-installer pending lists for each lcore timer: handle timers installed from non-EAL threads doc: update timer lib docs doc/guides/prog_guide/timer_lib.rst | 19 ++- lib/librte_timer/rte_timer.c | 329 +++++++++++++++++++++++------------- lib/librte_timer/rte_timer.h | 9 +- 3 files changed, 231 insertions(+), 126 deletions(-) -- 2.6.4