From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50081.outbound.protection.outlook.com [40.107.5.81]) by dpdk.org (Postfix) with ESMTP id 1B39E3989 for ; Wed, 6 Sep 2017 17:04:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=roiKE36f/KuV0u0neOES9P4zNAiG5kK4nXxS7MJLLOQ=; b=BsXsxMFFD+V1t32tIs9H/9u923Gasn55MFdbhRMUHZEvmT+SaRYmex2rVQz1ssQ15O00gfBH6ctjWT3owEFKTC2I9R/xCrXmgrYFaT6SZOFaV5u/4ieMURV0Ux1mg67yZ645rT6sLS4/x590lYpkDOD4QLz8dCPR6OPXUXmH6+M= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB6PR0502MB3048.eurprd05.prod.outlook.com (2603:10a6:4:9f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Wed, 6 Sep 2017 15:04:13 +0000 From: Matan Azrad To: Nelio Laranjeiro , Adrien Mazarguil Cc: dev@dpdk.org Date: Wed, 6 Sep 2017 18:03:58 +0300 Message-Id: <1504710238-25726-2-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504710238-25726-1-git-send-email-matan@mellanox.com> References: <1504710238-25726-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: DB6PR0201CA0017.eurprd02.prod.outlook.com (2603:10a6:4:3f::27) To DB6PR0502MB3048.eurprd05.prod.outlook.com (2603:10a6:4:9f::8) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8634d2ac-73f9-4b2c-2cd8-08d4f53889ce X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0502MB3048; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 3:ZlEZpKoS1m1RkE+sURFVHXsaF859FH69bRLYKtGmv4dyBhYZq+XgN8tW3Tbk2ov7xFqK863U1ZJESUVvQM+1MJNcFbAujtCZCihSdeFTKvETA4S6OdwoPI2a3/Lsm18kPYFvdkU2bvEjKNy2vPgMohcrmmMV6mBHfeMqnUFr+mf4kWNE3HynC1IXtv3TAEX1g3OSKoDIyEkU1lOwZ6F5aJbSoArKxvDF3wKEBI364uSPVB5GnZquOXuafXQH9aEj; 25:kWioROa44XToHqxWIvwUIWOsICW9xsal5iPrwATI488YPXRwVN4ctKFUwsMT0WPVl690QX8zJixCE970/iuuEpkta6iuuCzBENp2z8MGFsWeqTNA0ZPBDwLJs1GEx5VaRCMpG2BVl51e55qv3ShYZmAZ92zGe+XTiCodUdQeDL2mcPL/o013PKLHa3tv2/x8KhWfFFokTEcsQvort3t05fEntRTPQhSOnLjHNDw8QnILj0CGGoe8/MV22bhnF0GxEpbhL+3hr+eP7XPI0A/goYeS1Cs8IuM1dQMmSJnYe1PrS43kGd9MtxnHSL1PEU+FKTdtJqLMvF8yB33TGgSvOQ==; 31:B7zS66I0GCE0G7XfsD603ocjfKOQykkYMnzy4VUOPtN042q+1q0o4/Ajjx9fA5rneQX2RrcLxhWPtNOydNIN712eOUN5DOy1RJcvsqwK/eFxSpBq1ZSmnbwIN31utqFn/f2TmusTJLm1gKVBW1P/cDcxOYuA6gLUSqgJelW55GLXVArZXOcm4GoXFklIvksBRezI0ItSn2RGRwaS/uvVLWYtcaNWowvj8WdxtS/f0nY= X-MS-TrafficTypeDiagnostic: DB6PR0502MB3048: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 20:2jl7isKOBi3xN7Ei3n7bhrbD+nHxXpktbkZi2f4ZZT8PXiM/4yjrTLvjre2RzXWuXXAqr5i6NAm5w35aBPxrrxWaQYwcHni14DWI7TcJStm5eTY9nhpgQ1xDmn0fvfREkKJyBuoWAKgr69q+ngNcSNLmPTUs38RJU0frcS6+2e1G4tB6pNSWn/U/1aIv+8A4w4K0WZtaefPyWL/f5CQ+Ce7FTytzGOuxmKZOnRUrt/tSAfKLjdT77C+Xdu97WuJpxBnLTq0sG88nqKJtQZV8+HSbxcoO+IiaMUlXBDuM92fSCihChVm6rskfIHvw3QaolEufqmple95JUqOn3UZ4IpM8YFkwn9BIvdb2xhOHh66sfOaw+1//L0nzrsEjeoz5M67XR8V42KKN2cabswELb8XPRwwkqTcS1Q09nUy2niOOCSI76fdA1yuvDBW9h7yCHqzQLdlgq3E0JHxaiQQFq+QJVcU+bDeTC6ZzICrp0Q1XbCSOcF+GZGNQdvlMyEw9; 4:a4BoykxCAmsIm5pgHHY9P4imhTZFx5O7Xh2pDVXX9waN+b6o5d6K/y27cJWF2tCQ34zxSypcetRHr5jTde3W8XpScDFxPWYkUi5OZXRFH2v12G5A7OJZrTKI1Iycu37A9fgdjjuDb9ZCtaxS4QJJN1Vzg7+wgp4V9L9LyIi95MZPve4fev0XPW4ZOqYT8+REaJfAQFwO2zj/sDhESgF0ZVZscK3bk1EkNRtPHrh1cIA2W7vB783xLBVF6QQzwNc/ X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0502MB3048; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0502MB3048; X-Forefront-PRVS: 0422860ED4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(39860400002)(199003)(189002)(55016002)(47776003)(53936002)(478600001)(81166006)(81156014)(8676002)(105586002)(5003940100001)(25786009)(4326008)(86362001)(68736007)(21086003)(33646002)(50226002)(33026002)(6116002)(97736004)(189998001)(5660300001)(3846002)(50986999)(76176999)(7736002)(6666003)(2950100002)(48376002)(305945005)(106356001)(50466002)(36756003)(69596002)(2906002)(42186005)(66066001)(7350300001)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0502MB3048; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0502MB3048; 23:0Jyko6aTuupgLh8q6AsvgNesSU1JBB8PHmZUZVh?= =?us-ascii?Q?GcPUbQa6zSWQG0ZNEsYmBg9hoX4e268/EonYxot8K/QmrDBBxubV89a+p9vj?= =?us-ascii?Q?i7Arn1JekCwSdTzVMqaZjWvMth9pfZ2+Aqqs63fnruhT+M1nzOseVpfeMN1h?= =?us-ascii?Q?ss0Mem/iupIkzjeJEiQM2Qi8bV+EyIC3NMdtCQ+EjrnKAAusAy21G44lI5hu?= =?us-ascii?Q?EiXe1JYx7bxq1Fks40xq5ScJi+EJ7qKfYoBrVbYkCFWKxJHV6xWeer7LNH/O?= =?us-ascii?Q?KKJv69L0oD2tUKRiehxFI1Cu5fAl3nCy6VJmVtckl+gX2dy6UojWi9ZZEdPe?= =?us-ascii?Q?aV3qB6ypD5G91MnBttd8wE1MfiAVSqxbOKCW+cM0ztJt7i5zQc+RrLTMhC6/?= =?us-ascii?Q?Vm3J/k3sw7JY9PDAUY85AOEnMzOcLQhjMlo/icmP2iBe6sQ3roQjBCxSryik?= =?us-ascii?Q?ns++jua/2MrxyP6Zsyh2hcAD+cuNp+MZdT5Y9W1xbCriEeBIdKFFtVDmZBbg?= =?us-ascii?Q?MHNrKdJUhBZLP2W94KzpX0SGe15ETyDjBuEcU+qsv8X6y4XPLECfjZKeV3aa?= =?us-ascii?Q?nrO/L2dta6qR+JIUqSL7tp3LiQuXJq4RZ2YbPkbGr5EmahzI0BPPxRkLNtPU?= =?us-ascii?Q?LtIffgofvsUOiRKjaBKZNKgUmGry5sIe13sRwe9CNBkg54koihogGP34gy7J?= =?us-ascii?Q?2P430RCEzT6ezgk96+ga6J4ne+jkETfALMiTIqlj3U3U+Eu8rV1KX5DW3kYh?= =?us-ascii?Q?tuseOoqYqOpgNSDv/hxw81qcw8f86Wci6CSIo52tBOt+wKM+mVrjxByoAQoW?= =?us-ascii?Q?nLObKcBttbGOhCLi33nSsb6x0N/IzgSfXTDD8YDRN3yv1yZBetoW9W4JR8gK?= =?us-ascii?Q?hUCQqmyyn9SuCkEOPm/Cj7onAl3+q5y/XUK38SR8uHc9oinNwDPcSvhPB+C6?= =?us-ascii?Q?F+cJOsOh4nl6uIE+7uw7U/diqBwmftEuFwp8yU/irnm3IyuEh9kvhDCWhQIq?= =?us-ascii?Q?eCf8wVje7g+9kjXuKQUSAvdlaiT4OZeh75jf90NqpxuikBV0QgQeT+pZhSX3?= =?us-ascii?Q?0RrsxgnrYzylvGHiQpDbt88REu2WEXErEfLsN3qoOQ8zYUuzM9g=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0502MB3048; 6:THrUJCujhcyUEv3gEeQlHRoNG+5O1PlYSBm0gU8RiI6yTYhp7EB8Jlmfy+dWAyrEjKt+1IQ4Pdu+9UQbk0RHd7HJ4seTscl57FStultLjritMqF4cfziOo143IIt+tVeLjyOtXPozv3oOtx3C+lr1QpfNdwBI2aHMQ5zHk63744/Njf2s14l+zCHYzD+65xHaAfdHgsRgETpkFbFwacP/rhpm1lhnhS1XQypU9aA40MumMJZN1Ar2x8ShiK0m7S1kfW7SmgLnPrxc2iueM64V4A5Rc8dN5Gvk/0nergdxrUwDRyjujH6mb2fiuuLZAi34NllQ9kckJKb+hZkKe03eQ==; 5:03ye9YJ/iBRtJnmLZ9/HNIT7IHoKojPS+PeYnb7mQnr9+70v7GmjiYwaOtEN4L419V0Tk9sBRi6q5N137GCvVVgK/U8UNE/P+bKSeYSmOSYvdy6mvw9S0A9lEgCKS7X6y90qP3VQySKgnqGBEtj/TQ==; 24:wfwbNmZiaWy5A24wkImLBNwisjKjWFAUDTPNL/5Fy9fiV82CHaY03vbdwq3xTFxlLE+9x3wx9Xh/3YHTZjsY4WU+HsFPQ4rt/SiJLOx7M9A=; 7:nLcapVsy0L+VYZya5kUNc5742558CKOflSy7JMzDXn+2SC0uOkWolrnQQJTFxSEeVn525lLUSIrFeS0G+sgXBNIZc5MlCPp1uDXHCbjKVqrhGV7RTew/9HflDjD+cAOuypSL0Ctb8VTb0eiNmphWu5sU+DyaAGg/2eXW9UBvbegHm3DhfD6H6wXlvBDqQ2VEh+mQBat4V2XNhbhfFNOZH9bC/uyc52nCdjL2J4i7wIo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2017 15:04:13.9265 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0502MB3048 Subject: [dpdk-dev] [PATCH v4 2/2] net/mlx5: support device removal event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 15:04:16 -0000 Extend the LSC event handling to support the device removal as well. The mlx5 event handling has been made capable of receiving and signaling several event types at once. This support includes next: 1. Removal event detection according to the user configuration. 2. Calling to all registered mlx5 removal callbacks. 3. Capabilities extension to include removal interrupt handling. Signed-off-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5_ethdev.c | 13 +++++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 32081a4..99a2fb3 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -870,7 +870,7 @@ static struct rte_pci_driver mlx5_driver = { }, .id_table = mlx5_pci_id_map, .probe = mlx5_pci_probe, - .drv_flags = RTE_PCI_DRV_INTR_LSC, + .drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV, }; /** diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 64a8db8..b57de4b 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -1172,6 +1172,9 @@ priv_dev_status_handler(struct priv *priv) event.event_type == IBV_EVENT_PORT_ERR) && (priv->dev->data->dev_conf.intr_conf.lsc == 1)) ret |= (1 << RTE_ETH_EVENT_INTR_LSC); + else if (event.event_type == IBV_EVENT_DEVICE_FATAL && + priv->dev->data->dev_conf.intr_conf.rmv == 1) + ret |= (1 << RTE_ETH_EVENT_INTR_RMV); else DEBUG("event type %d on port %d not handled", event.event_type, event.element.port_num); @@ -1227,6 +1230,9 @@ mlx5_dev_interrupt_handler(void *cb_arg) if (events & (1 << RTE_ETH_EVENT_INTR_LSC)) _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL, NULL); + if (events & (1 << RTE_ETH_EVENT_INTR_RMV)) + _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_RMV, NULL, + NULL); } /** @@ -1240,7 +1246,8 @@ mlx5_dev_interrupt_handler(void *cb_arg) void priv_dev_interrupt_handler_uninstall(struct priv *priv, struct rte_eth_dev *dev) { - if (!dev->data->dev_conf.intr_conf.lsc) + if (!dev->data->dev_conf.intr_conf.lsc && + !dev->data->dev_conf.intr_conf.rmv) return; rte_intr_callback_unregister(&priv->intr_handle, mlx5_dev_interrupt_handler, @@ -1265,7 +1272,8 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev) { int rc, flags; - if (!dev->data->dev_conf.intr_conf.lsc) + if (!dev->data->dev_conf.intr_conf.lsc && + !dev->data->dev_conf.intr_conf.rmv) return; assert(priv->ctx->async_fd > 0); flags = fcntl(priv->ctx->async_fd, F_GETFL); @@ -1273,6 +1281,7 @@ priv_dev_interrupt_handler_install(struct priv *priv, struct rte_eth_dev *dev) if (rc < 0) { INFO("failed to change file descriptor async event queue"); dev->data->dev_conf.intr_conf.lsc = 0; + dev->data->dev_conf.intr_conf.rmv = 0; } else { priv->intr_handle.fd = priv->ctx->async_fd; priv->intr_handle.type = RTE_INTR_HANDLE_EXT; -- 2.7.4