From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id AA06F7F58 for ; Mon, 1 Dec 2014 11:54:03 +0100 (CET) Received: by mail-wi0-f170.google.com with SMTP id bs8so26166755wib.3 for ; Mon, 01 Dec 2014 02:54:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=G7KM/RM2HHCzC0PjYuo5x5pDAKqLm8+0pS5jTZZFo/Q=; b=j0PkLE59YX2TuWyZrSLjwg+HsUPKA/Xencf6nPsSnHdCd/qv7UW0fXZ1CyvcV0A2jk EleZwnSOEWAVAz/3TCkSQwzIoZj3UMmqoQt7sirs951MaXYx5ntGbV/p82FutxCJ70T0 GwgzmDrhqmgqbmHPH3iowjUrpoo+MmbwcM8BWUc0Xb6Ks3lwDzbtJJKyNPHlpa/aN0in 3KapB9NPJKPfbw3D4UixrhqChekCGq8RnSvzYDT4VPu0VucLDeuvJIL/II/pAxH8z+ft PHzLQ7tyvTfsm+IcFcx+WFx19gOJD2wCvxcNbDxjbsGOn5wGzeV757HfqlF6lArMW/Pe Y8Rg== X-Gm-Message-State: ALoCoQkFxBjHRNOIwxT3YU60o2TAeQfcW2z55iuyr7Y5LYNvtKEKgCkdPU9IPaGPp5wMCzuLHudd X-Received: by 10.194.59.166 with SMTP id a6mr30055364wjr.49.1417431243578; Mon, 01 Dec 2014 02:54:03 -0800 (PST) Received: from xps13.localnet (191.16.90.92.rev.sfr.net. [92.90.16.191]) by mx.google.com with ESMTPSA id wv8sm26901030wjc.44.2014.12.01.02.54.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Dec 2014 02:54:02 -0800 (PST) From: Thomas Monjalon To: "Gonzalez Monroy, Sergio" Date: Mon, 01 Dec 2014 11:35:05 +0100 Message-ID: <1505529.uMfnAuRVUN@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B004EF7321@IRSMSX108.ger.corp.intel.com> References: <1414078604-1090-1-git-send-email-sergio.gonzalez.monroy@intel.com> <6592533.mQvpkUAhuR@xps13> <91383E96CE459D47BCE92EFBF5CE73B004EF7321@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix app linking for combined libs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Dec 2014 10:54:03 -0000 2014-12-01 09:57, Gonzalez Monroy, Sergio: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2014-10-23 16:36, Sergio Gonzalez Monroy: > > > Building combined shared libraries results in applications being > > > linked against separeted/individual and combined libs altogether. > > > > > > Link only against combined lib when the config option is enabled. > > > > > > Signed-off-by: Sergio Gonzalez Monroy > > [...] > > > --- a/mk/rte.app.mk > > > +++ b/mk/rte.app.mk > > > @@ -217,6 +217,12 @@ endif > > > > > > endif # plugins > > > > > > +ifeq ($(RTE_BUILD_COMBINE_LIBS),y) > > > +LDLIBS = --whole-archive > > > > You are resetting LDLIBS here. > > It's not easy to read and probably not desired. > > I think it would be better to explicitly disable separated libs in this case. > > > Yes, I am resetting LDLIBS so we just link against the combined lib instead of all the previous separated libs. > I am not sure I understand what you mean with 'disable separated libs in this case'. By "disable separated libs", I mean enclose the LDLIBS lines for separated libs with ifneq ($(RTE_BUILD_COMBINE_LIBS),y) Using ifeq is more explicit than inserting LDLIBS= in the middle of LDLIBS+= lines. Do you agree? -- Thomas