From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D597F7D30 for ; Wed, 26 Jul 2017 19:06:53 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2017 10:06:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,416,1496127600"; d="scan'208";a="1155665057" Received: from dwdohert-mobl1.ger.corp.intel.com (HELO [163.33.228.138]) ([163.33.228.138]) by orsmga001.jf.intel.com with ESMTP; 26 Jul 2017 10:06:33 -0700 To: Tomasz Kulasek , dev@dpdk.org References: <20170726154607.26152-1-tomaszx.kulasek@intel.com> From: Declan Doherty Message-ID: <1505563e-0de9-fb05-f62d-e79065038bf3@intel.com> Date: Wed, 26 Jul 2017 18:06:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170726154607.26152-1-tomaszx.kulasek@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] test: fix virtual device name not set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2017 17:06:54 -0000 On 26/07/2017 4:46 PM, Tomasz Kulasek wrote: > Device name in device structure in virtual device used in > link_bonding_autotest is not set what causes segmentation fault when > rte_eth_dev_allocated is called. > > Fixes: a1e7c17555e8 ("ethdev: use device name from device structure") > > Signed-off-by: Tomasz Kulasek > --- > test/test/virtual_pmd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c > index 8e698bc..9d46ad5 100644 > --- a/test/test/virtual_pmd.c > +++ b/test/test/virtual_pmd.c > @@ -565,6 +565,7 @@ static void virtual_ethdev_stop(struct rte_eth_dev *eth_dev __rte_unused) > goto err; > > pci_dev->device.numa_node = socket_id; > + pci_dev->device.name = eth_dev->data->name; > pci_drv->driver.name = virtual_ethdev_driver_name; > pci_drv->id_table = id_table; > > Acked-by: Declan Doherty