From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7A39A0C50; Sat, 24 Jul 2021 14:45:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 239AF40DDA; Sat, 24 Jul 2021 14:45:37 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 48A874067A for ; Sat, 24 Jul 2021 14:45:36 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 5A451320091F; Sat, 24 Jul 2021 08:45:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 24 Jul 2021 08:45:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 2c/GIwV8hwZv4uk4sI8wY4lBGTcTnKWIuSCpUmg6P0s=; b=aPVL6lY0NodaKYOM 8f18ORnUK6S8sFBh3w3p2TXnaLbDj8PhPfguyfhVgJByUHR7BYQbS0GTZFDm7uc+ qH4N12fWaZDRB1Q5tN6kN/TKxfocJDtkDyxCN2drVUoLwghU/bd0c29wqFxaLOsr ZY1CBrpXnFa6ji3xhnt06jujVXJxrdMBgOedYhU4PYYk9iViogap/zCt3/5IatY7 uA9VOZ8EIER7UvuFCiqceR9ziwJVodaGtbi7UQSXbRSKS/XNeqXIG7/N8x95S7Fc d84Yh6lROMnjx2G4isaNs7INHSv1Rr9JB2gQ9pRFKeX13kkQvOn4qMXxA2kbMtKM eT7ung== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=2c/GIwV8hwZv4uk4sI8wY4lBGTcTnKWIuSCpUmg6P 0s=; b=Iuk9TDZjTrctIDZanQ4fYSvv60uAJwbk5dUyt15kvXINwNAr+QuYFshch bSgS50w30l9YzyZ0gYmK9Nv9CZ8j5D8CC43g3rdRoF0a2cKytNxcyfCfOcqCoVWk HTwUgNh/jdEjfwPrT2phq9iZjShjPcn/XjSFAeLxYIfMy6mL+6J1bwp70+5fRqMp F0DWNQ+5fR/OV8mzdmp3VokV4JOYDDKxydN10XGm6WJfP8Q7VY76h/wrT/epSe6g ydSZ4rWCuNeg9O31Ewn5e82pvdHOgEl4XDlckR8QcnMkQPdITmIOMIhb+EHcbGdv zQ4AoNBpQKSaCPlbXwfb1t0zZ8YKA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrgedtgdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Jul 2021 08:45:30 -0400 (EDT) From: Thomas Monjalon To: Paulis Gributs Cc: xiaoyun.li@intel.com, anatoly.burakov@intel.com, dev@dpdk.org, Ferruh Yigit , andrew.rybchenko@oktetlabs.ru, david.marchand@redhat.com Date: Sat, 24 Jul 2021 14:45:55 +0200 Message-ID: <15068020.bgqGIu2p9A@thomas> In-Reply-To: References: <20210715132015.1587544-1-paulis.gributs@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/07/2021 16:52, Ferruh Yigit: > On 7/15/2021 3:20 PM, Paulis Gributs wrote: > > This patch removes most uses of the global variable rte_eth_devices > > from testpmd. This was done to avoid using the object directly which > > applications should not do. > > > > Most uses have been replaced with standard function calls, however > > the use of it in the show_macs function could not be replaced as no > > function call exists to get all mac addresses of a given port. > > > > Signed-off-by: Paulis Gributs > > Reviewed-by: Ferruh Yigit > > +1 to eliminate 'rte_eth_devices' access from application Acked-by: Xiaoyun Li Applied, thanks that's a good step. However, I think we should not expose the rte_device pointer at all as it is done in rte_eth_dev_info.