From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2AD351B1BB for ; Thu, 5 Oct 2017 15:09:38 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2017 06:09:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,481,1500966000"; d="scan'208";a="319901046" Received: from silpixa00382658.ir.intel.com ([10.237.223.29]) by fmsmga004.fm.intel.com with ESMTP; 05 Oct 2017 06:09:35 -0700 From: Cristian Dumitrescu To: dev@dpdk.org Cc: thomas@monjalon.net, adrien.mazarguil@6wind.com, jingjing.wu@intel.com, hemant.agrawal@nxp.com, jerin.jacob@caviumnetworks.com, jasvinder.singh@intel.com Date: Thu, 5 Oct 2017 14:09:29 +0100 Message-Id: <1507208974-180500-1-git-send-email-cristian.dumitrescu@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1503705973-80742-2-git-send-email-cristian.dumitrescu@intel.com> References: <1503705973-80742-2-git-send-email-cristian.dumitrescu@intel.com> Subject: [dpdk-dev] [PATCH V2 0/5] rte_mtr: generic ethdev api for metering and policing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 13:09:39 -0000 This patch set introduces an ethdev-based generic API for Traffic Metering and Policing (MTR), which is yet another standard RX offload for Ethernet devices. Similar to rte_flow and rte_tm APIs, the configuration of MTR objects is done in their own namespace (rte_mtr) within the librte_ether library. Metering and policing action typically sits on top of flow classification, which is why MTR objects are enabled through a newly introduced flow action, which is the only impact to flow API. Q1: Why introduce ethdev-based traffic metering ad policing API? A1: Traffic metering and policing is a standard RX offload for Ethernet devices present in NICs, SoCs and NPUs across the industry. Q2: What's the connection between the new rte_mtr API and the existing librte_meter library? A2: The existing librte_meter library provides a SW implementation for a subset of the features exposed by this API. The rte_mtr API is agnostic to whether the implementation is HW, SW or mixed HW-SW. Q3: What's the connection between the new rte_mtr API and the existing flow API? A3: The MTR object is hooked into ethdev RX processing path using a newly introduced flow action, which is the only impact to the flow API. The configuration of MTR objects is done in separate namespace (rte_mtr) outside of flow API. Q4: Can the new flow API meter action drop packets? Is this a terminating action or not? A4: Although packets can be dropped by the newly introduced flow API meter action, this action is non-terminating, i.e. the action list typically contains at least one more action, which is a terminating action. Depending on the policer actions configured for the MTR object, some packets might be dropped while some packets passed to the next flow action with their color set in the packet mbuf. For example, a typical policer configuration is to drop the red packets while passing the green packets, therefore a subsequent flow action needs to be configured to determine the final destination of green packets. Q5: Which are the main operations exposed for the MTR object? A5: Traffic metering, policing and statistics update. Traffic metering determines the color for the current packet (green, yellow, red) based on the previous history for this flow as maintained by the MTR object. The policer can do nothing, recolor or drop the packet. Stats are maintained for MTR object, as configured. Q6: Where is the output color stored for the current packet. A6: struct rte_mbuf::sched::color. Q7: Which are the supported metering algorithms? A7: srTCM (RFC 2697), trTCM (RFC 2698 and RFC 4115). Q8: Which are the supported policer actions? A8: Recolor the packet (keep or change the color determined by metering) or drop the packet. Cristian Dumitrescu (5): ethdev: add new flow action for metering and policing ethdev: add new eth_dev_ops function for mtr ops get ethdev: add new API for traffic metering and policing doc: ethdev traffic metering and policing api app/testpmd: cli for traffic metering and policing MAINTAINERS | 4 + app/test-pmd/Makefile | 1 + app/test-pmd/cmdline.c | 10 + app/test-pmd/cmdline_flow.c | 24 + app/test-pmd/cmdline_mtr.c | 1013 ++++++++++++++++++++ app/test-pmd/cmdline_mtr.h | 49 + doc/api/doxy-api-index.md | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/rte_flow.rst | 24 + .../prog_guide/traffic_metering_and_policing.rst | 97 ++ lib/librte_ether/Makefile | 3 + lib/librte_ether/rte_ethdev.h | 6 + lib/librte_ether/rte_ethdev_version.map | 18 + lib/librte_ether/rte_flow.h | 22 + lib/librte_ether/rte_mtr.c | 229 +++++ lib/librte_ether/rte_mtr.h | 723 ++++++++++++++ lib/librte_ether/rte_mtr_driver.h | 221 +++++ 17 files changed, 2446 insertions(+) create mode 100644 app/test-pmd/cmdline_mtr.c create mode 100644 app/test-pmd/cmdline_mtr.h create mode 100644 doc/guides/prog_guide/traffic_metering_and_policing.rst create mode 100644 lib/librte_ether/rte_mtr.c create mode 100644 lib/librte_ether/rte_mtr.h create mode 100644 lib/librte_ether/rte_mtr_driver.h -- 2.7.4