From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 1CC3FB3D6
 for <dev@dpdk.org>; Thu,  4 Jun 2015 12:05:13 +0200 (CEST)
Received: by wgv5 with SMTP id 5so29587442wgv.1
 for <dev@dpdk.org>; Thu, 04 Jun 2015 03:05:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=hI6p32tEvTDH7VL3DHFyheGyEJWZh4a+vyY7kDGAqjc=;
 b=fLVvVfzY/ZrxtRSQcivcfByLrSgxYQd9O1+QyqTCUjNWSECkbEo6Ez6d4rSMFOwj70
 Cakhui8OwEliwRAQRwh8Pp89Rs0vznWK9xhfaE/loXlVADJRY40ObHBhSCLpy1ISaNlZ
 MYuDb4p39AYdezp3L+QNP05X4LV+lCCTlppcCmtn70FXtuT4zh6fgF58TKWmKOxrBeKa
 Nuv9YjsNqNpeuTJgZRAuaKrjucSofCFKTqCvs6T6c4HvfeiEPvyDFeErDgCeA/rx6yBr
 X41ZG2SUoCl8RcvdjX7PWUAgnBt8u5gEP/AvqV46Q/GfhC8zY4zrNVeen2BWLRu9pCRy
 qsQQ==
X-Gm-Message-State: ALoCoQmql6FEZQbxwr4fvl4tK/ZKSom5/LqH4sKMHQulIFunTFMMDS8XuXiCE154BmyaGFCVJaMq
X-Received: by 10.194.103.130 with SMTP id fw2mr66548882wjb.130.1433412312980; 
 Thu, 04 Jun 2015 03:05:12 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id lj2sm5011739wjb.38.2015.06.04.03.05.11
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 04 Jun 2015 03:05:12 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Thu, 04 Jun 2015 12:04:20 +0200
Message-ID: <1507815.0z9D0b3jov@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1433400872-6156-1-git-send-email-helin.zhang@intel.com>
References: <1430962859-26782-1-git-send-email-helin.zhang@intel.com>
 <1433400872-6156-1-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] i40evf: fix of supporting jumbo frame
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jun 2015 10:05:13 -0000

2015-06-04 14:54, Helin Zhang:
> It wouldn't check the configured maximum packet length, and then
> the scattered receiving function wouldn't be selected at all even
> if it wants to receive a jumbo frame. The fix is to select the
> correct RX function according to the configurations.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.h    |  2 +
>  drivers/net/i40e/i40e_ethdev_vf.c | 85 ++++++++++++++++++++++++++-------------
>  drivers/net/i40e/i40e_rxtx.c      |  1 -
>  3 files changed, 59 insertions(+), 29 deletions(-)
> 
> v2 changes:
> * Removed maximum packet length check and jumbo frame check in
>   i40evf_dev_start(), as the same checks are already in each queue
>   initialization.
> 
> v3 changes:
> * Added code style fixes.

Applied, thanks