From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id B02EA1B69E for ; Tue, 17 Oct 2017 20:11:41 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id j14so2608935wre.8 for ; Tue, 17 Oct 2017 11:11:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=vPTojN/9b90jizOWwRFdsk8rmyMf5l0Wke082AHojFE=; b=lbLN1aUljBECfv9sfu5cT6jVMa7LIFWJBgpc/Bx7vf0W/upPxLXm0wiYoOaK/JlDAC Ubn1728EQoCPbym/sz8b2kemVOvZLUgeVlXseyies9Isa9M3tAlHGXqPd8fs/wb619U0 oz5inZNMbj67poCC4UMpyJ8XXQuIvW1iAzWccyt9Pj/UK+i0ignoxROkS0JkzUMJ5PPo /T9ar95TCpr0QBJ3VB7sRC8Rl6For1Q6pocBzpUkxr0xlxMuyRQX+SyKqBfVfHOkoUZf 5y/PoCMzFDqw4esQGjeOZ6krgcLZFFBiiDmYYCoV+vWCyu6aGkNTz9EiiA7s101ZQjKY 9v9g== X-Gm-Message-State: AMCzsaWxHDJD6vPSSimiJ+c+eSQJH9WMsMeF639jNY+hS7t/mNKiruqz dB2iSUeO0EjTUdwmUw4Q4ao= X-Google-Smtp-Source: ABhQp+S1HoT7QBFPitXi4uYz0WixpwAo9ubTDuaEoGL+Jc8+W6reciw/pbsrj3UwqOH0BfjCTkT05g== X-Received: by 10.223.168.45 with SMTP id l42mr4297138wrc.15.1508263901117; Tue, 17 Oct 2017 11:11:41 -0700 (PDT) Received: from localhost ([2a00:23c5:bef3:400:4a51:b7ff:fe0b:4749]) by smtp.gmail.com with ESMTPSA id v5sm6041077wme.5.2017.10.17.11.11.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Oct 2017 11:11:39 -0700 (PDT) Message-ID: <1508263898.32437.1.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Date: Tue, 17 Oct 2017 19:11:38 +0100 In-Reply-To: <20171017161220.59941-2-bruce.richardson@intel.com> References: <20171017161220.59941-1-bruce.richardson@intel.com> <20171017161220.59941-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/8] build: add maths library to libs in pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 18:11:41 -0000 On Tue, 2017-10-17 at 17:12 +0100, Bruce Richardson wrote: > Since a number of libraries depend on the maths lib, as well as > adding it > to the project args, we also need to add it to the pkgconfig file > args. >=20 > Signed-off-by: Bruce Richardson > --- > =C2=A0config/meson.build | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/config/meson.build b/config/meson.build > index db68a08d4..542fea4de 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -35,6 +35,7 @@ dpdk_conf.set('RTE_MACHINE', machine) > =C2=A0add_project_arguments('-march=3D@0@'.format(machine), language: 'c'= ) > =C2=A0# some libs depend on maths lib > =C2=A0add_project_link_arguments('-lm', language: 'c') > +dpdk_extra_ldflags +=3D '-lm' > =C2=A0 > =C2=A0# add -include rte_config to cflags > =C2=A0add_project_arguments('-include', 'rte_config.h', language: 'c') This is for static builds, right? If so it should go into the Libs.private section of the .pc file, so that it's only used when calling pkg-config --static --libs --=20 Kind regards, Luca Boccassi