From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5F0681B732; Tue, 24 Oct 2017 07:18:34 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2017 22:18:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,426,1503385200"; d="scan'208";a="1234444910" Received: from gklab-246-074.igk.intel.com (HELO Sent) ([10.217.246.74]) by fmsmga002.fm.intel.com with SMTP; 23 Oct 2017 22:18:30 -0700 Received: by Sent (sSMTP sendmail emulation); Tue, 24 Oct 2017 07:13:03 +0200 From: SebastianX Basierski To: yliu@fridaylinux.org Cc: dev@dpdk.org, SebastianX Basierski , jianfeng.tan@intel.com, stable@dpdk.org Date: Tue, 24 Oct 2017 07:10:44 +0200 Message-Id: <1508821844-37372-2-git-send-email-sebastianx.basierski@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1508821844-37372-1-git-send-email-sebastianx.basierski@intel.com> References: <1505821646-33594-1-git-send-email-sebastianx.basierski@intel.com> <1508821844-37372-1-git-send-email-sebastianx.basierski@intel.com> Subject: [dpdk-dev] [PATCH v2] Report an error message if the flag O_NONBLOCK setting fails, then return from function. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 05:18:34 -0000 Coverity issue: 143439 Fixes: ef53b6030039 ("net/virtio-user: support LSC") Cc: jianfeng.tan@intel.com cc: stable@dpdk.org Signed-off-by: SebastianX Basierski --- drivers/net/virtio/virtio_user_ethdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index 57c964d..fe3a7be 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -86,7 +86,11 @@ virtio_user_read_dev_config(struct virtio_hw *hw, size_t offset, int flags; flags = fcntl(dev->vhostfd, F_GETFL); - fcntl(dev->vhostfd, F_SETFL, flags | O_NONBLOCK); + if (fcntl(dev->vhostfd, F_SETFL, + flags | O_NONBLOCK) == -1){ + PMD_DRV_LOG(ERR, "error setting O_NONBLOCK flag"); + return; + } r = recv(dev->vhostfd, buf, 128, MSG_PEEK); if (r == 0 || (r < 0 && errno != EAGAIN)) { dev->status &= (~VIRTIO_NET_S_LINK_UP); -- 2.7.4