* [dpdk-dev] [PATCH] net/dpaa2: set queues after reconfiguration
@ 2017-11-01 8:16 Hemant Agrawal
2017-11-01 20:37 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Hemant Agrawal @ 2017-11-01 8:16 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, Akhil Goyal, stable
From: Akhil Goyal <akhil.goyal@nxp.com>
if dpaa2_dev_tx_queue_setup is called multiple times, the
assignment of device->data->tx_queues is not done, as a result
tx_queues remain NULL after reconfiguration.
This patch sets the tx_queues from the device private data to the
usable device tx queues.
Fixes: 7ae777d064e8 ("net/dpaa2: add support for congestion notification")
Cc: stable@dpdk.org
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
drivers/net/dpaa2/dpaa2_ethdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 19c1191..202f84f 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -514,8 +514,10 @@ dpaa2_dev_tx_queue_setup(struct rte_eth_dev *dev,
PMD_INIT_FUNC_TRACE();
/* Return if queue already configured */
- if (dpaa2_q->flow_id != 0xffff)
+ if (dpaa2_q->flow_id != 0xffff) {
+ dev->data->tx_queues[tx_queue_id] = dpaa2_q;
return 0;
+ }
memset(&tx_conf_cfg, 0, sizeof(struct dpni_queue));
memset(&tx_flow_cfg, 0, sizeof(struct dpni_queue));
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/dpaa2: set queues after reconfiguration
2017-11-01 8:16 [dpdk-dev] [PATCH] net/dpaa2: set queues after reconfiguration Hemant Agrawal
@ 2017-11-01 20:37 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-11-01 20:37 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, Akhil Goyal, stable
On 11/1/2017 1:16 AM, Hemant Agrawal wrote:
> From: Akhil Goyal <akhil.goyal@nxp.com>
>
> if dpaa2_dev_tx_queue_setup is called multiple times, the
> assignment of device->data->tx_queues is not done, as a result
> tx_queues remain NULL after reconfiguration.
> This patch sets the tx_queues from the device private data to the
> usable device tx queues.
>
> Fixes: 7ae777d064e8 ("net/dpaa2: add support for congestion notification")
> Cc: stable@dpdk.org
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Applied to dpdk-next-net/master, thanks.
(Since patch sent by Hemant, I assume Hemant is agree with the patch and added
an explicit Ack from him.)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-01 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-01 8:16 [dpdk-dev] [PATCH] net/dpaa2: set queues after reconfiguration Hemant Agrawal
2017-11-01 20:37 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).