* [dpdk-dev] [PATCH] net/vmxnet3: fix memory leak when releasing queues
@ 2017-11-01 20:38 Chas Williams
2017-11-02 10:03 ` Luca Boccassi
0 siblings, 1 reply; 3+ messages in thread
From: Chas Williams @ 2017-11-01 20:38 UTC (permalink / raw)
To: dev; +Cc: skhare, Chas Williams
From: Chas Williams <chas3@att.com>
At the end of the queue release, we can free the containers for the
queue objects.
Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver implementation")
Signed-off-by: <chas3@att.com>
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index 01c85f1..18dce72 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -203,6 +203,8 @@ vmxnet3_dev_tx_queue_release(void *txq)
vmxnet3_cmd_ring_release(&tq->cmd_ring);
/* Release the memzone */
rte_memzone_free(tq->mz);
+ /* Release the queue */
+ rte_free(tq);
}
}
@@ -223,6 +225,9 @@ vmxnet3_dev_rx_queue_release(void *rxq)
/* Release the memzone */
rte_memzone_free(rq->mz);
+
+ /* Release the queue */
+ rte_free(rq);
}
}
--
2.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vmxnet3: fix memory leak when releasing queues
2017-11-01 20:38 [dpdk-dev] [PATCH] net/vmxnet3: fix memory leak when releasing queues Chas Williams
@ 2017-11-02 10:03 ` Luca Boccassi
2017-11-03 0:17 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2017-11-02 10:03 UTC (permalink / raw)
To: Chas Williams, dev; +Cc: skhare
On Wed, 2017-11-01 at 16:38 -0400, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
>
> At the end of the queue release, we can free the containers for the
> queue objects.
>
> Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
> implementation")
>
> Signed-off-by: <chas3@att.com>
> ---
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index 01c85f1..18dce72 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -203,6 +203,8 @@ vmxnet3_dev_tx_queue_release(void *txq)
> vmxnet3_cmd_ring_release(&tq->cmd_ring);
> /* Release the memzone */
> rte_memzone_free(tq->mz);
> + /* Release the queue */
> + rte_free(tq);
> }
> }
>
> @@ -223,6 +225,9 @@ vmxnet3_dev_rx_queue_release(void *rxq)
>
> /* Release the memzone */
> rte_memzone_free(rq->mz);
> +
> + /* Release the queue */
> + rte_free(rq);
> }
> }
>
Reviewed-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vmxnet3: fix memory leak when releasing queues
2017-11-02 10:03 ` Luca Boccassi
@ 2017-11-03 0:17 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-11-03 0:17 UTC (permalink / raw)
To: Luca Boccassi, Chas Williams, dev; +Cc: skhare
On 11/2/2017 3:03 AM, Luca Boccassi wrote:
> On Wed, 2017-11-01 at 16:38 -0400, Chas Williams wrote:
>> From: Chas Williams <chas3@att.com>
>>
>> At the end of the queue release, we can free the containers for the
>> queue objects.
>>
>> Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
>> implementation")
>>
>> Signed-off-by: <chas3@att.com>
> Reviewed-by: Luca Boccassi <bluca@debian.org>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-03 0:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-01 20:38 [dpdk-dev] [PATCH] net/vmxnet3: fix memory leak when releasing queues Chas Williams
2017-11-02 10:03 ` Luca Boccassi
2017-11-03 0:17 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).