From: Wei Dai <wei.dai@intel.com>
To: jingjing.wu@intel.com, beilei.xing@intel.com
Cc: dev@dpdk.org, Wei Dai <wei.dai@intel.com>
Subject: [dpdk-dev] [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power
Date: Fri, 3 Nov 2017 16:47:28 +0800 [thread overview]
Message-ID: <1509698850-13301-1-git-send-email-wei.dai@intel.com> (raw)
In-Reply-To: <1509693243-43101-1-git-send-email-wei.dai@intel.com>
These 2 bugs can be observed from example/l3fwd-power run with i40e VF
bound to VFIO-PCI. The test steps are as follows:
1. Disable LSC interrupt by clearing port_conf.intr_conf.lsc=0, as i40e
VF doesn't support LSC interrupt to avoid rte_eth_dev_configure() failure.
2. Create a VF from i40e host PF. Let PF run with kernel driver and bind
its VF to VFIO-PCI
3. Run l3fwd-power like: l3fwd-power -l 18-19 -- -p 0x1 --config='(0,0,19)'
Then, the following error message appears like:
EAL: Error enabling MSI-X interrupts for fd 18
This error is from rte_intr_enable( )/vfio_enable_msix( ) when enabling
Rx queue interrupt.
Same as the patch 06938770186a ("net/ixgbe: fix VFIO interrupt mapping in VF"),
to change VFIO MSI-X interrupts mapping, previous mapping should be cleared
first to avoid above error.
After fixing above VFIO-PCI MSI-X interrupt mapping. There is still the following
2nd bug: l3fwd-power still can not be waked up by incoming packets.
Same as the patch ca9d6597184b ("net/ixgbe: fix Rx queue interrupt mapping in VF"),
the interrupt vector of Rx queues should be mapped to vector 1 to fix above 2nd bug.
These patches have passed test with l3fwd-power using i40e VF bound to VFIO-PCI.
They also passed the test with testpmd rxonly and txonly mode with igb_uio and VFIO-PCI.
Signed-off-by: Wei Dai <wei.dai@intel.com>
Tested-by: Lei Yao <lei.a.yao@intel.com>
---
v3:
keep rte_intr_enable( ) for safety and align the style with other PMD.
remove 2 unsed macros.
v2:
only remap VFIO interrupt in i40evf_dev_start( )
Wei Dai (2):
net/i40e: fix VFIO interrupt mapping in VF
net/i40e: fix Rx queue interrupt mapping in VF
drivers/net/i40e/i40e_ethdev_vf.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
--
2.7.4
next prev parent reply other threads:[~2017-11-03 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 13:10 [dpdk-dev] [PATCH " Wei Dai
2017-11-02 13:10 ` [dpdk-dev] [PATCH 1/2] net/i40e: fix VFIO interrupt mapping in VF Wei Dai
2017-11-03 2:25 ` Wu, Jingjing
2017-11-03 5:48 ` Dai, Wei
2017-11-02 13:10 ` [dpdk-dev] [PATCH 2/2] net/i40e: fix Rx queue " Wei Dai
2017-11-03 2:17 ` Wu, Jingjing
2017-11-03 5:51 ` Dai, Wei
2017-11-03 7:14 ` [dpdk-dev] [PATCH v2 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power Wei Dai
2017-11-03 7:14 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: fix VFIO interrupt mapping in VF Wei Dai
2017-11-03 7:14 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: fix Rx queue " Wei Dai
2017-11-03 8:31 ` [dpdk-dev] [PATCH v2 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power Yao, Lei A
2017-11-03 8:47 ` Wei Dai [this message]
2017-11-03 8:47 ` [dpdk-dev] [PATCH v3 1/2] net/i40e: fix VFIO interrupt mapping in VF Wei Dai
2017-11-03 10:36 ` Wu, Jingjing
2017-11-03 8:47 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: fix Rx queue " Wei Dai
2017-11-03 10:37 ` Wu, Jingjing
2017-11-03 9:22 ` [dpdk-dev] [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power Dai, Wei
2017-11-03 19:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509698850-13301-1-git-send-email-wei.dai@intel.com \
--to=wei.dai@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).