From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id DC2DE1B607 for ; Fri, 3 Nov 2017 09:58:47 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2017 01:58:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,337,1505804400"; d="scan'208";a="171009235" Received: from dpdk4.bj.intel.com ([172.16.182.85]) by fmsmga005.fm.intel.com with ESMTP; 03 Nov 2017 01:58:45 -0700 From: Wei Dai To: jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Wei Dai Date: Fri, 3 Nov 2017 16:47:28 +0800 Message-Id: <1509698850-13301-1-git-send-email-wei.dai@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509693243-43101-1-git-send-email-wei.dai@intel.com> References: <1509693243-43101-1-git-send-email-wei.dai@intel.com> Subject: [dpdk-dev] [PATCH v3 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 08:58:48 -0000 These 2 bugs can be observed from example/l3fwd-power run with i40e VF bound to VFIO-PCI. The test steps are as follows: 1. Disable LSC interrupt by clearing port_conf.intr_conf.lsc=0, as i40e VF doesn't support LSC interrupt to avoid rte_eth_dev_configure() failure. 2. Create a VF from i40e host PF. Let PF run with kernel driver and bind its VF to VFIO-PCI 3. Run l3fwd-power like: l3fwd-power -l 18-19 -- -p 0x1 --config='(0,0,19)' Then, the following error message appears like: EAL: Error enabling MSI-X interrupts for fd 18 This error is from rte_intr_enable( )/vfio_enable_msix( ) when enabling Rx queue interrupt. Same as the patch 06938770186a ("net/ixgbe: fix VFIO interrupt mapping in VF"), to change VFIO MSI-X interrupts mapping, previous mapping should be cleared first to avoid above error. After fixing above VFIO-PCI MSI-X interrupt mapping. There is still the following 2nd bug: l3fwd-power still can not be waked up by incoming packets. Same as the patch ca9d6597184b ("net/ixgbe: fix Rx queue interrupt mapping in VF"), the interrupt vector of Rx queues should be mapped to vector 1 to fix above 2nd bug. These patches have passed test with l3fwd-power using i40e VF bound to VFIO-PCI. They also passed the test with testpmd rxonly and txonly mode with igb_uio and VFIO-PCI. Signed-off-by: Wei Dai Tested-by: Lei Yao --- v3: keep rte_intr_enable( ) for safety and align the style with other PMD. remove 2 unsed macros. v2: only remap VFIO interrupt in i40evf_dev_start( ) Wei Dai (2): net/i40e: fix VFIO interrupt mapping in VF net/i40e: fix Rx queue interrupt mapping in VF drivers/net/i40e/i40e_ethdev_vf.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) -- 2.7.4