From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 761AD1B2A5 for ; Mon, 6 Nov 2017 12:41:22 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2017 03:41:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,352,1505804400"; d="scan'208";a="169865417" Received: from silpixa00383879.ir.intel.com (HELO silpixa00383879.ger.corp.intel.com) ([10.237.223.127]) by orsmga005.jf.intel.com with ESMTP; 06 Nov 2017 03:41:17 -0800 From: Radu Nicolau To: dev@dpdk.org Cc: thomas@monjalon.net, konstantin.ananyev@intel.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, wenzhuo.lu@intel.com, michael.j.glynn@intel.com, Radu Nicolau Date: Mon, 6 Nov 2017 11:36:47 +0000 Message-Id: <1509968207-16465-1-git-send-email-radu.nicolau@intel.com> X-Mailer: git-send-email 2.7.5 In-Reply-To: <1509965661-17121-1-git-send-email-radu.nicolau@intel.com> References: <1509965661-17121-1-git-send-email-radu.nicolau@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix build on gcc 4.5.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2017 11:41:22 -0000 Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") On SUSE11 with gcc 4.5.1 the following build error occurred, most likely because of improper handling of annonymous unions: DPDK/drivers/net/ixgbe/ixgbe_ipsec.c:579:4: error: unknown field ‘ipsec’ specified in initializer compilation terminated due to -Wfatal-errors. Signed-off-by: Radu Nicolau --- v2: additional info added in the commit message. drivers/net/ixgbe/ixgbe_ipsec.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index 99c0a73..105da11 100644 --- a/drivers/net/ixgbe/ixgbe_ipsec.c +++ b/drivers/net/ixgbe/ixgbe_ipsec.c @@ -576,48 +576,48 @@ ixgbe_crypto_capabilities_get(void *device __rte_unused) { /* IPsec Inline Crypto ESP Transport Egress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO, .protocol = RTE_SECURITY_PROTOCOL_IPSEC, - .ipsec = { + {.ipsec = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT, .direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS, .options = { 0 } - }, + } }, .crypto_capabilities = aes_gcm_gmac_crypto_capabilities, .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA }, { /* IPsec Inline Crypto ESP Transport Ingress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO, .protocol = RTE_SECURITY_PROTOCOL_IPSEC, - .ipsec = { + {.ipsec = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT, .direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS, .options = { 0 } - }, + } }, .crypto_capabilities = aes_gcm_gmac_crypto_capabilities, .ol_flags = 0 }, { /* IPsec Inline Crypto ESP Tunnel Egress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO, .protocol = RTE_SECURITY_PROTOCOL_IPSEC, - .ipsec = { + {.ipsec = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS, .options = { 0 } - }, + } }, .crypto_capabilities = aes_gcm_gmac_crypto_capabilities, .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA }, { /* IPsec Inline Crypto ESP Tunnel Ingress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO, .protocol = RTE_SECURITY_PROTOCOL_IPSEC, - .ipsec = { + {.ipsec = { .proto = RTE_SECURITY_IPSEC_SA_PROTO_ESP, .mode = RTE_SECURITY_IPSEC_SA_MODE_TUNNEL, .direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS, .options = { 0 } - }, + } }, .crypto_capabilities = aes_gcm_gmac_crypto_capabilities, .ol_flags = 0 }, -- 2.7.5