[dpdk-dev] [PATCH] mk: remove useless list of core libraries

[dpdk-dev] [PATCH] mk: remove useless list of core libraries

[Thomas Monjalon]

When moving the library dependencies handling from top Makefiles
to library Makefiles, the list core-libs became useless.

Fixes: cbc12b0a96f5 ("mk: do not generate LDLIBS from directory dependencies")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/bus/Makefile     | 4 ----
 drivers/crypto/Makefile  | 2 --
 drivers/event/Makefile   | 2 --
 drivers/mempool/Makefile | 2 --
 drivers/net/Makefile     | 3 ---
 5 files changed, 13 deletions(-)

diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
index a220d275e..e3fbc5082 100644
--- a/drivers/bus/Makefile
+++ b/drivers/bus/Makefile
@@ -30,12 +30,8 @@
 
 include $(RTE_SDK)/mk/rte.vars.mk
 
-core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether
-
 DIRS-$(CONFIG_RTE_LIBRTE_DPAA_BUS) += dpaa
-
 DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc
-
 DIRS-$(CONFIG_RTE_LIBRTE_PCI_BUS) += pci
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
index d551541c6..645b69677 100644
--- a/drivers/crypto/Makefile
+++ b/drivers/crypto/Makefile
@@ -31,8 +31,6 @@
 
 include $(RTE_SDK)/mk/rte.vars.mk
 
-core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_cryptodev
-
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM) += aesni_gcm
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += aesni_mb
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO) += armv8
diff --git a/drivers/event/Makefile b/drivers/event/Makefile
index 05dec1b9d..1f9c0ba21 100644
--- a/drivers/event/Makefile
+++ b/drivers/event/Makefile
@@ -31,8 +31,6 @@
 
 include $(RTE_SDK)/mk/rte.vars.mk
 
-core-libs := librte_eal librte_ether librte_eventdev
-
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) += skeleton
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += sw
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) += octeontx
diff --git a/drivers/mempool/Makefile b/drivers/mempool/Makefile
index 1c5f2003e..f656c566d 100644
--- a/drivers/mempool/Makefile
+++ b/drivers/mempool/Makefile
@@ -30,8 +30,6 @@
 
 include $(RTE_SDK)/mk/rte.vars.mk
 
-core-libs := librte_eal librte_mempool librte_ring
-
 DIRS-$(CONFIG_RTE_LIBRTE_DPAA_MEMPOOL) += dpaa
 DIRS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) += dpaa2
 DIRS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += ring
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index cf3323340..ef09b4e16 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -36,9 +36,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD),d)
         $(warning thunderx pmd is not supported by old compilers)
 endif
 
-core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether
-core-libs += librte_net librte_kvargs
-
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += af_packet
 DIRS-$(CONFIG_RTE_LIBRTE_ARK_PMD) += ark
 DIRS-$(CONFIG_RTE_LIBRTE_AVP_PMD) += avp
-- 
2.14.2

Re: [dpdk-dev] [PATCH] mk: remove useless list of core libraries

[Thomas Monjalon]

06/11/2017 12:24, Thomas Monjalon:
> When moving the library dependencies handling from top Makefiles
> to library Makefiles, the list core-libs became useless.
> 
> Fixes: cbc12b0a96f5 ("mk: do not generate LDLIBS from directory dependencies")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Applied