From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0078.outbound.protection.outlook.com [104.47.41.78]) by dpdk.org (Postfix) with ESMTP id C21EC1B60F; Tue, 7 Nov 2017 09:35:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9a3EBvmbgxlnNORk91QXmCSkav9aqdRdcbG0geaIhic=; b=nFI0inQeRNysCxRtFjAEm9oP5uQhmeOQFZwQtl22uAlidHImsK46QRx4U9VK5lQ1YQ9qahTXGFXT4jNoCLCr89PdrrkJnEBIvcPJduUmbVe2JlNP6yXEdBkl1bE1cccsd33j+6J2Pi6o88rOdViSIKwod3Iv5707yiesP1FfhWg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by CY4PR0701MB3827.namprd07.prod.outlook.com (2603:10b6:910:94::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Tue, 7 Nov 2017 08:35:45 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Tue, 7 Nov 2017 00:34:23 -0800 Message-Id: <1510043665-8160-7-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1510043665-8160-1-git-send-email-rasesh.mody@cavium.com> References: <1510043665-8160-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: YQXPR0101CA0004.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:15::17) To CY4PR0701MB3827.namprd07.prod.outlook.com (2603:10b6:910:94::33) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4acf47bc-4710-470c-0c34-08d525ba8aa5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:CY4PR0701MB3827; X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3827; 3:F0SPD8bfRcGwSjH/HTQp9YEy6NIxhA12dvNEsc81q7qc0iQ8nVd3/zYgvoEb5e3uet2qUiRi6enpLQHHsNolXa8DK5tDsG6J8JJ7Hb2+ZDtTPlZUbvCauo/DgD5T7BIvb9IV2tus4iGIyWSPJQj+qR2oNh/aAGoIUztP8/uWcfzfsng19IOaaxGOOqcw3S9ynYgKKKmGBNKmBIFNrgzkIjeJM+I6X8D/qNS/Yk3Azks9SGcZGNhwbr9/aoIEiyP4; 25:J/En6mvCwg2m/hkXVXAMqbU1BD7PhhdlwdeY3AtC+k//icvDBGQ4R1LovGOufdnfL4YFi3h4aaZII4Z7QLVuHw2F7HY999NL4kb7A5WIsQ2uno/C3eu6znDYd9B8LrEEBdoh8Utam64+rdlCsyT2XH+EslfWRMVXqW3lHGIPazDIHbsgHDA6Oz/ZeKUKb8UjdiQqTY9nvpgHlDDm/0lSrasfrBXeempBCocqp7RxoPfP3zRjpby0pJTFMuOffG/IPKz2Ur9qdgMMXyIv+Zu1WyI/j29MtAXHaK4kBFaOp458W1scFejQIxJEww+LKirz0JQHxRyg4XIzQNN/tVRcHg==; 31:/zxc0TaZC7mWtXCx0SjNI9iqPCfMRS27p75QSySB8WyM2XpoMABMyTENA/b9f6PxYoTCTjKPy5vocCuFfBV2ebXY3mIGNqJY3tHPfcPyhBTh22qYUoZbVu8oNtRwMTprQHqKwL6uB8R+/fL8HV0g506HjdNdNUU3aev4QGjG3H3LrKVh7X5TSnajGgU7n9/cF/0crl7CJs6jQSojH2pDqqoafOlg113zr1wl/3gstug= X-MS-TrafficTypeDiagnostic: CY4PR0701MB3827: X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3827; 20:M9xEvEqO4Sy6vDfIPSr0lUJWHQ3/bLMAerkfue2skHffT9+6bJiOFyt6S9wSBaDa83/dTquD1xx0JgSlEBxOay2QUMhX+5CoKnRIH6VlQ/81mPIrUoj311eSDpRMMKSGhfU/NuAM7+16ms0NvoEBdtYDXmoKmJXAHQPUTLH8QZ4GQEpbV5JMRL83Ejh6CnXuanhLtprURExRAieG+o5QkXsDlc+xHSLeqSttvJbXfa+SjlreVwzFPa1pWM+Q8mMk0Jok55zBdTp7xUqwLc4v8rYij/Yr7AEZiQqBhw9s7k1ueECJuK7i9KkPIUKTW9V0BkBapZKFoBmvKkLzN/Bp5u6N1AFEJBjEbc0xKME8stcLovxUrcNvun8DSzuUmLyeJn2MJ77gVTsd1TEJlTIqGHkeKeQ//66qgB7TIRd+NPRLij5+aOAid/Nvt9jUlIs3af+9w9l/RdkqkzOZG/nLl1Zhj+8yst/x0XW8BMxIBmAV79r7gO7H6j4FcgElaP3g; 4:BY5EOn7sUy9vFV3ja8+/G4hrJ0WqqaLrtKEkZi3dPjQA3ZJjz15z3z1OkOSxY2Ut+5cqYA0Wb6HLSNQAJJrMHrUJaWx4ABJWSEBARNEFvEowLobLM35JcH1pTGcwHD91nK45NBmZOCCoxhsdFZO6KkaWRlbbuejbdz7/sAaDJnZH4FYf5pkngb2XGP/3ekgWNMmDKr6TZjaLtWpnTeUGa24xkYPAwci6bHHPIe8DsYXuOErS1DQIr+phktIyDeipoEA6bZL8ZmsN/mTvY4qoqg== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3231021)(6041248)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR0701MB3827; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR0701MB3827; X-Forefront-PRVS: 0484063412 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(189002)(199003)(2351001)(47776003)(50226002)(6916009)(36756003)(76176999)(53936002)(8936002)(68736007)(55016002)(2950100002)(4326008)(48376002)(50466002)(50986999)(5003940100001)(66066001)(97736004)(8676002)(86362001)(316002)(16586007)(81156014)(81166006)(2361001)(478600001)(33646002)(72206003)(6666003)(305945005)(21086003)(106356001)(7736002)(69596002)(189998001)(4720700003)(25786009)(2906002)(5660300001)(6116002)(105586002)(16526018)(3846002)(101416001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3827; H:cavium.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR0701MB3827; 23:/db+JI/39pHQSymbcPvH2k5tWr8LURGrcBWXSnk?= =?us-ascii?Q?LtltTItped/CUSkixlLndUn9MskuHnch9QjiTfgALD6iIIXoB5ljaZdaD87W?= =?us-ascii?Q?qEtjdwU2ChQY0J1Q9Zhdwfk3P/Y+Jt/Zde8W1A4sB2r3OOo5Geyq5zcnYiop?= =?us-ascii?Q?y58mUo1LK0AR8aZgR0S1Wh56LForw2pY3w7cxgEewBwE7do+UAp74G9TpC5f?= =?us-ascii?Q?BDnrQKKwyQZCxbEki0xttQPdwWUI8w3oxt8iRngjkEQS3laO7AXsGkunhLD0?= =?us-ascii?Q?rBIuRp2uNPPQXZAsN847b+zQE/mazsoDZ9hXxOPq1rnnRgv+/yHhaPgyCgx+?= =?us-ascii?Q?0fjNNWsKHo3cZ3EtPzZm25vO489gm4v8QP9CKyIgID5hnMP3Q7LS72WsICzQ?= =?us-ascii?Q?Bq+MDAYPLlAkdNxGRX4oV0B6udZ+C9Fd53jXMjCEq0Uu4OaNJ2LRrnfEUkaS?= =?us-ascii?Q?/M0o70wyVzeas+cUoWOZAvnIF4xqyibCvOvIGsldQFtGj/t8QLFfdhNV+GP+?= =?us-ascii?Q?42Lzr5kFEXi2zodCkcjaHjhX57CQaGM2dFhOnbQoRB/sF3zClTZD9e03TKTt?= =?us-ascii?Q?S6uP3LwL68Mrb0GfEt0eapmQCjYWamLRASAIt/fM962Uf3WNWj/lsWkvHZrB?= =?us-ascii?Q?5xuvHasIVWVa8Ye7cqeH/ZIAcG4D31/zQlst+Yq3oNdNztEBFq3//VwXI2Kx?= =?us-ascii?Q?EBMqtpfn2oqSm0/TipDFU3y9OlVizHbCXzCR1uVCsoBUfnTsjQKTtfnA54Ez?= =?us-ascii?Q?i7R1bKU2pkeopLCf20FwUig1/LNnPicEibma78+OGTQ1TNHQB/R5Ttg38iBE?= =?us-ascii?Q?RBmgPD1ZYh/yeNAvqLiY3I6e7L39MFy6POakZG8/t3/Uuatlu9IFO5x6EPVs?= =?us-ascii?Q?Q+KGciApJItyn06fCgUq7sx7OAxT9y8h3+BWCKpQv87hbin0jQSJsXPBCDTM?= =?us-ascii?Q?6o29zevxb+OcGq3UMPPVPXysznfdPSIDkstBHcQDrXzFPf5amTOiaXkKFLSc?= =?us-ascii?Q?a20+6qn1o2Ov4innHnw18BbtfbvEbGbjGIb9dIYCXVEicziYhevD1oNRx0ld?= =?us-ascii?Q?Lek4nGzJN/yItQqSysqBDLg4KaKelr3khQw032nxAnCMXlWXAFOr3uiNd8Nv?= =?us-ascii?Q?orPxKRamVJ3jYJNFXkGacoZEbpIl1Jn9Vqhovm85QEzAFIANy0U4L+A=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3827; 6:/JOw/zkaIl3GAGDGdLTkMRSzf1ruI2s/ELcqK32Q5cV58i6Pk3vnS7OAV0GnJDW5gkQoLkhSIyztRtgWGYgjRR1s1xAsoXQw8HTAwrM2amtGvn7Zea5a/kyVAkTZQE1cRcOCSABTK7unCcoCyE7/sXGhqhyQcGfyF/YEUkJYS4XXj55endYT5goVJHQ2k0iOIN5A8fghQLineNXNMXmFx3LPLRng9lFJiTkVdm2dzKKcqKYFZoc+J8b9lsRA43zz6k4MEvUBnuOjeG7D7KLDLuIkLDYiVsR5c1mkiP/Omzwufhj2fEHaBYsgQgW44k265KsabT9YhFXB5WEQ+Dkb6tR3DkzpufrkaRkhYtV2ye4=; 5:TCDybRFWB3kBvfd/5zJfP6kTtcbMWsMXKwf4DVcJLCMBu925H2eEViod/3CW7o71okOf/NTu4Fl+BZEmx4nOhImCnwMAI3HTllia4COIxlJ+ZKwNLwRQ+2PN+puDmm6Z2y3nTeC8c3ziL4BHiizqM8eyIriZSK/8azUFkBAqaCY=; 24:Mj+QMKjTKlWUaxW4qIKlBv8uLrqtR4Qz9boNyo3EkZm7K9MXDYlvMfumkvClaGqAXOcYewnEad6Vzg3SG+f1TPg9RSDc9vYtrODAFFNJ0lY=; 7:1E+Xa/6NxJ8NGPhCtfLx7FDq4nLF0E9Aedf+uGHP4bx07eYXByTRUKnWIfpeUK8njByzSrV6ukmUi0N+d26vgXtee6xeJrTrE/a1Hj1PHkYApLqHuhMWvzGYELtEm9XQN7SE2WLqhoMpJYS/489ppwrmYpzC9eFVhq/YqL27gmpFQOBRnmjrZ9xoUpeYkzSHRI5WO7pUBzbLYKFS3L5fHzVNQcuQp7KRXKhAh4pRC2hYB5DJbPBMEbyoF9b5xGuC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2017 08:35:45.3166 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4acf47bc-4710-470c-0c34-08d525ba8aa5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3827 Subject: [dpdk-dev] [PATCH 6/8] net/qede/base: fix to initialize filter API return code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 08:35:48 -0000 Fix for uninitialized scalar variable for filter APIs Coverity issue: 1445717, 1445718, 1445721, 1445722 Fixes: 2e2f392b249a ("net/qede/base: upgrade the FW to 8.20.0.0") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index e4bba17..da1830c 100644 --- a/drivers/net/qede/base/ecore_dev.c +++ b/drivers/net/qede/base/ecore_dev.c @@ -4633,7 +4633,7 @@ enum _ecore_status_t ecore_llh_add_mac_filter(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt, u8 *p_filter) { u32 high, low, entry_num; - enum _ecore_status_t rc; + enum _ecore_status_t rc = ECORE_SUCCESS; if (!OSAL_TEST_BIT(ECORE_MF_LLH_MAC_CLSS, &p_hwfn->p_dev->mf_bits)) @@ -4657,7 +4657,7 @@ enum _ecore_status_t ecore_llh_add_mac_filter(struct ecore_hwfn *p_hwfn, p_filter[0], p_filter[1], p_filter[2], p_filter[3], p_filter[4], p_filter[5], entry_num); - return ECORE_SUCCESS; + return rc; } static enum _ecore_status_t @@ -4701,7 +4701,7 @@ void ecore_llh_remove_mac_filter(struct ecore_hwfn *p_hwfn, struct ecore_ptt *p_ptt, u8 *p_filter) { u32 high, low, entry_num; - enum _ecore_status_t rc; + enum _ecore_status_t rc = ECORE_SUCCESS; if (!OSAL_TEST_BIT(ECORE_MF_LLH_MAC_CLSS, &p_hwfn->p_dev->mf_bits)) @@ -4776,11 +4776,11 @@ enum _ecore_status_t enum ecore_llh_port_filter_type_t type) { u32 high, low, entry_num; - enum _ecore_status_t rc; + enum _ecore_status_t rc = ECORE_SUCCESS; if (!OSAL_TEST_BIT(ECORE_MF_LLH_PROTO_CLSS, &p_hwfn->p_dev->mf_bits)) - return ECORE_SUCCESS; + return rc; high = 0; low = 0; @@ -4853,7 +4853,7 @@ enum _ecore_status_t break; } - return ECORE_SUCCESS; + return rc; } static enum _ecore_status_t @@ -4920,7 +4920,7 @@ enum _ecore_status_t enum ecore_llh_port_filter_type_t type) { u32 high, low, entry_num; - enum _ecore_status_t rc; + enum _ecore_status_t rc = ECORE_SUCCESS; if (!OSAL_TEST_BIT(ECORE_MF_LLH_PROTO_CLSS, &p_hwfn->p_dev->mf_bits)) -- 1.7.10.3