From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 944F82904 for ; Wed, 6 Apr 2016 10:54:15 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id v188so15039967wme.1 for ; Wed, 06 Apr 2016 01:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=7BmEtFiMrOTKN3tT6CvbOEZENOKtCAOr7mP9AUQNtI4=; b=dwLvcJJChJFm79QirJMFk/WwJNMnxaGND4Owe7Oes7rhOKlieCcA21tYX/POqb/BIN xlg7TxIxG8Hc0moLXsHnjnQ7KtSC41IRlBL8r8354XC5uBAdxyg4Rgw/43KMvTp8PMgX qVRlXkyEvUYvsN0g2Z+GEsaCJ5ebCys7fGSwt0hm9Zf5NNk2RY3TBLS+CxS3ggQzSfkR QdpqJaRmlW+zU2N525D8g+PEIPQqaBaWXFDXfhdthPN+7UivpYyAhr6RFKonh9mEXu6p QCUY9pSfHzy8+OpdSKuY8xpyoUhCUHQJd1ol7M0fuMiIPwlIszG6iDMPGkrRLG9qfrJH blJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=7BmEtFiMrOTKN3tT6CvbOEZENOKtCAOr7mP9AUQNtI4=; b=GqUosXrv0Mu2DlpkzWXZTXKAPresXGOzZP2lZPYgiV7jpkmq+ohTGl6H1p2ZkiBVGL xXDixRBicD+yG90F4tYMLpuoggeasfZv3kOrjSXHnYYcic7Vz4+yB25n4vGPAsw4RwzK SK5IS/tQbPYxZlhHshmFqXW67gyGDd6ztaEj/FVWi9x8HH1R0Uns7Zlm8BRs08uB8Jea HuUMQe6TUuM/79LBr0VMOcJvWDecJdzXaSLm3WWcWfbO+8+nJXRrSe9Qojsnt88jPG+/ SLRCRKoAY/ST5fHQX5UJeTDMWD8DNbdWeeNTOm+SYWwZFD0TEdi8BhfI4rn8odHeTFyH 2Z/w== X-Gm-Message-State: AD7BkJLua5+g91zQ4lJe2U08ev6N2yGYpYz2IHlF3E9kUQyGZWXyRVs9HmcOiyXpXdw5Hms1 X-Received: by 10.194.174.197 with SMTP id bu5mr10375854wjc.23.1459932855485; Wed, 06 Apr 2016 01:54:15 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id lh1sm2083032wjb.20.2016.04.06.01.54.14 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Apr 2016 01:54:14 -0700 (PDT) From: Thomas Monjalon To: "Weglicki, MichalX" Cc: Marc Sune , "Xu, Qian Q" , "Xing, Beilei" , dev@dpdk.org, "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Glynn, Michael J" , "Gray, Mark D" Date: Wed, 06 Apr 2016 10:52:37 +0200 Message-ID: <1510689.gPteTu5Ds8@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1AFA2937E172CD4DB2FD9318443C060EE95711@IRSMSX103.ger.corp.intel.com> References: <1458934950-23333-1-git-send-email-thomas.monjalon@6wind.com> <1458955640-22951-5-git-send-email-marcdevel@gmail.com> <1AFA2937E172CD4DB2FD9318443C060EE95711@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v13 4/8] ethdev: rename link speed constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 08:54:15 -0000 2016-04-06 08:34, Weglicki, MichalX: > Hello, > > I have a question about this patch. > > As far as I see changing ETH_LINK_SPEED_ to ETH_SPEED_NUM_ is rather cosmetic change, am I right? No. ETH_LINK_SPEED was used for configuration and reported speed. Now the configuration is done with a bitmap filled with new ETH_LINK_SPEED and the old numerical values are kept for other usages as ETH_SPEED_NUM. > Disadvantage of that is that it breaks compatibility with OVS (compilation) and thus it also breaks backward compatibility between OVS & DPDK. Is it really necessary? Yes that's why this change was discussed 9 months ago and announced in the previous release notes. > It would be great to keep ABI & API stable if possible. We try to keep it stable when possible and continue to bring some improvements.