From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 2EA8B6A87 for ; Mon, 29 Sep 2014 19:27:26 +0200 (CEST) Received: by mail-wg0-f49.google.com with SMTP id x12so943842wgg.32 for ; Mon, 29 Sep 2014 10:34:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ciPjACCd/+NI79Lu0Q+3FLFuEja1a9xRAHd9D5o9fNc=; b=GlHksfWhtiYSHW+CO+VAsARM6GWyny5f+kezvz7otGRDrVxD9DIIYEqpdrr1nrFqST +gk/GDhxffWAwQc5Ddnx1/3cweaPfhIxd2IAj5sdB7pjh3tMIAsQN6SuYaTV4lohI5y8 oTbkLa4dqMngO1sSlAfofFlXMkQOC12wY/wOOpxGEmQ5ejeMTclC31XHbwmeky3HUem3 bk4YmQMT/gRyJTsAUqunje9QOvpBS05cCrNzw+YZBsj1dXZeB4ZkFhwhyOsH/0rB2Mxa W48mYLdEGfgTom5WGWNEUq25UlnpjyN7Ak7hbrmtIrU+U1Wy5ornLhIMWxxTLhVMR7SJ cnDQ== X-Gm-Message-State: ALoCoQn1C9+bd+jAQlj3s1/J/38wnYL2Wm0ncBQcFC7c0x36PkBzWMmmCOI/oikJ+SH+fJ9KjrrU X-Received: by 10.180.19.167 with SMTP id g7mr49916247wie.19.1412012043000; Mon, 29 Sep 2014 10:34:03 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id eg8sm12367657wib.15.2014.09.29.10.34.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Sep 2014 10:34:02 -0700 (PDT) From: Thomas Monjalon To: Ouyang Changchun Date: Mon, 29 Sep 2014 19:33:46 +0200 Message-ID: <1510758.TZ42VHCBNy@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1411707653-10661-1-git-send-email-changchun.ouyang@intel.com> References: <1411707653-10661-1-git-send-email-changchun.ouyang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] ethdev: Rename RX/TX enable queue field for queue start and stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2014 17:27:26 -0000 2014-09-26 13:00, Ouyang Changchun: > V3 change: > - Rename field name to rx_deferred_start/tx_deferred_start in > both ixgbe and i40e PMD. > - Move the doxygen comments for rx_deferred_start after it is declared. > - Simplify/split the long description and move some to doxygen comments of > rte_eth_dev_rx_queue_start and rte_eth_dev_tx_queue_start. > > V2 and V1 change: > - Update comments for the field start_rx_per_q for better readability. > - Rename the field name to rx_enable_queue for better readability too. > - Accordingly Update its reference in sample vhost. > > Signed-off-by: Changchun Ouyang Acked and applied with some minor changes in comments. Thanks -- Thomas