From: Gellert Babel <gellert.babel@ericsson.com>
To: <yliu@fridaylinux.org>, <maxime.coquelin@redhat.com>
Cc: <dev@dpdk.org>, Jan Wickbom <jan.wickbom@ericsson.com>,
Gellert Babel <gellert.babel@ericsson.com>
Subject: [dpdk-dev] [PATCH] vhost user: unlink sockaddr when poll sched fails
Date: Mon, 20 Nov 2017 07:59:13 +0100 [thread overview]
Message-ID: <1511161153-5127-1-git-send-email-gellert.babel@ericsson.com> (raw)
From: Jan Wickbom <jan.wickbom@ericsson.com>
Issue:
Vhost user socket addresses left in /var/run/openvswitch.
This will lead to failure to add vhost user ports with names that
already exist in this directory.
When there is a failure to add a vhost user socket file descriptor to
the file descriptor set using fdset_add() in
rte_vhost_driver_register() the address bound to the socket is not
released.
Solution:
Add unlink of the file path corresponding to the socket address.
Signed-off-by: Jan Wickbom <jan.wickbom@ericsson.com>
Signed-off-by: Gellert Babel <gellert.babel@ericsson.com>
---
lib/librte_vhost/socket.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index 41aa3f9..eb9dae2 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -352,6 +352,7 @@ struct vhost_user {
err:
close(fd);
+ unlink(path);
return -1;
}
--
1.9.1
next reply other threads:[~2017-11-20 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 6:59 Gellert Babel [this message]
2017-11-20 9:18 ` Tan, Jianfeng
[not found] ` <CGME20171120130713eucas1p21960847cb6dd2927200d623d4fcf27b8@eucas1p2.samsung.com>
2017-11-20 13:07 ` Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511161153-5127-1-git-send-email-gellert.babel@ericsson.com \
--to=gellert.babel@ericsson.com \
--cc=dev@dpdk.org \
--cc=jan.wickbom@ericsson.com \
--cc=maxime.coquelin@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).